The SHIFT key, mapped on my graphic tablet is not working in Blender 2.80 #59854

Open
opened 2018-12-25 23:48:04 +01:00 by Toshe Andonov · 28 comments

System Information
Operating system: Windows 10
Graphics card: NVidia GeForce GTX 1070

Blender Version
Broken: 2.80 25-12-2018
(example: 2.79b release)
(example: 2.80, edbf15d3c0, blender2.8, 2018-11-28, as found on the splash screen)
Worked: (optional)

Short description of error

I own a Huion NEW 1060 PLUS 8192 graphics tablet. One of my keys is mapped as SHIFT, but Blender doesn't recognize it at all. As one of the pen keys is mapped as the Middle Mouse Button.
Another key on the tablet is mapped as CTRL, another as ALT etc. and they all work with the MMB on the pen, but the SHIFT key is not recognizable to Blender. I can zoom, I can rotate, I can change views but i cannot pan nor select multiple objects. Basically, everything that is connected to the SHIFT key is dead.
Blender recognizes the keyboard SHIFT key, as well as a mapped SHIFT shortcut on the mouse, but not on the tablet.
All around the OS and in Rhino, Photoshop, Illustrator, the Shift key from my tablet is working perfectly, but inside Blender no.

Oh, and this is the first time I'm trying 2.8.
Everything works fine in 2.79.

Exact steps for others to reproduce the error
Based on the default startup or an attached .blend file (as simple as possible).

**System Information** Operating system: Windows 10 Graphics card: NVidia GeForce GTX 1070 **Blender Version** Broken: 2.80 25-12-2018 (example: 2.79b release) (example: 2.80, edbf15d3c044, blender2.8, 2018-11-28, as found on the splash screen) Worked: (optional) **Short description of error** I own a Huion NEW 1060 PLUS 8192 graphics tablet. One of my keys is mapped as SHIFT, but Blender doesn't recognize it at all. As one of the pen keys is mapped as the Middle Mouse Button. Another key on the tablet is mapped as CTRL, another as ALT etc. and they all work with the MMB on the pen, but the SHIFT key is not recognizable to Blender. I can zoom, I can rotate, I can change views but i cannot pan nor select multiple objects. Basically, everything that is connected to the SHIFT key is dead. Blender recognizes the keyboard SHIFT key, as well as a mapped SHIFT shortcut on the mouse, but not on the tablet. All around the OS and in Rhino, Photoshop, Illustrator, the Shift key from my tablet is working perfectly, but inside Blender no. Oh, and this is the first time I'm trying 2.8. Everything works fine in 2.79. **Exact steps for others to reproduce the error** Based on the default startup or an attached .blend file (as simple as possible).
Author

Added subscriber: @ANDhitecture

Added subscriber: @ANDhitecture

#61692 was marked as duplicate of this issue

#61692 was marked as duplicate of this issue
Author

This comment was removed by @ANDhitecture

*This comment was removed by @ANDhitecture*
Member

Added subscriber: @DanielGrauer

Added subscriber: @DanielGrauer
Author

Version 26.12.18 - Shift key is still dead on the tablet.

Version 26.12.18 - Shift key is still dead on the tablet.
Member

i have made a fix in the code of blender, but since my knowledge is limited i might have not understood some of the magic that was done with the shift buttons.
https://developer.blender.org/T59882

here is a build i made yesterday, maybe you can give it a try and let me know if the fix works for you as well.
name

i have made a fix in the code of blender, but since my knowledge is limited i might have not understood some of the magic that was done with the shift buttons. https://developer.blender.org/T59882 here is a build i made yesterday, maybe you can give it a try and let me know if the fix works for you as well. [name ](https://drive.google.com/file/d/1mAC6BjDj4FJ8VeGU9EPFYvsDip-k4EJP/view?usp=sharing)
Member

i added the diff as a revision, i hope that is how this should be done? otherwise please let me know so i can do it correct in the future.

i added the diff as a revision, i hope that is how this should be done? otherwise please let me know so i can do it correct in the future.
Author

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Toshe Andonov self-assigned this 2018-12-28 00:21:13 +01:00
Author

In #59854#588574, @DanielGrauer wrote:
i have made a fix in the code of blender, but since my knowledge is limited i might have not understood some of the magic that was done with the shift buttons.
https://developer.blender.org/T59882

here is a build i made yesterday, maybe you can give it a try and let me know if the fix works for you as well.
name

In #59854#588667, @DanielGrauer wrote:
i added the diff as a revision, i hope that is how this should be done? otherwise please let me know so i can do it correct in the future.

Yes! This is the fix. Blend it! :)

I don't know if I should've done that = Close - Resolved. Correct me if I did something I shouldn't have.

> In #59854#588574, @DanielGrauer wrote: > i have made a fix in the code of blender, but since my knowledge is limited i might have not understood some of the magic that was done with the shift buttons. > https://developer.blender.org/T59882 > > here is a build i made yesterday, maybe you can give it a try and let me know if the fix works for you as well. > [name ](https://drive.google.com/file/d/1mAC6BjDj4FJ8VeGU9EPFYvsDip-k4EJP/view?usp=sharing) > In #59854#588667, @DanielGrauer wrote: > i added the diff as a revision, i hope that is how this should be done? otherwise please let me know so i can do it correct in the future. Yes! This is the fix. Blend it! :) I don't know if I should've done that = Close - Resolved. Correct me if I did something I shouldn't have.

Changed status from 'Resolved' to: 'Open'

Changed status from 'Resolved' to: 'Open'
Toshe Andonov was unassigned by Brecht Van Lommel 2018-12-28 00:31:26 +01:00
Member

@ANDhitecture its not really fixed, it just shifts the functionality from one to the other, with this change we lose the shift+numpad functionality which is not good.
I will try to do a proper fix so both is working but it will take me some time due to my inexperience. i think this should stay open for the time since the issue has not been fixed.

@ANDhitecture its not really fixed, it just shifts the functionality from one to the other, with this change we lose the shift+numpad functionality which is not good. I will try to do a proper fix so both is working but it will take me some time due to my inexperience. i think this should stay open for the time since the issue has not been fixed.
Author

I didn't notice that, but yes. I just checked it.
I'm still using 2.79 primarily. But I'm hoping that all of my "work stopping" issues will be resolved sooner, so I can transfer to the beta completely.

I didn't notice that, but yes. I just checked it. I'm still using 2.79 primarily. But I'm hoping that all of my "work stopping" issues will be resolved sooner, so I can transfer to the beta completely.

Added subscriber: @rizalator

Added subscriber: @rizalator

In #59854#588574, @DanielGrauer wrote:
i have made a fix in the code of blender, but since my knowledge is limited i might have not understood some of the magic that was done with the shift buttons.
https://developer.blender.org/T59882

here is a build i made yesterday, maybe you can give it a try and let me know if the fix works for you as well.
name

Hey guys, can any of you teach me how to do this?

> In #59854#588574, @DanielGrauer wrote: > i have made a fix in the code of blender, but since my knowledge is limited i might have not understood some of the magic that was done with the shift buttons. > https://developer.blender.org/T59882 > > here is a build i made yesterday, maybe you can give it a try and let me know if the fix works for you as well. > [name ](https://drive.google.com/file/d/1mAC6BjDj4FJ8VeGU9EPFYvsDip-k4EJP/view?usp=sharing) Hey guys, can any of you teach me how to do this?

Added subscribers: @Fumaria, @ZedDB

Added subscribers: @Fumaria, @ZedDB

Added subscriber: @Dayrook

Added subscriber: @Dayrook

System Information
Operating system: Windows 10 Home, Version 1903
Tablet: GAOMON PD1560

Blender Version
Broken: 2.80, 2.81 Alpha abeab4fcad

Short description of error
Same error as original post shows up with Gaomon PD1560.
Tablet physical buttons work correctly in other applications, and they're all apparently functional in Blender - except "shift".

kromar's fix works.

I'm being selfish, but aren't enough people using Blender for sculpting that we can make this diff the norm?
D4126: fix shift button for input devices (tablets)

Even accepting the 'shift+numpad' bug -- reaching numpad from the right shift button isn't a stretch...
70de23d

**System Information** Operating system: Windows 10 Home, Version 1903 Tablet: GAOMON PD1560 **Blender Version** Broken: 2.80, 2.81 Alpha abeab4fcad66 **Short description of error** Same error as original post shows up with Gaomon PD1560. Tablet physical buttons work correctly in other applications, and they're all apparently functional in Blender - except "shift". kromar's fix works. I'm being selfish, but aren't enough people using Blender for sculpting that we can make this diff the norm? [D4126: fix shift button for input devices (tablets)](https://archive.blender.org/developer/D4126) Even accepting the 'shift+numpad' bug -- reaching numpad from the right shift button isn't a stretch... 70de23d
Member

i think trading one bug for an other is not a nice solution and im pretty sure a programmer can fix this issue. what i did is just a workaround and not a real fix unfortunately.

i think trading one bug for an other is not a nice solution and im pretty sure a programmer can fix this issue. what i did is just a workaround and not a real fix unfortunately.

Added subscriber: @Kenolisauce

Added subscriber: @Kenolisauce

Hey, could anyone explain to me how to properly apply this patch on windows? I've got a local copy of blender-git but anytime I try to apply the patch with git bash it fails.
I'd really appreciate the help as this process isn't very well documented and the documentation there is is not friendly to non-programmers like myself.

Hey, could anyone explain to me how to properly apply this patch on windows? I've got a local copy of blender-git but anytime I try to apply the patch with git bash it fails. I'd really appreciate the help as this process isn't very well documented and the documentation there is is not friendly to non-programmers like myself.

Added subscriber: @mbloflin

Added subscriber: @mbloflin

I can confirm same bug still in 2.90b. My workaround for panning is to map Shift+MMB but you can map only so many combo's of Shift...

I can confirm same bug still in 2.90b. My workaround for panning is to map Shift+MMB but you can map only so many combo's of Shift...

Added subscriber: @PrototypeNM1

Added subscriber: @PrototypeNM1

For anyone interested in resolving this issue, the cause and fix for weird Windows behavior are documented here .

For anyone interested in resolving this issue, the cause and fix for weird Windows behavior are documented [here ](https://blog.molecular-matters.com/2011/09/05/properly-handling-keyboard-input/).

Marking this as a good first issue as fixing this is well documented in the link in my comment above and the fix would be constrained to a single file.

For anyone interested in working on this and in need of a mentor feel free to message me with questions.

Marking this as a good first issue as fixing this is well documented in the link in my comment above and the fix would be constrained to a single file. For anyone interested in working on this and in need of a mentor feel free to message me with questions.

Added subscriber: @astronotter-4

Added subscriber: @astronotter-4
AJP self-assigned this 2021-07-10 18:01:10 +02:00

Hi, I can take this, but I will need someone to test on actual hardware for me once I have a potential solution.

Hi, I can take this, but I will need someone to test on actual hardware for me once I have a potential solution.

I've done some digging and multiple sources (including the one mentioned by @PrototypeNM1) suggest using MapVirtualKey with the flag MAPVK_VSC_TO_VK_EX to differentiate left and right shift safely, rather than attempting to make sense of the scancodes directly.
All of this being unfortunately theoretical for me at the moment, since I can't test the tablet in question. I did confirm that Shift stays held during numlock 1,2,3 (hopefully no regression to Fix #29932) at least with the AT-style keyboard that I had available.

I've done some digging and multiple sources (including the one mentioned by @PrototypeNM1) suggest using MapVirtualKey with the flag MAPVK_VSC_TO_VK_EX to differentiate left and right shift safely, rather than attempting to make sense of the scancodes directly. All of this being unfortunately theoretical for me at the moment, since I can't test the tablet in question. I did confirm that Shift stays held during numlock 1,2,3 (hopefully no regression to Fix #29932) at least with the AT-style keyboard that I had available.
Philipp Oeser removed the
Interest
User Interface
label 2023-02-10 09:25:57 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
10 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#59854
No description provided.