Page MenuHome

The tool system's "Spin" and "Spin (Duplicate)" operators are the same
Closed, ResolvedPublic

Description

System Information
Operating system: Win10
Graphics card: nVidia Quadro 600

Blender Version
Broken: 2.80 (sub 41), branch: master, commit date: 2019-01-16 19:04, hash: 8ba86020cc50
Worked: N/A

Short description of error
The tool system's "Spin" and "Spin (Duplicate)" operators are the same. In other words they do the same thing by default. I believe that "Spin (Duplicate)" should have the "Dupli" option checked/set to True, but this is not the case.

Additionally, it would be best to spell out "Dupli" in the UI -- "Use Duplicates" would be my suggestion.

Exact steps for others to reproduce the error

  • Start with default .blend
  • Go to Edit mode on cube
  • Try to use the Spin or Spin (Duplicate) operators from the new T-panel
  • Observe that, by default, they both do the same thing and have the same settings

Event Timeline

Jacques Lucke (JacquesLucke) lowered the priority of this task from Needs Triage by Developer to Confirmed, Medium.Jan 18 2019, 12:00 PM

Apart from the bug itself, I agree we should revise the naming here.

'Spin (Duplicate)' -> 'Spin Duplicates'
'Dupli' -> 'Use Duplicates'

No need to be needlessly cryptic.

Not sure its a bug, but rather a naming issue.
If you look at the panel, you have to check 'Dupli' for it to duplicate.


Otherwise it just spins.
So like in 2.79 there is just 'spin' then you click 'dupli' for duplicate. There is not 'spin' and 'spin (duplicate)'.

Correction; it is a bug.
Spin (Duplicate) should open with 'dupli' set to True and it is not.

As you can see from the code, it is supposed to be defaulted to 'True', but it either is getting
overwritten on window update or something else. Will dig further.

def km_3d_view_tool_edit_mesh_spin(params):
    return (
        "3D View Tool: Edit Mesh, Spin",
        {"space_type": 'VIEW_3D', "region_type": 'WINDOW'},
        {"items": [
            ("mesh.spin", {"type": params.tool_tweak, "value": 'ANY'}, None),
        ]},
    )


def km_3d_view_tool_edit_mesh_spin_duplicate(params):
    return (
        "3D View Tool: Edit Mesh, Spin (Duplicate)",
        {"space_type": 'VIEW_3D', "region_type": 'WINDOW'},
        {"items": [
            ("mesh.spin", {"type": params.tool_tweak, "value": 'ANY'},
             {"properties": [("dupli", True)]}),
        ]},
    )

I believe this is still an issue. Here's a gif that shows the issue -- The initial invocation of the Spin (Duplicate) tool still does not have the correct option set:

I can't redo this - the setting is always set correctly in 6db9b443bb5b893b2807850a43de56e81c77160e

Tried again with today's build of master (e45cfb574ee7) using --factory-startup plus a completely clean preferences directory: it still repro's for me. At least one other person on blender-coders was also able to confirm the issue still happens for them as well. Is there anything for me to try and debug on my side (I have debug build available to set breakpoints as well)