Selection menu for properties does not preselect current item. #60817

New Issue

matc · 2019-01-24T14:11:11+01:00

matc commented

2019-01-24 14:11:11 +01:00

System Information
Operating system:
Graphics card:

Blender Version
Broken:
2.80, a3261aad13, 2019-01-04
2.79, f4dc9f9d68, 2018-03-22 (is slightly less broken than 2.80)
Worked:

Short description of error
No item or the wrong item is selected when the selection menu of a property is opened.

Exact steps for others to reproduce the error
Open default startup .blend.
Add "Copy Location" constraint to "Cube". (Bug is not limited to constraints.)
Set Target to "Light"
Open selection menu again for Target. "Camera" will be highlighted instead of "Light".

Possible fix
The attached diff passes the data behind PointerRNA *ptr as active item. This ends up in overwriting the current value of but->func_arg2. I can't tell whether this will cause problems somewhere else.
preselect.diff

**System Information** Operating system: Graphics card: **Blender Version** Broken: 2.80, a3261aad130e, 2019-01-04 2.79, f4dc9f9d68b, 2018-03-22 (is slightly less broken than 2.80) Worked: **Short description of error** No item or the wrong item is selected when the selection menu of a property is opened. **Exact steps for others to reproduce the error** Open default startup .blend. Add "Copy Location" constraint to "Cube". (Bug is not limited to constraints.) Set Target to "Light" Open selection menu again for Target. "Camera" will be highlighted instead of "Light". **Possible fix** The attached diff passes the data behind `PointerRNA *ptr` as active item. This ends up in overwriting the current value of `but->func_arg2`. I can't tell whether this will cause problems somewhere else. [preselect.diff](https://archive.blender.org/developer/F6389414/preselect.diff)

matc commented

2019-01-24 14:11:11 +01:00

Added subscriber: @matc

Jacques Lucke commented

2019-01-24 15:25:18 +01:00

Added subscriber: @JacquesLucke

Jacques Lucke commented

2019-01-24 15:25:18 +01:00

Can confirm.

Best would be if you submit you proposed fix as patch so that devs that know more about the side effects can do a code review.

Can confirm. Best would be if you submit you proposed fix as patch so that devs that know more about the side effects can do a code review.

Campbell Barton commented

2019-04-29 06:47:06 +02:00

Added subscriber: @ideasman42

Campbell Barton commented

2019-04-29 06:47:06 +02:00

Setting low priority since this isn't new in 2.8x.

matc commented

2019-05-03 22:22:35 +02:00

I think the easiest way to fix this, is to use the property value as active item in ui_searchbox_update.

I previously thought that but->func_arg2 was NULL whenever the active item was not displayed correctly. But apparently it is set to block->func_arg2. And the same happens with but->func. This means there is not really a way to update func_arg2 without messing up the expected arguments for func.

This works fine with PROP_POINTER, and as before for everything else:

diff --git a/source/blender/editors/interface/interface_region_search.c b/source/blender/editors/interface/interface_region_search.c
index 251bc86a3f5..a647693b75f 100644
--- a/source/blender/editors/interface/interface_region_search.c
+++ b/source/blender/editors/interface/interface_region_search.c
@@ -325,9 +325,20 @@ void ui_searchbox_update(bContext *C, ARegion *ar, uiBut *but, const bool reset)
     data->items.offset_i = data->items.offset = 0;
     data->active = -1;

-    /* handle active */
-    if (but->search_func && but->func_arg2) {
+    if (but->rnapoin.data && but->rnaprop && RNA_property_type(but->rnaprop) == PROP_POINTER) {
+      /* Buttons that prepare the search box through ui_but_add_search get in ui_def_but their
+       * func_arg2 set to the same value as its block. Therefore if we have a property, using the
+       * property value as the active item makes more sense here.
+       */
+      PointerRNA ptr = RNA_property_pointer_get(&but->rnapoin, but->rnaprop);
+      data->items.active = ptr.data;
+    }
+    else {
       data->items.active = but->func_arg2;
+    }
+
+    /* handle active */
+    if (but->search_func && data->items.active) {
       but->search_func(C, but->search_arg, but->editstr, &data->items);
       data->items.active = NULL;

I think the easiest way to fix this, is to use the property value as active item in ui_searchbox_update. I previously thought that but->func_arg2 was NULL whenever the active item was not displayed correctly. But apparently it is set to block->func_arg2. And the same happens with but->func. This means there is not really a way to update func_arg2 without messing up the expected arguments for func. This works fine with PROP_POINTER, and as before for everything else: ``` diff --git a/source/blender/editors/interface/interface_region_search.c b/source/blender/editors/interface/interface_region_search.c index 251bc86a3f5..a647693b75f 100644 --- a/source/blender/editors/interface/interface_region_search.c +++ b/source/blender/editors/interface/interface_region_search.c @@ -325,9 +325,20 @@ void ui_searchbox_update(bContext *C, ARegion *ar, uiBut *but, const bool reset) data->items.offset_i = data->items.offset = 0; data->active = -1; - /* handle active */ - if (but->search_func && but->func_arg2) { + if (but->rnapoin.data && but->rnaprop && RNA_property_type(but->rnaprop) == PROP_POINTER) { + /* Buttons that prepare the search box through ui_but_add_search get in ui_def_but their + * func_arg2 set to the same value as its block. Therefore if we have a property, using the + * property value as the active item makes more sense here. + */ + PointerRNA ptr = RNA_property_pointer_get(&but->rnapoin, but->rnaprop); + data->items.active = ptr.data; + } + else { data->items.active = but->func_arg2; + } + + /* handle active */ + if (but->search_func && data->items.active) { but->search_func(C, but->search_arg, but->editstr, &data->items); data->items.active = NULL; ```

Yevgeny Makarov commented

2021-12-01 14:55:31 +01:00

Added subscriber: @jenkm

Yevgeny Makarov commented

2021-12-01 14:55:31 +01:00

Can't reproduce, has it been fixed? I tried it in 3.1.0 and 2.93.5.

Yevgeny Makarov commented

2021-12-07 22:09:58 +01:00

Changed status from 'Confirmed' to: 'Needs Triage'

Germano Cavalcante commented

2022-02-16 15:06:15 +01:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2022-02-16 15:06:15 +01:00

Changed status from 'Needs Triage' to: 'Resolved'

Germano Cavalcante closed this issue

2022-02-16 15:06:15 +01:00

Germano Cavalcante self-assigned this 2022-02-16 15:06:15 +01:00

Germano Cavalcante commented

2022-02-16 15:06:15 +01:00

I reproduced this bug in the 2.80, but not the latest daily build, so it appears the bug has been fixed already.

If the problem persists, please let us know so we can re-open the report.

I reproduced this bug in the 2.80, but not the latest daily build, so it appears the bug has been fixed already. If the problem persists, please let us know so we can re-open the report.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Selection menu for properties does not preselect current item. #60817