Undo steps created for non-paint operations (brush size) #61948

New Issue

Paul · 2019-02-25T19:46:09+01:00

Paul commented

2019-02-25 19:46:09 +01:00

System Information
Operating system: Win7/Win10
Graphics card: gtx1070/hd620

Blender Version
Broken:
(2.79b, 7ad367d023
(2.80, 893fa59831, blender2.8, 2019-02-25)
Worked: (optional) Im pretty sure on some older versions of 2.79 it worked differently)

Short description of error
Some of blender actions like changing brush size/brush strenght are considered in blenders undo/redo history.
Exact steps for others to reproduce the error
Based on the default startup or an attached .blend file (as simple as possible).

Create any mesh, cube is fine
Go into sculpt mode/dynamic topology or texture paint
Make few strokes
Change brush size few times
Make another stroke
Hit undo and observe what is happening
You should see that it will undo your stroke from step 5. then when you hit another undo, there will be nothing changed since you were changing brush size and then after few more undos you will undo strokes from step 3.
Exact same problem when you redo.

How it should work.
Things like changing brush size/brush strenght/any other change like color picking and many more should not be in undo/redo list.

**System Information** Operating system: Win7/Win10 Graphics card: gtx1070/hd620 **Blender Version** Broken: (2.79b, 7ad367d0231d (2.80, 893fa598319e, blender2.8, 2019-02-25) Worked: (optional) Im pretty sure on some older versions of 2.79 it worked differently) **Short description of error** Some of blender actions like changing brush size/brush strenght are considered in blenders undo/redo history. **Exact steps for others to reproduce the error** Based on the default startup or an attached .blend file (as simple as possible). 1. Create any mesh, cube is fine 2. Go into sculpt mode/dynamic topology or texture paint 3. Make few strokes 4. Change brush size few times 5. Make another stroke 6. Hit undo and observe what is happening You should see that it will undo your stroke from step 5. then when you hit another undo, there will be nothing changed since you were changing brush size and then after few more undos you will undo strokes from step 3. Exact same problem when you redo. How it should work. Things like changing brush size/brush strenght/any other change like color picking and many more should not be in undo/redo list.

Paul commented

2019-02-25 19:46:09 +01:00

Added subscriber: @riceart

blender-admin commented

2019-02-25 19:46:09 +01:00

studio/blender-studio#62360 was marked as duplicate of this issue

Campbell Barton changed title from ~~Undo+Redo~~ to Undo steps created for non-paint operations (brush size)

2019-02-26 03:55:41 +01:00

Sebastian Parborg commented

2019-02-26 15:40:43 +01:00

Added subscribers: @brecht, @ZedDB

Sebastian Parborg commented

2019-02-26 15:40:43 +01:00

@brecht bug or not?

Brecht Van Lommel commented

2019-02-26 16:34:02 +01:00

Added subscriber: @ideasman42

Brecht Van Lommel commented

2019-02-26 16:34:02 +01:00

That's up to @campbellbarton.

Campbell Barton was assigned by Sebastian Parborg

2019-03-04 14:56:18 +01:00

Campbell Barton commented

2019-03-08 05:46:24 +01:00

It should properly handle these as undo steps or not add undo steps at all.

It wont be too much trouble to have it working as it was in 2.7x.

It should properly handle these as undo steps or not add undo steps at all. It wont be too much trouble to have it working as it was in 2.7x.

Brecht Van Lommel commented

2019-03-08 15:05:22 +01:00

Added subscriber: @JulienKaspar

Brecht Van Lommel commented

2019-03-08 15:05:58 +01:00

From studio/blender-studio#62360:

Currently when changing the brush size, strength and many more tool specific settings it is added to the undo history. I think there is a bigger design discussion behind this if this should even be allowed but the bug that is tied to this is that these steps, when undone are not actually undone.
They are just extra undo steps that do nothing. And since when sculpting, painting or drawing it is very common to very often change the size & strength of the current brush, the undo history gets flooded with undo steps that don't undo anything.

To add my take on how this should be fixed: Tool settings should never be included in the default undo history, just like interface changes have no undo steps.
My suggestion would be to perhaps add a second undo history for settings and interface changes, but only if these should still be undo-able.

From studio/blender-studio#62360: > Currently when changing the brush size, strength and many more tool specific settings it is added to the undo history. I think there is a bigger design discussion behind this if this should even be allowed but the bug that is tied to this is that these steps, when undone are not actually undone. > They are just extra undo steps that do nothing. And since when sculpting, painting or drawing it is very common to very often change the size & strength of the current brush, the undo history gets flooded with undo steps that don't undo anything. > > To add my take on how this should be fixed: Tool settings should never be included in the default undo history, just like interface changes have no undo steps. > My suggestion would be to perhaps add a second undo history for settings and interface changes, but only if these should still be undo-able.

Daniel Grauer commented

2019-04-07 17:15:21 +02:00

Added subscriber: @DanielGrauer