Page MenuHome

Drawing with annotations corrupts GPencil brushes
Closed, ResolvedPublic

Description

System Information
Operating system: win 7
Graphics card: Vega 64
Full System Information: Here

Blender Version
Broken: -1df6a98b176f-

Short description of error

Drawing with annotations corrupts GPencil brushes when in draw mode.

Exact steps for others to reproduce the error

  • New --> 2D Animation
  • Hold D key (I think Annotations should be enabled by default)
  • Upon releasing D key, GPencil brushes are corrupted and you can no longer draw in Grease Pencil mode.

Event Timeline

William Reynish (billreynish) triaged this task as Needs Information from User priority.

Cannot reproduce. It's unclear what you mean by 'GPencil brushes are corrupted'

Christopher Anderssarian (Christopher_Anderssarian) raised the priority of this task from Needs Information from User to Needs Triage by Developer.Mar 6 2019, 9:44 AM

Brushes get damaged...

Antonio Vazquez (antoniov) triaged this task as Confirmed, Medium priority.EditedMar 6 2019, 10:38 AM

I can replicate the problem.

When you use the annotation inside draw mode of grease pencil, the draw mode is disabled and set as Object mode (it's not logic do an annotation while you are drawing, they are incompatible things). After releasing the D key, the annotation is done, but the toolbar is still on the GP draw mode and the brushes are not found.

IMHO the annotation would be disabled while you are in drawing mode with a grease pencil. If you need an annotation, you can always add a new layer and write what you want. To keep annotations inside grease pencil drawing mode is a source of problems.

When you use the annotation inside draw mode of grease pencil, the draw mode is disabled and set as Object mode (it's not logic do an annotation while you are drawing, they are incompatible things). After releasing the D key, the annotation is done, but the toolbar is still on the GP draw mode and the brushes are not found.

Would a solution be to then automatically change back to GPencil Draw mode? When Annotating could the toolbar temporarily switch to the annotation's toolbar?

IMHO the annotation would be disabled while you are in drawing mode with a grease pencil. If you need an annotation, you can always add a new layer and write what you want. To keep annotations inside grease pencil drawing mode is a source of problems.

One of the things that makes Annotations so powerful is that in any editor (that supports it) in any mode you can quickly draw, add notes and brain storm.
With this commit the consistency between editors breaks for the first time.

This commit does not break the annotations logic. Annotations are a subset of grease pencil. If you are in grease pencil drawing you are already using annotations. In the first designs of new grease pencil, annotations disappear totally in 3D view, but we back it to give support to old add-ons and other things. (I'm talking in 3D view only).

You can see that 2D template has the annotations disabled in the overlay panel and the annotation icon is not in the toolbar. Be able to use D key in this mode was a bug (a back door opened by error), but breaks the design of how must work the tools in 3D view. We must not implement a back system to Draw mode after using annotations. This only adds complexity to something that doesn't add any new functionality. If you "really" want to use annotation, back to object mode, press D, draw annotation and back to draw mode.

Yeah, I understand...
I just don't like finding errors/bugs that (even though the correct and rightful solution) need be to removed/disabled....