Page MenuHome

[Blender ID] Password confirmation form has design problems.
Closed, ResolvedPublic

Description

Reproduction steps

  1. Goto https://www.blender.org/id/register/ fill in values, click register.
  2. Click on the registration link received via email. E.g. https://www.blender.org/id/register/password/MTU4NDE4/54e-124f7cbcdd22610ec862/

Notice how there are overlapping lines and other strange behavior.
Firefox (65.0.1 (64-bit)):

Google Chrome Canary74.0.3725.0 (official build) canary (64-Bit):

(I'm new to phabricator, so I hope I've added the correct tags etc)

Details

Type
Bug

Event Timeline

Fixed in rBID859f87484caa17dc4eb8ad1937784a85c489fe7d, but I would like to ask @Sybren A. Stüvel (sybren) to have a look a it as well.

On my development setup, when overriding the password selection view (^register/password/... in bid_main/urls.py) with auth_views.PasswordResetConfirmView.as_view() with the template registration/initial_set_password.html, the default Django template shows up.
We renaming registration/initial_set_password.html to registration/password_reset_confirm.html the template is displayed correctly.

The wrong templates being used was my mistaken in ccaef993d6b370007fb433e6aca355351faeb4c4, fixed it now properly in 6e514788f1e58a59030d2d86bd7b2eb608027608 and 2ec1b257b2751f7928fa49bbfb7244be7a7c8dc9.

The initial password form still has bad layout, though:

Francesco Siddi (fsiddi) closed this task as Resolved.Apr 12 2019, 5:41 PM