Page MenuHome

GreasePencil lasso acts as eraser in draw mode
Closed, ResolvedPublic

Description

System Information
Operating system: Windows 10
Graphics card: Nvidia Geforce GTX 1060

Blender Version
Broken: 2.80, 1df6a98b176f, blender2.8, 2019-03-05
Worked: 2.79b

Short description of error

If used in draw mode, the lasso_select strokes tool erases the points instead of selecting.

Exact steps for others to reproduce the error

1-set up a shortcut for "gpencil.select_lasso" in grease_pencil global context. (for example mouse press+ modifier)

2-try to select strokes by dragging across the selection while in "draw" mode

3-the points in the selection zone get deleted and not selected.

Details

Type
Bug

Event Timeline

I can confirm this with all types of selection, box selection, circle selection, and lasso selection, they act like the cutter tool

Pd: Ctrl + Alt + Left Button is the default shortcut for lasso select strokes

@iszotic (iszotic) : I dont think selection acts the same as the cutter tool (cutter would delete everything up until the next stroke crosssection)
From the code perspective, this seems to happen on purpose (if we really do lasso select):

/* if paint mode,delete selected points */
if (gpd->flag & GP_DATA_STROKE_PAINTMODE) {
	gp_delete_selected_point_wrap(C);
	changed = true;
	DEG_id_tag_update(&gpd->id, ID_RECALC_TRANSFORM | ID_RECALC_GEOMETRY);
}

I think this has always been the case, so not sure this is a bug?

@Antonio Vazquez (antoniov): However, atm. the cutter tool seems to be broken completely?
@Campbell Barton (campbellbarton) : not sure this is related, but you have recently changed toolsystem selection?

In Draw mode the select tools work as eraser. This was a request of the artist members of grease pencil team. The box select is enabled with B and lasso with Ctrl+Alt+RMB (we cannot use LMB because is used for other options).

In draw mode, the selection is not needed and to have this fast eraser method is very handy.

@Philipp Oeser (lichtwerk) I don't know what you mean with cutter broken... I just have compiled and tested and for me works perfect

I think we could close this bug because it's not a bug, but a design decission.

@Philipp Oeser (lichtwerk) What do you think?

Philipp Oeser (lichtwerk) claimed this task.

@Antonio Vazquez (antoniov) , @Campbell Barton (campbellbarton) : sorry for the noise (I didnt test with Factory Settings), so yeah, cutter seems to work fine then and so does selection for eraser.

Think we can close this then?
@mchaptel (mchaptel) : feel free to comment again if issues persist...

mchaptel (mchaptel) added a comment.EditedMar 12 2019, 10:40 AM

If a design decision feels like a bug, shouldn't it be reversed?

There's no reason for the same tool to behave differently across modes, and it's always possible to select and then delete.

it would make more sense to have a separate delete tool, and set that as the same shortcut in the draw context. As it is no user outside the dev team will ever think this is intended. Let people choose wether they like this function or not.

Selecting strokes in draw mode has real value, for example to use eraser with selection mask, or to set up move shortcuts.

In draw mode, the selection is not needed

Selecting strokes in draw mode has real value, for example to use eraser with selection mask, or to set up move shortcuts.

Not sure which way to go here, not too familiar with greasepencil, but atm. you wouldnt have a way to even see your selection in drawmode and moving seems to be designed for editmode?
Of course this could all be changed, but I feel this is more of a feature request than a real bug? Have you discussed this with others? https://blender.community/c/rightclickselect/?

letting @Antonio Vazquez (antoniov) decide...

It seems selection disappears when going into draw mode, but that's another decision that doesn't make sense. It's unintuitive to have a tool not behave the same in all modes even if some people decide otherwise. Consistency is at the forefront of the new 2.8 design.

This was a crucial part of the way to work in 2.79 with which I have extensive experience.

@mchaptel (mchaptel) I understand your point, but grease pencil is something totally new (as it's design today), so we must take decisions in order to make a good 2D animation software...sometimes keeps all keys equals in all modes is not the best solution.

@Daniel Martinez Lara (pepeland) @Matias Mendiola (mendio) What is your point of view?

Maybe it would be best to have a gpencil.lasso_eraser operator and let people customise it the way they like?

It could also be a useful tool on its own in other modes, and it's more explicit?

I think to design the best 2D tool, it's important to take note from other popular 2D softwares and in these, selection is an integral part of the drawing process.

Another solution would be to go back to only one "edit strokes" mode in which you can draw, edit and sculpt (those would now be tools and not modes) but I understand this is out of the scope of this bug report.