ShaderNodeCustomGroup insert_link is not listening to inserts #62670

New Issue

Sergey · 2019-03-17T06:19:06+01:00

Sergey commented

2019-03-17 06:19:06 +01:00

System Information
Operating system: Windows 8 64 bit
Graphics card: notebook integrated, render with CPU

Blender Version
Broken: 2.8. cc5bdf0293
Worked: worked in 2.8 with NodeCustomGroup

Short description of error
The new ShaderNodeCustomGroup seems to inherit all methods of the old NodeCustomGroup but insert_link doesn't seem to be working properlty unless I have bugs in my code

Exact steps for others to reproduce the error

run the script, you will see the new node pop up
note that in the script, the insert_link function is defined:

insert_link(self, link):

print("insert_link reporting")
return

try linking any input/output of the custom node
there's no printing to console{F6837513}

bug_report.py

bug_report_insert_link.blend

**System Information** Operating system: Windows 8 64 bit Graphics card: notebook integrated, render with CPU **Blender Version** Broken: 2.8. cc5bdf029324 Worked: worked in 2.8 with NodeCustomGroup **Short description of error** The new ShaderNodeCustomGroup seems to inherit all methods of the old NodeCustomGroup but insert_link doesn't seem to be working properlty unless I have bugs in my code **Exact steps for others to reproduce the error** 1. run the script, you will see the new node pop up 2. note that in the script, the insert_link function is defined: ``` ``` ``` insert_link(self, link): ``` print("insert_link reporting") return ``` ``` 3. try linking any input/output of the custom node 4. there's no printing to console{[F6837513](https://archive.blender.org/developer/F6837513/bug_report_insert_link.blend)} [bug_report.py](https://archive.blender.org/developer/F6837516/bug_report.py) [bug_report_insert_link.blend](https://archive.blender.org/developer/F6837520/bug_report_insert_link.blend)

Sergey commented

2019-03-17 06:19:06 +01:00

Added subscriber: @serhii1994

Miguel Porces commented

2019-03-17 07:16:22 +01:00

Added subscriber: @Secrop

Miguel Porces commented

2019-03-17 10:24:25 +01:00

To respond to new link events you need to use the update() and check if there's any changes in your existent sockets.

The insert_link() is used internally to add and verify if links are valid (for example if an input socket has more than 1 link, etc). Not to respond to link changes.

I'll probably hide this function from the api, as it has little meaning for Shader and Compositor Nodetrees... You need a NodeLink struct to call the function, and the api doesn't let you create NodeLinks independently, except when calling new() from a NodeLink Collection (which then makes the insert_link() desnecessary because the link is already in the collection..).

To respond to new link events you need to use the `update()` and check if there's any changes in your existent sockets. The `insert_link()` is used internally to add and verify if links are valid (for example if an input socket has more than 1 link, etc). Not to respond to link changes. I'll probably hide this function from the api, as it has little meaning for Shader and Compositor Nodetrees... You need a NodeLink struct to call the function, and the api doesn't let you create NodeLinks independently, except when calling `new()` from a NodeLink Collection (which then makes the `insert_link()` desnecessary because the link is already in the collection..).

Sergey self-assigned this 2019-03-17 11:51:39 +01:00

Sergey commented

2019-03-17 11:51:39 +01:00

So, how do I use it? update() takes no arguments... how can I determine which socket was affected and where the link was created? to check for new changes, you have to keep the old state in some form or? the only thing I can think of... IFF the function update() function runs automatically on update, one could check the last link in the node_tree and so on... but honestly, that's just not serious:( plus there's even no documentation on it.

Sergey commented

2019-03-17 12:08:12 +01:00

please, gentlemen, I don't understand the approach. insert_link() worked just f i n e for my purposes in bpy.types.CustomNodeGroup. now it stopped working - that's an obvious bug... why not simply get it back? how do you even use update()? it does not take a single argument. to handle an event, you gotta have the event passed as argument...

Sergey was unassigned by Brecht Van Lommel

2019-03-18 10:32:46 +01:00

blender-admin commented

2019-03-18 11:16:34 +01:00

This issue was referenced by 1b06e3378a

This issue was referenced by 1b06e3378a750774cd7da76ab61f86476f7087cc

Brecht Van Lommel commented

2019-03-18 11:38:33 +01:00

Changed status from 'Open' to: 'Resolved'

Brecht Van Lommel closed this issue

2019-03-18 11:38:33 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

ShaderNodeCustomGroup insert_link is not listening to inserts #62670