Box selecting ".." in the file browser makes "Parent Directory" the default action. #63263

New Issue

Michael Hermann · 2019-04-04T01:25:39+02:00

Michael Hermann commented

2019-04-04 01:25:39 +02:00

System Information
Operating system: Linux-5.0.5-arch1-1-ARCH-x86_64-with-arch 64 Bits
Graphics card: GeForce GTX 1080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 418.56

Blender Version
Broken: version: 2.80 (sub 53), branch: blender2.7, commit date: 2019-04-02 19:53, hash: a813e259d6
Worked: (optional)

Short description of error
A box selection that includes files AND ".." turns the button on the right side to "Parent Directory" and the default action for pressing ENTER becomes going to the parent directory. ".." should be clickable, but not selectable, and the default action should always be "open" or "import" (e.g.).

Exact steps for others to reproduce the error

Go to "File" > "Open"
Press B to box select. Select a .blend file and ".." the parent directory.
Observe the Button to the right, that turns from "Open Blender File" to "Parent Directory"
Press the Button, or simply ENTER.

Works for File > Import/Expert as well. Basically everywhere.

**System Information** Operating system: Linux-5.0.5-arch1-1-ARCH-x86_64-with-arch 64 Bits Graphics card: GeForce GTX 1080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 418.56 **Blender Version** Broken: version: 2.80 (sub 53), branch: blender2.7, commit date: 2019-04-02 19:53, hash: `a813e259d6` Worked: (optional) **Short description of error** A box selection that includes files AND ".." turns the button on the right side to "Parent Directory" and the default action for pressing ENTER becomes going to the parent directory. ".." should be clickable, but not selectable, and the default action should always be "open" or "import" (e.g.). **Exact steps for others to reproduce the error** 1. Go to "File" > "Open" 2. Press B to box select. Select a .blend file and ".." the parent directory. 3. Observe the Button to the right, that turns from "Open Blender File" to "Parent Directory" 4. Press the Button, or simply ENTER. Works for File > Import/Expert as well. Basically everywhere.

Michael Hermann commented

2019-04-04 01:25:39 +02:00

Added subscriber: @MichaelHermann

Stephen Swaney commented

2019-04-04 05:01:21 +02:00

Added subscriber: @StephenSwaney

Stephen Swaney commented

2019-04-04 05:01:21 +02:00

I would label this is a quirk rather than a bug.
If you select a file AND "..", you have selected two things with different, incompatible semantics
I'm willing to argue that going to the parent directory takes precedence.

Making ".." clickable but unselectable just adds another quirky corner case.

I would label this is a quirk rather than a bug. If you select a file AND "..", you have selected two things with different, incompatible semantics I'm willing to argue that going to the parent directory takes precedence. Making ".." clickable but unselectable just adds another quirky corner case.

William Reynish commented

2019-04-04 10:03:07 +02:00

Added subscriber: @WilliamReynish

William Reynish commented

2019-04-04 10:03:07 +02:00

I wonder if we should remove the ‘..’ button, given that we also have a way to jump to the parent directory using a more standard button. Modern GUIs (read: since the 80s) don’t use ‘..’ to go to parent directories.

Michael Hermann commented

2019-04-04 12:07:29 +02:00

@StephenSwaney :

I'm willing to argue that going to the parent directory takes precedence.

When I box select e.g. 5 materials and accidentally ".." the I would definitely like to append the materials, rather than go to parent dir.

@WilliamReynish
My suggestion would be to keep the ".." button. It's good for keyboard-only navigation and also much easier/faster to reach with the mouse than smaller button in the top left.
I think this could be solved by either ignoring ".." when included in a selection of many items, or by auto-removing ".." from a selection of many items.
Or it could be unselectable by box selection in the first place. Why would you ever box select ".." ?! ;)

@StephenSwaney : > I'm willing to argue that going to the parent directory takes precedence. When I box select e.g. 5 materials and accidentally ".." the I would definitely like to append the materials, rather than go to parent dir. @WilliamReynish My suggestion would be to keep the ".." button. It's good for keyboard-only navigation and also much easier/faster to reach with the mouse than smaller button in the top left. I think this could be solved by either ignoring ".." when included in a selection of many items, or by auto-removing ".." from a selection of many items. Or it could be unselectable by box selection in the first place. Why would you ever box select ".." ?! ;)

William Reynish commented

2019-04-04 12:22:01 +02:00

Well, you can still have keyboard shortcuts to go to the parent folder, even if we don't have '..' inside the list of files.

Michael Hermann commented

2019-04-04 12:39:10 +02:00

I bet many are using ".." a lot to click on it as well. I (personally) would really like to keep it.

I bet many are using ".." a lot to click on it as well. I (personally) would **really** like to keep it.

Stephen Swaney commented

2019-04-04 16:07:49 +02:00

I bet many are using ".." a lot to click on it as well. I (personally) would really like to keep it.

Me, too. I believe the ".." parent directory convention has been in use since Mr. Babbage's original computer back in the 19th century.

> I bet many are using ".." a lot to click on it as well. I (personally) would really like to keep it. Me, too. I believe the ".." parent directory convention has been in use since Mr. Babbage's original computer back in the 19th century.

Ray molenkamp commented

2019-04-04 16:12:55 +02:00

Added subscriber: @LazyDodo

Ray molenkamp commented

2019-04-04 16:12:55 +02:00

I also say we keep the ".." but if it's selected with other files we just pretend it was never selected?

William Reynish commented

2019-04-04 17:26:18 +02:00

Afaik, both file browsers and open/save dialogs don't use a '..' any more, on both Mac, Linux and Windows, which are the main platforms we support and integrate with.

Stephen Swaney commented

2019-04-04 17:35:00 +02:00

I also say we keep the ".." but if it's selected with other files we just pretend it was never selected?

Yeah, what he said.

> I also say we keep the ".." but if it's selected with other files we just pretend it was never selected? Yeah, what he said.

Ray molenkamp commented

2019-04-04 17:37:18 +02:00

Yeah sure they don't have it anymore, on the other hand you can easily navigate to any part including the parent folder of the path by clicking on it.

Michael Hermann commented

2019-04-04 17:56:37 +02:00

In #63263#654844, @LazyDodo wrote:
[...] other hand you can easily navigate to any part including the parent folder of the path by clicking on it.

True. That's what I use most of the time. And I find the buttons for back, forward and up are somewhat harder to reach. MAYBE that would be better if the row of buttons would be left aligned with the file list (above the path). I.e. have flexible space between the "view" menu and the back button.

> In #63263#654844, @LazyDodo wrote: > [...] other hand you can easily navigate to any part including the parent folder of the path by clicking on it. True. That's what I use most of the time. And I find the buttons for back, forward and up are somewhat harder to reach. MAYBE that would be better if the row of buttons would be left aligned with the file list (above the path). I.e. have flexible space between the "view" menu and the back button.

William Reynish commented

2019-04-04 18:09:34 +02:00

Yes, the File Browser could have a layout more like this:

{F6886125, size=full}

Which would bring the 'Up' button closer to the list of files and folders.

Yes, the File Browser could have a layout more like this: {[F6886125](https://archive.blender.org/developer/F6886125/image.png), size=full} ![image.png](https://archive.blender.org/developer/F6886128/image.png) Which would bring the 'Up' button closer to the list of files and folders.

Ray molenkamp commented

2019-04-04 18:17:16 +02:00

I don't mind the windows way of doing things actually, they did away with the up button all together

by default the path bar is a bunch of buttons

and when it gets the focus, it turns into a text field you can edit

I don't mind the windows way of doing things actually, they did away with the up button all together by default the path bar is a bunch of buttons ![image.png](https://archive.blender.org/developer/F6911806/image.png) and when it gets the focus, it turns into a text field you can edit ![image.png](https://archive.blender.org/developer/F6911812/image.png)

Michael Hermann commented

2019-04-04 18:41:03 +02:00

Looks pretty nice, @WilliamReynish ! However, I'd prefer the filename and path both at the top. As well as the buttons. On large and high-res screens this is very far apart. Even with the current layout, the "Open" or "Cancel" etc. buttons are already far to the right.

William Reynish commented

2019-04-04 18:43:26 +02:00

@LazyDodo Yes it would be nice with a more inteligent breadcrumb system like that, if that's possible to do in Blender.

Ray molenkamp commented

2019-04-04 18:47:29 +02:00

guess suggesting using the OS dialog is heresy?

William Reynish commented

2019-04-04 18:47:37 +02:00

@MichaelHermann

That is how it is on all the platforms we support:

Windows

Linux

Mac

@MichaelHermann That is how it is on all the platforms we support: Windows ![LoadSaveFam.gif](https://archive.blender.org/developer/F6912116/LoadSaveFam.gif) Linux ![ZhBdRij.png](https://archive.blender.org/developer/F6912035/ZhBdRij.png) Mac ![Screenshot 2019-04-04 at 18.46.16.png](https://archive.blender.org/developer/F6912051/Screenshot_2019-04-04_at_18.46.16.png)

Ray molenkamp commented

2019-04-04 18:50:48 +02:00

That's an XP screenshot, that's not what it looks like now days, and definitely not a supported os, here's a more recent win7 one

That's an XP screenshot, that's not what it looks like now days, and definitely not a supported os, here's a more recent win7 one ![image.png](https://archive.blender.org/developer/F6912061/image.png)

William Reynish commented

2019-04-04 18:52:48 +02:00

@LazyDodo I don't think it's heresy, but we probably won't throw out the custom file browser.

It's nice to be able to keep as an editor for scenarios where you want to drag files continuously into Blender:

And will most likely be the basis of the asset browser.

@LazyDodo I don't think it's heresy, but we probably won't throw out the custom file browser. It's nice to be able to keep as an editor for scenarios where you want to drag files continuously into Blender: ![Screenshot 2019-04-04 at 18.51.07.png](https://archive.blender.org/developer/F6912065/Screenshot_2019-04-04_at_18.51.07.png) And will most likely be the basis of the asset browser.

Ray molenkamp commented

2019-04-04 18:55:18 +02:00

I'd like to retract the idea to use the OS dialog then, makes very little sense to maintain two codepaths. time better spend improving the one we have :)

Harley Acheson commented

2019-04-04 19:53:30 +02:00

Added subscriber: @Harley

Harley Acheson commented

2019-04-04 19:53:30 +02:00

@LazyDodo: they did away with the up button all together

No, the current version has an up button...

> @LazyDodo: they did away with the up button all together No, the current version has an up button... ![OpenDialog.png](https://archive.blender.org/developer/F6912139/OpenDialog.png)

Ray molenkamp commented

2019-04-04 19:57:00 +02:00

I stand corrected, nice touch by re-creating my insane directory structure :)

TheRedWaxPolice commented

2019-04-04 20:18:53 +02:00

Added subscriber: @TheRedWaxPolice

TheRedWaxPolice commented

2019-04-04 20:18:53 +02:00

In #63263#654870, @LazyDodo wrote:
I'd like to retract the idea to use the OS dialog then, makes very little sense to maintain two codepaths. time better spend improving the one we have :)

Is there a way/option to make the file browser open in a floating window, instead of covering the entire app? I find this behavior very annoying...

> In #63263#654870, @LazyDodo wrote: > I'd like to retract the idea to use the OS dialog then, makes very little sense to maintain two codepaths. time better spend improving the one we have :) Is there a way/option to make the file browser open in a floating window, instead of covering the entire app? I find this behavior very annoying...

William Reynish commented

2019-04-04 22:21:04 +02:00

@TheRedWaxPolice not currently but I think there could be. We could merge it with the option to render in a new window and make it a general preference instead, to apply to all kinds of temporary window states. Even the Preferences itself, which by default opens in a new window.

Julian Eisel commented

2019-04-04 22:47:32 +02:00

Added subscriber: @JulianEisel

Julian Eisel commented

2019-04-04 22:47:32 +02:00

Discussion about the general file browser design should go into #62971. A colleague and I are actually working on this so expect news soon.
I'd vote for removing the '..' entry. For some users it might be confusing, and there is a button and a shortcut for it ({nav P}). With the button moved close to the file path, as planned, I think that will become more discoverable.

Note on using the OS file browser: Another issue with that would be browsing inside .blend files for append/link. We'd somehow have to load our custom items into the OS file browser. Not sure if that's possible on any platform, not to speak about a cross platform solution.

Discussion about the general file browser design should go into #62971. A colleague and I are actually working on this so expect news soon. I'd vote for removing the '..' entry. For some users it might be confusing, and there is a button and a shortcut for it ({nav P}). With the button moved close to the file path, as planned, I think that will become more discoverable. Note on using the OS file browser: Another issue with that would be browsing inside .blend files for append/link. We'd somehow have to load our custom items into the OS file browser. Not sure if that's possible on any platform, not to speak about a cross platform solution.

TheRedWaxPolice commented

2019-04-04 23:58:59 +02:00

@WilliamReynish Sounds good... ?