Text Editor Footer Duplicates #63386

New Issue

Philip Holzmann · 2019-04-08T09:14:28+02:00

Philip Holzmann commented

2019-04-08 09:14:28 +02:00

System Information
Operating system: Windows 10 64 bit
Graphics card: Nvidia GTX 750 Ti

Blender Version
Broken: (blender-2.80.0-git.d2d84132ddf9-windows64)

Short description of error
The footer in the Text Editor that says "Text: Internal" duplicates every time the file is saved and reloaded.

Exact steps for others to reproduce the error
bug.blend
In the bottom right, you can already see 3 footers stacked on top of each other.

To get more footers:

Save the file
Revert

**System Information** Operating system: Windows 10 64 bit Graphics card: Nvidia GTX 750 Ti **Blender Version** Broken: (blender-2.80.0-git.d2d84132ddf9-windows64) **Short description of error** The footer in the Text Editor that says "Text: Internal" duplicates every time the file is saved and reloaded. **Exact steps for others to reproduce the error** [bug.blend](https://archive.blender.org/developer/F6918432/bug.blend) In the bottom right, you can already see 3 footers stacked on top of each other. To get more footers: - Save the file - Revert

Philip Holzmann commented

2019-04-08 09:14:28 +02:00

Added subscriber: @Foaly

George Vogiatzis commented

2019-04-08 09:21:25 +02:00

Added subscriber: @Gvgeo-1

George Vogiatzis self-assigned this 2019-04-08 09:21:25 +02:00

George Vogiatzis commented

2019-04-08 09:21:25 +02:00

The file didn't work.
But can confirm, will take a look at it.

The file didn't work. But can confirm, will take a look at it.

George Vogiatzis commented

2019-04-08 10:09:09 +02:00

Added subscribers: @JacquesLucke, @brecht

George Vogiatzis commented

2019-04-08 10:09:09 +02:00

@JacquesLucke @brecht
It looks like a version bump needed with footer.

Now there are some files saved with 1 or more footers already.

With adding a check,
if (!ar_header->next == RGN_TYPE_FOOTER) {
Ensures that no more footers will be added. And does not require version bump right now.

Should remove all the spares too? Or simply just version bump?
What is the correct action?

	/*if (!MAIN_VERSION_ATLEAST(bmain, 280, 55)) { */
	
		/* Versioning code until next subversion bump goes here. */
	{
		for (bScreen *screen = bmain->screens.first; screen; screen = screen->id.next) {
			for (ScrArea *sa = screen->areabase.first; sa; sa = sa->next) {
				for (SpaceLink *sl = sa->spacedata.first; sl; sl = sl->next) {
					if (sl->spacetype == SPACE_TEXT) {
						ListBase *regionbase = (sl == sa->spacedata.first) ? &sa->regionbase : &sl->regionbase;
						ARegion *ar = MEM_callocN(sizeof(ARegion), "footer for text");
						ARegion *ar_header = NULL;

						for (ar_header = regionbase->first; ar_header; ar_header = ar_header->next) {
							if (ar_header->regiontype == RGN_TYPE_HEADER) {
								break;
							}
						}
						/* if (!ar_header->next == RGN_TYPE_FOOTER) { */
							BLI_assert(ar_header);

							BLI_insertlinkafter(regionbase, ar_header, ar);

							ar->regiontype = RGN_TYPE_FOOTER;
							ar->alignment = (U.uiflag & USER_HEADER_BOTTOM) ? RGN_ALIGN_TOP : RGN_ALIGN_BOTTOM;
						/* } */
					}
				}
			}
		}
	}

@JacquesLucke @brecht It looks like a version bump needed with footer. Now there are some files saved with 1 or more footers already. With adding a check, `if (!ar_header->next == RGN_TYPE_FOOTER) {` Ensures that no more footers will be added. And does not require version bump right now. Should remove all the spares too? Or simply just version bump? What is the correct action? ``` /*if (!MAIN_VERSION_ATLEAST(bmain, 280, 55)) { */ /* Versioning code until next subversion bump goes here. */ { for (bScreen *screen = bmain->screens.first; screen; screen = screen->id.next) { for (ScrArea *sa = screen->areabase.first; sa; sa = sa->next) { for (SpaceLink *sl = sa->spacedata.first; sl; sl = sl->next) { if (sl->spacetype == SPACE_TEXT) { ListBase *regionbase = (sl == sa->spacedata.first) ? &sa->regionbase : &sl->regionbase; ARegion *ar = MEM_callocN(sizeof(ARegion), "footer for text"); ARegion *ar_header = NULL; for (ar_header = regionbase->first; ar_header; ar_header = ar_header->next) { if (ar_header->regiontype == RGN_TYPE_HEADER) { break; } } /* if (!ar_header->next == RGN_TYPE_FOOTER) { */ BLI_assert(ar_header); BLI_insertlinkafter(regionbase, ar_header, ar); ar->regiontype = RGN_TYPE_FOOTER; ar->alignment = (U.uiflag & USER_HEADER_BOTTOM) ? RGN_ALIGN_TOP : RGN_ALIGN_BOTTOM; /* } */ } } } } } ```

George Vogiatzis commented

2019-04-08 13:00:20 +02:00

made a patch D4663.

made a patch [D4663](https://archive.blender.org/developer/D4663).

blender-admin commented

2019-04-08 22:35:55 +02:00

This issue was referenced by 7655b32999

This issue was referenced by 7655b32999a0720ea9fcba6610bc9f4fbb56de25

Brecht Van Lommel commented

2019-04-08 22:55:10 +02:00

Changed status from 'Open' to: 'Resolved'

Brecht Van Lommel closed this issue

2019-04-08 22:55:10 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Text Editor Footer Duplicates #63386