Obj exporter does not respect "Apply Modifiers" settings #63399

New Issue

kursad k · 2019-04-08T19:19:46+02:00

kursad k commented

2019-04-08 19:19:46 +02:00

System Information
Operating system: Windows 10
Graphics card: GTX 1070

Blender Version
version: 2.80 (sub 53), branch: blender2.7, commit date: 2019-04-02 19:53, hash: a813e259d6, type: Release
build date: 02/04/2019, 18:01

Short description of error

The obj exporter does not seem to respect "use_mesh_modifiers=False" It always export as if it is set to "use_mesh_modifiers=True"

Exact steps for others to reproduce the error

Add Suzanne
Add Decimate modifier to Suzanne, set the value to 0.5
Open obj exporter
Make sure apply modifiers is unchecked, Selection only is checked
Export and imported it or check it out in a 3d viewer

As you see the mesh is exported with modifiers

**System Information** Operating system: Windows 10 Graphics card: GTX 1070 **Blender Version** version: 2.80 (sub 53), branch: blender2.7, commit date: 2019-04-02 19:53, hash: a813e259d630, type: Release build date: 02/04/2019, 18:01 **Short description of error** The obj exporter does not seem to respect "use_mesh_modifiers=False" It always export as if it is set to "use_mesh_modifiers=True" **Exact steps for others to reproduce the error** - Add Suzanne - Add Decimate modifier to Suzanne, set the value to 0.5 - Open obj exporter - Make sure apply modifiers is unchecked, Selection only is checked - Export and imported it or check it out in a 3d viewer As you see the mesh is exported with modifiers

kursad k commented

2019-04-08 19:19:47 +02:00

Added subscriber: @kursadk

Robert Guetzkow commented

2019-04-08 19:49:48 +02:00

Added subscriber: @rjg

Robert Guetzkow commented

2019-04-08 19:49:48 +02:00

Looks like EXPORT_APPLY_MODIFIERS is set to False when the option is unchecked but to_mesh() or another function applies the modifiers regardless.

Looks like `EXPORT_APPLY_MODIFIERS` is set to `False` when the option is unchecked but `to_mesh()` or another function applies the modifiers regardless.

Robert Guetzkow commented

2019-04-08 20:42:29 +02:00

Added subscriber: @Sergey

Robert Guetzkow commented

2019-04-08 20:42:29 +02:00

The functions rna_Object_to_mesh(), rna_Main_meshes_new_from_object() and BKE_mesh_new_from_object() all get apply_modifiers set to false as it should be. Could it be that this is an error introduced in 46eb5a0b8a @Sergey ?

The functions `rna_Object_to_mesh()`, `rna_Main_meshes_new_from_object()` and `BKE_mesh_new_from_object()` all get `apply_modifiers` set to `false` as it should be. Could it be that this is an error introduced in 46eb5a0b8a4f3a7826b5e5a1a11e114e09037dba @Sergey ?

Sergey Sharybin commented

2019-04-08 20:49:25 +02:00

Closed as duplicate of #63345

Sergey Sharybin closed this issue

2019-04-08 20:49:25 +02:00

Robert Guetzkow commented

2019-04-08 20:51:36 +02:00

@Sergey It seems to me that object_for_eval is set to the result of DEG_get_evaluated_object which has the modifiers applied, is used incorrectly in:

case OB_MESH:
			/* copies object and modifiers (but not the data) */
			if (cage) {
				/* copies the data (but *not* the shapekeys). */
				Mesh *mesh = object_for_eval.data;
				BKE_id_copy_ex(bmain, &mesh->id, (ID **)&tmpmesh, 0);
				/* XXX BKE_mesh_copy() already handles materials usercount. */
				do_mat_id_data_us = false;
			}

cage is true, if apply_modifiers isn't. Therefore mesh shouldn't be object_for_eval but the original mesh right?

@Sergey It seems to me that `object_for_eval` is set to the result of `DEG_get_evaluated_object` which has the modifiers applied, is used incorrectly in: ``` case OB_MESH: /* copies object and modifiers (but not the data) */ if (cage) { /* copies the data (but *not* the shapekeys). */ Mesh *mesh = object_for_eval.data; BKE_id_copy_ex(bmain, &mesh->id, (ID **)&tmpmesh, 0); /* XXX BKE_mesh_copy() already handles materials usercount. */ do_mat_id_data_us = false; } ``` `cage` is true, if `apply_modifiers` isn't. Therefore `mesh` shouldn't be `object_for_eval` but the original mesh right?

Sergey Sharybin commented

2019-04-08 21:17:51 +02:00

Changed status from 'Duplicate' to: 'Open'

Sergey Sharybin reopened this issue

2019-04-08 21:17:51 +02:00

Sergey Sharybin commented

2019-04-08 21:17:51 +02:00

Actually, re-opening as a stand-alone bug. It's somewhat related, but is not quite. Sorry for the noise.

@rjg, yes, but the responsible code is some lines above. Committing the fix now..

Actually, re-opening as a stand-alone bug. It's somewhat related, but is not quite. Sorry for the noise. @rjg, yes, but the responsible code is some lines above. Committing the fix now..

blender-admin commented

2019-04-08 21:21:09 +02:00

This issue was referenced by df26f28835

This issue was referenced by df26f28835fb8a98760aef2f41d947579e95e73e

Sergey Sharybin commented

2019-04-08 21:21:43 +02:00

Changed status from 'Open' to: 'Resolved'

Sergey Sharybin closed this issue

2019-04-08 21:21:43 +02:00

kursad k commented

2019-04-08 22:23:27 +02:00

I think this modifier bug was affecting other exporters as well.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Obj exporter does not respect "Apply Modifiers" settings #63399