Cycles does need recalculate MIP after modifying a material #63588

New Issue

Robert Brian · 2019-04-14T10:05:17+02:00

Robert Brian commented

2019-04-14 10:05:17 +02:00

System Information
Operating system: Windows 10, Ubuntu Linux 18.04
Graphics card: Geforce GTX 1060, Geforce RTX 2060

Blender Version
Broken: Blender 2.79.7 - April 13., 2.80 Beta - April 14.

Cycles GPU does need recalculate the Multiple Importance Map with HDRi after modifying a material. For some reason Octane and mostly other render engines doesn't need that. When it's a bug or not that makes it unreasonably difficult the shading process.

System Information Operating system: Windows 10, Ubuntu Linux 18.04 Graphics card: Geforce GTX 1060, Geforce RTX 2060 Blender Version Broken: Blender 2.79.7 - April 13., 2.80 Beta - April 14. Cycles GPU does need recalculate the Multiple Importance Map with HDRi after modifying a material. For some reason Octane and mostly other render engines doesn't need that. When it's a bug or not that makes it unreasonably difficult the shading process.

Robert Brian commented

2019-04-14 10:05:17 +02:00

Added subscriber: @obertbrian

Brecht Van Lommel commented

2019-04-14 13:41:30 +02:00

Added subscriber: @brecht

Brecht Van Lommel commented

2019-04-14 13:41:30 +02:00

Please mention Blender version, attach a .blend and provide exact steps to redo.

Also check if any add-ons you have enabled affect on this.

Please mention Blender version, attach a .blend and provide exact steps to redo. Also check if any add-ons you have enabled affect on this.

Robert Brian commented

2019-04-14 19:38:36 +02:00

If I change any of the values for the material, then Cycles always recalculates the Importance Map.

There is no enabled addons.

Note: the HDRI included the sample is part of a free pack from Maxime Roz.

cycles_gpu_mip.blend

If I change any of the values for the material, then Cycles always recalculates the Importance Map. There is no enabled addons. Note: the HDRI included the sample is part of a free pack from Maxime Roz. [cycles_gpu_mip.blend](https://archive.blender.org/developer/F6944856/cycles_gpu_mip.blend)

Sebastian Parborg commented

2019-04-25 17:04:08 +02:00

Added subscribers: @Jeroen-Bakker, @ZedDB

Sebastian Parborg commented

2019-04-25 17:04:08 +02:00

I can't render with a GPU so I can't reproduce this. @brecht, @Jeroen-Bakker are you able to reproduce?

Tautvydas Andrikys commented

2019-04-26 21:55:15 +02:00

Added subscriber: @esminis

Tautvydas Andrikys commented

2019-04-26 21:55:15 +02:00

In #63588#660571, @obertbrian wrote:
If I change any of the values for the material, then Cycles always recalculates the Importance Map.

There is no enabled addons.

Note: the HDRI included the sample is part of a free pack from Maxime Roz.

cycles_gpu_mip.blend

I think you should see message "Updating lights" or "Updating Lights | Importance map".

If I understand well it should happen even without GPU rendering (it is independent of rendering device), essentially any time you modify environment HDRI image, material, ... lights are updated and during lights update importance map is regenerated. Need to explore code a bit more but I think only solution would be cache importance map in some cases (not sure it is worth).

In code this is happening in:

void LightManager::device_update_background(Device *device,
                                            DeviceScene *dscene,
                                            Scene *scene,
                                            Progress &progress)
{
  // ...
  progress.set_status("Updating Lights", "Importance map");
  // ...
}

> In #63588#660571, @obertbrian wrote: > If I change any of the values for the material, then Cycles always recalculates the Importance Map. > > There is no enabled addons. > > Note: the HDRI included the sample is part of a free pack from Maxime Roz. > > [cycles_gpu_mip.blend](https://archive.blender.org/developer/F6944856/cycles_gpu_mip.blend) I think you should see message "Updating lights" or "Updating Lights | Importance map". If I understand well it should happen even without GPU rendering (it is independent of rendering device), essentially any time you modify environment HDRI image, material, ... lights are updated and during lights update importance map is regenerated. Need to explore code a bit more but I think only solution would be cache importance map in some cases (not sure it is worth). In code this is happening in: ``` void LightManager::device_update_background(Device *device, DeviceScene *dscene, Scene *scene, Progress &progress) { // ... progress.set_status("Updating Lights", "Importance map"); // ... } ```

Tautvydas Andrikys commented

2019-04-27 19:57:06 +02:00

Just an update - yes importance map recalculations is not needed every time material, light, ... is changed, it is only needed when background or it`s resolution is changed in any way.

If importance map is regenerated only when it is really needed whole experience is much more fluid in such cases, as regeneration takes quite some time.

Solution would be to somehow track when background is changed then mark multiple importance map for regeneration (for now not sure how easy it is to track if background was changed).

Quick workaround for users would be to decrease environment map resolution while editing, as smaller resolution of environment map makes smaller resolution of importance map.

Just an update - yes importance map recalculations is not needed every time material, light, ... is changed, it is only needed when background or it`s resolution is changed in any way. If importance map is regenerated only when it is really needed whole experience is much more fluid in such cases, as regeneration takes quite some time. Solution would be to somehow track when background is changed then mark multiple importance map for regeneration (for now not sure how easy it is to track if background was changed). Quick workaround for users would be to decrease environment map resolution while editing, as smaller resolution of environment map makes smaller resolution of importance map.

Robert Brian commented

2019-04-29 21:16:59 +02:00

In #63588#667058, @esminis wrote:
Just an update - yes importance map recalculations is not needed every time material, light, ... is changed, it is only needed when background or it`s resolution is changed in any way.

If importance map is regenerated only when it is really needed whole experience is much more fluid in such cases, as regeneration takes quite some time.

Solution would be to somehow track when background is changed then mark multiple importance map for regeneration (for now not sure how easy it is to track if background was changed).

Quick workaround for users would be to decrease environment map resolution while editing, as smaller resolution of environment map makes smaller resolution of importance map.

Thank you for your time! As you said the whole experience would be very fluid (especially in the render preview) if there was a way not to be updated at every time when the background isn't changed. I have an i7-4790 cpu and even with smaller resolution of importance map need noticeable time to calculate. And the drawback of the small resolution is noise.

Even an experimental button would be fantastic to turn off the constant reloading.

> In #63588#667058, @esminis wrote: > Just an update - yes importance map recalculations is not needed every time material, light, ... is changed, it is only needed when background or it`s resolution is changed in any way. > > If importance map is regenerated only when it is really needed whole experience is much more fluid in such cases, as regeneration takes quite some time. > > Solution would be to somehow track when background is changed then mark multiple importance map for regeneration (for now not sure how easy it is to track if background was changed). > > Quick workaround for users would be to decrease environment map resolution while editing, as smaller resolution of environment map makes smaller resolution of importance map. Thank you for your time! As you said the whole experience would be very fluid (especially in the render preview) if there was a way not to be updated at every time when the background isn't changed. I have an i7-4790 cpu and even with smaller resolution of importance map need noticeable time to calculate. And the drawback of the small resolution is noise. Even an experimental button would be fantastic to turn off the constant reloading.

Brecht Van Lommel was assigned by Sebastian Parborg

2019-04-30 10:13:17 +02:00

Tautvydas Andrikys commented

2019-04-30 21:49:15 +02:00

I have created patch with fix, but need someone to review it in case I have missed something (as I am not so very familiar with Blender code base), parent commit from master branch 22cc69ace8d441750856816453d5a1c16e53f2bf:

#63588-Cycles-does-need-recalculate-MIP-after-modify.patch

I have created patch with fix, but need someone to review it in case I have missed something (as I am not so very familiar with Blender code base), parent commit from master branch 22cc69ace8d441750856816453d5a1c16e53f2bf: [#63588-Cycles-does-need-recalculate-MIP-after-modify.patch](https://archive.blender.org/developer/F6996132/T63588-Cycles-does-need-recalculate-MIP-after-modify.patch)

Robert Brian commented

2019-05-01 22:16:32 +02:00

In #63588#668946, @esminis wrote:
I have created patch with fix, but need someone to review it in case I have missed something (as I am not so very familiar with Blender code base), parent commit from master branch 22cc69ace8d441750856816453d5a1c16e53f2bf:

#63588-Cycles-does-need-recalculate-MIP-after-modify.patch

Thank you very much for your work!

I hope it will be included in both Blender version soon.

> In #63588#668946, @esminis wrote: > I have created patch with fix, but need someone to review it in case I have missed something (as I am not so very familiar with Blender code base), parent commit from master branch 22cc69ace8d441750856816453d5a1c16e53f2bf: > > [#63588-Cycles-does-need-recalculate-MIP-after-modify.patch](https://archive.blender.org/developer/F6996132/T63588-Cycles-does-need-recalculate-MIP-after-modify.patch) Thank you very much for your work! I hope it will be included in both Blender version soon.

Brecht Van Lommel was unassigned by Dalai Felinto

2019-12-23 16:34:39 +01:00

Brendon Murphy commented

2020-01-10 01:34:44 +01:00

Added subscriber: @BrendonMurphy