Denoiser 'noisy image' does not contain all not-denoised data #63608

Closed
opened 2019-04-15 00:08:35 +02:00 by Acrivec Cevirca · 6 comments

System Information
Operating system: W10
Graphics card: 980Ti

Blender Version
Broken: 19-04-13 18:58
Worked: (optional) I think it was working in 2.79 and in some of 2.80 builds

Short description of error
We can turn on/off light sources in denoiser. If we get glitches in direct glossy - we can turn it off and denoiser will make everything, leaving the direct glossy alone.
We can check 'Noisy image' for the actual image after rendering that was not denoised.
However, in this build when I unchecked glossy - I've got holes in 'noisy image'.

Exact steps for others to reproduce the error

  1. Turn off glossy denoising
  2. Render.
  3. Combined image looks well - however, 'noisy image' has an effect of 'holdout' on all places where glossy was present and was dominating.
    See pictures.

Denoiser settings:
OTpKBKW- [x].png

'Noisy image' layer
XF2udpe- [x].png
Glossy indirect layer:
P8hmz7x- [x].png
Gloss direct:
2sMeEEw- [x].png
Combined image:
BX8gOY1- [x].png

'Noisy image' should contain all data before denoising, including excluded layers. Denoiser should just ignore them when denoising image.

**System Information** Operating system: W10 Graphics card: 980Ti **Blender Version** Broken: 19-04-13 18:58 Worked: (optional) I think it was working in 2.79 and in some of 2.80 builds **Short description of error** We can turn on/off light sources in denoiser. If we get glitches in direct glossy - we can turn it off and denoiser will make everything, leaving the direct glossy alone. We can check 'Noisy image' for the actual image after rendering that was not denoised. However, in this build when I unchecked glossy - I've got holes in 'noisy image'. **Exact steps for others to reproduce the error** 1. Turn off glossy denoising 2. Render. 3. Combined image looks well - however, 'noisy image' has an effect of 'holdout' on all places where glossy was present and was dominating. See pictures. Denoiser settings: ![OTpKBKW- [x].png](https://archive.blender.org/developer/F6945735/OTpKBKW_1_.png) 'Noisy image' layer ![XF2udpe- [x].png](https://archive.blender.org/developer/F6945739/XF2udpe_1_.png) Glossy indirect layer: ![P8hmz7x- [x].png](https://archive.blender.org/developer/F6945742/P8hmz7x_1_.png) Gloss direct: ![2sMeEEw- [x].png](https://archive.blender.org/developer/F6945744/2sMeEEw_1_.png) Combined image: ![BX8gOY1- [x].png](https://archive.blender.org/developer/F6945747/BX8gOY1_1_.png) 'Noisy image' should contain all data before denoising, including excluded layers. Denoiser should just ignore them when denoising image.

Added subscriber: @Acrivec

Added subscriber: @Acrivec

Added subscriber: @brecht

Added subscriber: @brecht

Changed status from 'Open' to: 'Archived'

Changed status from 'Open' to: 'Archived'
Brecht Van Lommel self-assigned this 2019-04-15 20:35:34 +02:00

While this may be a useful improvement, this is not considered a bug. The denoising passes only contain the selected components.

While this may be a useful improvement, this is not considered a bug. The denoising passes only contain the selected components.

@brecht so what's the point of 'noisy image' for now? We either can render denoised image, or without denoiser. If I render something for 9 hours and denoiser will throw me out a glitch I can't get the before-denoising image and do anything with that. All the time is wasted...

@brecht so what's the point of 'noisy image' for now? We either can render denoised image, or without denoiser. If I render something for 9 hours and denoiser will throw me out a glitch I can't get the before-denoising image and do anything with that. All the time is wasted...

Normally you would denoise all the components, together not a subset of them. So then this works fine.

Denoising individual components is not currently supported, though you can save those components as separate render passes if you want to recombine them with the denoised image yourself.

Normally you would denoise all the components, together not a subset of them. So then this works fine. Denoising individual components is not currently supported, though you can save those components as separate render passes if you want to recombine them with the denoised image yourself.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#63608
No description provided.