Placing keyframe outside of NLA Strip frame range while in Tweak Mode no longer possible #63675

New Issue

Bun ny · 2019-04-17T07:10:09+02:00

Bun ny commented

2019-04-17 07:10:09 +02:00

Update: The crash described below has already been fixed, but the fix blocks previously working functionality.

System Information
Operating system: Windows 7 x64
Graphics card: NVIDIA GeForce GTX 580

Blender Version
Broken: 2.80 e2102e9917
Worked: 2.79

Placing a keyframe outside of the range of an NLA Strip while in Tweak Mode crashes Blender entirely. System console reports: "Attempt to free NULL pointer"

Exact steps for others to reproduce the error
Open attached .blend, enter Tweak Mode on the NLA strip, move to a frame outside the NLA strip's frame range, translate the Cube and insert a keyframe.

tweak_bug.blend

Another mutation of this issue has been reported in #75804

In #75804#911738, @Rosalie wrote:
An other odd behavior is that if one of the end key frames are moved to lengthen the animation, you will also get the error if you try to add an animation in what used to be out of the range of the animation before you started editing. If you stop editing the stashed animation and start again, you will be able to add frames now.

Exact steps for others to reproduce the error
1- Default Startup.
2- Select Cube, create new Action and add keys at 0 and 10 frame in position, rotation or scale.
3- Go to the NLA editor, add the New Action to the NLATrack
4- Click the ActionClip and right click (or shift-tab) "Start editing stashed action".
5- In the Dope Sheet, Graph or Action editor, Move the keyframe that is at frame 10 to frame 20
6- Add key frame after frame 15 using Insert Key frame shortcut (i).

The expected behavior is that I should be able to add a key frame anywhere on my timeline without having to get out of Editing Stashed Action mode.

**Update**: The crash described below has already been fixed, but the fix blocks previously working functionality. **System Information** Operating system: Windows 7 x64 Graphics card: NVIDIA GeForce GTX 580 **Blender Version** Broken: 2.80 e2102e991764 Worked: 2.79 Placing a keyframe outside of the range of an NLA Strip while in Tweak Mode crashes Blender entirely. System console reports: "Attempt to free NULL pointer" **Exact steps for others to reproduce the error** Open attached .blend, enter Tweak Mode on the NLA strip, move to a frame outside the NLA strip's frame range, translate the Cube and insert a keyframe. [tweak_bug.blend](https://archive.blender.org/developer/F6953473/tweak_bug.blend) Another mutation of this issue has been reported in #75804 > In #75804#911738, @Rosalie wrote: > An other odd behavior is that if one of the end key frames are moved to lengthen the animation, you will also get the error if you try to add an animation in what used to be out of the range of the animation before you started editing. If you stop editing the stashed animation and start again, you will be able to add frames now. > > **Exact steps for others to reproduce the error** > 1- Default Startup. > 2- Select Cube, create new Action and add keys at 0 and 10 frame in position, rotation or scale. > 3- Go to the NLA editor, add the New Action to the NLATrack > 4- Click the ActionClip and right click (or shift-tab) "Start editing stashed action". > 5- In the Dope Sheet, Graph or Action editor, Move the keyframe that is at frame 10 to frame 20 > 6- Add key frame after frame 15 using Insert Key frame shortcut (i). > > The expected behavior is that I should be able to add a key frame anywhere on my timeline without having to get out of Editing Stashed Action mode.

Bun ny commented

2019-04-17 07:10:09 +02:00

Added subscriber: @bunny

blender-admin commented

2019-04-17 07:10:09 +02:00

#75804 was marked as duplicate of this issue

blender-admin commented

2019-04-17 07:10:09 +02:00

#68158 was marked as duplicate of this issue

Sebastian Parborg commented

2019-04-17 16:04:29 +02:00

Added subscribers: @LazyDodo, @ZedDB

Sebastian Parborg commented

2019-04-17 16:04:29 +02:00

Can't reproduce this on my end. Even with ASAN, I do not get any errors when following the reproduction steps.

@LazyDodo can you reproduce this?

Can't reproduce this on my end. Even with ASAN, I do not get any errors when following the reproduction steps. @LazyDodo can you reproduce this?

Philipp Oeser commented

2019-04-30 13:11:56 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2019-04-30 13:11:56 +02:00

Asserts for me:

Attempt to free NULL pointer

1  raise                                                 0x7ffff0aa853f 
2  abort                                                 0x7ffff0a92895 
3  MEM_lockfree_freeN       mallocn_lockfree_impl.c 128  0x1dbbba4      
4  insert_keyframe          keyframing.c            1516 0x256babc      
5  ANIM_apply_keyingset     keyingsets.c            1127 0x257049a      
6  insert_key_exec          keyframing.c            1838 0x256c2bc      
7  insert_key_menu_invoke   keyframing.c            1972 0x256c6f2

checking further...

Asserts for me: `Attempt to free NULL pointer` ``` 1 raise 0x7ffff0aa853f 2 abort 0x7ffff0a92895 3 MEM_lockfree_freeN mallocn_lockfree_impl.c 128 0x1dbbba4 4 insert_keyframe keyframing.c 1516 0x256babc 5 ANIM_apply_keyingset keyingsets.c 1127 0x257049a 6 insert_key_exec keyframing.c 1838 0x256c2bc 7 insert_key_menu_invoke keyframing.c 1972 0x256c6f2 ``` checking further...

Philipp Oeser commented

2019-09-11 01:22:02 +02:00

Added subscriber: @Angeloss

Sybren A. Stüvel commented

2019-10-17 14:27:09 +02:00

Added subscriber: @dr.sybren

Sybren A. Stüvel commented

2019-10-17 14:27:09 +02:00

I can't reproduce this either, on Linux or on Windows 10. Blender just tells me "Warning: Keying set failed to insert any keyframes" and that's it.

Bun ny commented

2019-10-20 21:40:47 +02:00

Sometime since submitting this bug report the behavior @dr.sybren mentions was added, which doesn't insert any keyframes and displays a warning. However, with this "fix," the useful functionality of 2.79 and previous, where the user could insert a keyframe beyond the strip range during tweak mode, is lost. This was especially useful for animation layering, which is a lot more doable in 2.8 and could make good use of the prior functionality.

Sybren A. Stüvel changed title from ~~Placing keyframe outside of NLA Strip frame range while in Tweak Mode crashes Blender~~ to Placing keyframe outside of NLA Strip frame range while in Tweak Mode no longer possible

2019-12-13 14:45:22 +01:00

Sybren A. Stüvel commented

2019-12-13 14:46:08 +01:00

I've marked this task as a To Do, as the originally described bug has already been fixed, but I do want to keep this around as a good idea to implement at some point.

Philipp Oeser commented

2020-04-17 12:36:52 +02:00

Added subscriber: @Rosalie

blender-admin commented

2020-08-20 16:52:08 +02:00

This issue was referenced by 89ee260ef2

This issue was referenced by 89ee260ef22e27c9064dad54331c4c595f23b7e5

Sybren A. Stüvel commented

2020-08-20 17:28:05 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Sybren A. Stüvel closed this issue

2020-08-20 17:28:05 +02:00

Sybren A. Stüvel self-assigned this 2020-08-20 17:28:05 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Placing keyframe outside of NLA Strip frame range while in Tweak Mode no longer possible #63675