Page MenuHome

Make Delete in the File Browser use the system Trash
Open, Confirmed, LowPublic

Description

Related to bug report T61412.

Deleting in the File Browser is currently a highly dangerous and destructive action.

Rather than hard deleting, we should use the correct API's to move items to the system trash in the various OS's we support.

If this is not easily possible, we should disable deleting inside the File Browser for those platforms in the meantime. It's currently too easy to permanently lose large chunks of user hard drive contents with no remedy to get it back, which is not acceptable.

Details

Type
To Do

Event Timeline

William Reynish (billreynish) lowered the priority of this task from Needs Triage by Developer to Confirmed, High.May 3 2019, 1:51 PM

To me this issue seems so egregious that we should not ship without this being addressed.

If it's too much of a hassle to add this for all platforms, we could start by simply disabling the ability to delete data from the File Browser, until we can do it in a way that doesn't make it easy to accidentally permanently erase your entire hard drive.

William Reynish (billreynish) lowered the priority of this task from Confirmed, High to Confirmed, Low.May 15 2019, 1:47 PM

Main dangerous issue is now addressed. Adding support for system trash is still a useful task though, for later.

TBH, I would not even bother adding that back (I thought that had been removed already, when the 'delete' button was removed from the header)… Blender is not exactly a filebrowser, being able to add directories is handy, but imho that’s enough.

File (asset) deletion should rather be handled by asset engines, in a secure/specific way matching each asset engine's pipeline, but we should not try to support all OS filesystem features, really.

@Bastien Montagne (mont29) yes it’s a low priority item I agree. I could even remove this task completely, and it’s not even so much UI-related.

Could be nice to eventually add this in a better way but I also don’t think it’s a big deal if we don’t.

@Bastien Montagne (mont29) @William Reynish (billreynish) Sorry I've been sick and couldn't work on the patch D4585. This may have to wait some more until I have an empty backlog.