Performance: EditMesh to Mesh on every modifier run #64262

Open
opened 2019-05-07 18:13:18 +02:00 by Sergey Sharybin · 1 comment

This is a part of performance regression investigation task.

Every movement of vertex will request modifier stack to be re-run. This involves conversion of EditMesh to Mesh, no matter whether there are modifiers or not.

Since 84cf670d1d it seems that we can simply delay creation of mesh_cage in editbmesh_calc_modifiers and only do it if there is actual modifier which is to be applied. We can then have runtime.is_original set to truth for all Mesh IDs which are covered by Copy-on-Write, and set it to false when modifier runs.

This will solve about 50% of slowdown in the attached file (where EditMesh to Mesh takes almost same amount of time as batch cache creation).

megaheavy_mesh_edit.blend

This is a part of performance regression investigation task. Every movement of vertex will request modifier stack to be re-run. This involves conversion of EditMesh to Mesh, no matter whether there are modifiers or not. Since 84cf670d1d it seems that we can simply delay creation of `mesh_cage` in `editbmesh_calc_modifiers` and only do it if there is actual modifier which is to be applied. We can then have `runtime.is_original` set to truth for all Mesh IDs which are covered by Copy-on-Write, and set it to false when modifier runs. This will solve about 50% of slowdown in the attached file (where EditMesh to Mesh takes almost same amount of time as batch cache creation). [megaheavy_mesh_edit.blend](https://archive.blender.org/developer/F7012934/megaheavy_mesh_edit.blend)
Author
Owner

Added subscriber: @Sergey

Added subscriber: @Sergey
Sergey Sharybin changed title from Performance: EditMesh to Mesh on eevry modifier run to Performance: EditMesh to Mesh on every modifier run 2019-05-08 10:33:15 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#64262
No description provided.