Unparenting after transforming in an operator fails to update the depsgraph when using Redo Last #64300

New Issue

MACHIN3 · 2019-05-08T10:32:28+02:00

MACHIN3 commented

2019-05-08 10:32:28 +02:00

System Information
Operating system: Linux-4.13.10-041310-generic-x86_64-with-debian-stretch-sid 64 Bits
Graphics card: GeForce GTX 1050/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 390.67

Blender Version
Broken: version: 2.80 (sub 60), branch: blender2.7, commit date: 2019-05-07 19:17, hash: 3dc9da3a74
Worked: 2.79

Short description of error
I have a plane and a cube being parented to it. I have an operator, that rotates the plane utilizing Redo Last, to tweak the amount.
After the rotation, the operator unparents the cube.
The expected behavior would be that the cube is rotated with the plane(as it is parented to it), and is unparented only at the end, after the rotation. This works fine in 2.79, as long as a scene.update() is done in between the rotation and the unparenting.
In 2.80 however the rotation(and likey any other transformation) of the plane doesn't carry through to the cube, if you use Redo Last.
There is a video demo , so you can better vizualize what I'm talking about.

Exact steps for others to reproduce the error

open unparent_after_parent_rotation279.blend in Blender 2.79
- notice how the cube is parented to the plane
- run the script to register the Rotator operator and run the op in the 3d view
- bring up the Redo Last panel to change the amount of the rotation
- notice how the cube is rotated with the plane, but is unparented at the end
- comment out the scene.update() to break the op
  - without the scene.update(), the depsgraph(?) doesn't know about the rotation when unparented, this is expected
open unparent_after_parent_rotation.blend in Blender 2.80
- notice again that the cube is parented to the plane
- run the script to register the Rotator operator and run the op in the 3d view
- bring up the Redo Last panel to change the amount of the rotation
- notice how the cube is NOT ROTATED with the plane this time, DESPITE the scene.update()
  - it still is unparented but it looks like at the time of the unparenting, the depsgraph is not aware of the transformation done previously
- reset the scene and change the default value of self.degrees
  - notice how the op works fine on its initial run, but as soon as you use Redo Last it breaks

I think this is one for @sergey.

**System Information** Operating system: Linux-4.13.10-041310-generic-x86_64-with-debian-stretch-sid 64 Bits Graphics card: GeForce GTX 1050/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 390.67 **Blender Version** Broken: version: 2.80 (sub 60), branch: blender2.7, commit date: 2019-05-07 19:17, hash: `3dc9da3a74` Worked: 2.79 **Short description of error** I have a plane and a cube being parented to it. I have an operator, that rotates the plane utilizing *Redo Last*, to tweak the amount. After the rotation, the operator unparents the cube. The expected behavior would be that the cube is rotated with the plane(as it is parented to it), and is unparented only at the end, after the rotation. This works fine in 2.79, as long as a scene.update() is done in between the rotation and the unparenting. In 2.80 however the rotation(and likey any other transformation) of the plane doesn't carry through to the cube, if you use *Redo Last*. There is [a video demo ](https://www.youtube.com/watch?v=Gkw0UFPUGUw), so you can better vizualize what I'm talking about. **Exact steps for others to reproduce the error** * open [unparent_after_parent_rotation279.blend](https://archive.blender.org/developer/F7014815/unparent_after_parent_rotation279.blend) in Blender 2.79 * notice how the cube is parented to the plane * run the script to register the Rotator operator and run the op in the 3d view * bring up the *Redo Last* panel to change the amount of the rotation * notice how the cube is rotated with the plane, but is unparented at the end * comment out the scene.update() to break the op * without the scene.update(), the depsgraph(?) doesn't know about the rotation when unparented, this is expected * open [unparent_after_parent_rotation.blend](https://archive.blender.org/developer/F7014820/unparent_after_parent_rotation.blend) in Blender 2.80 * notice again that the cube is parented to the plane * run the script to register the Rotator operator and run the op in the 3d view * bring up the *Redo Last* panel to change the amount of the rotation * notice how the cube is NOT ROTATED with the plane this time, DESPITE the scene.update() * it still is unparented but it looks like at the time of the unparenting, the depsgraph is not aware of the transformation done previously * reset the scene and change the default value of self.degrees * notice how the op works fine on its initial run, but as soon as you use *Redo Last* it breaks I think this is one for @sergey.

MACHIN3 commented

2019-05-08 10:32:28 +02:00

Added subscribers: @Sergey, @MACHIN3

MACHIN3 commented

2019-05-08 12:00:50 +02:00

FWIW, if you rotate an object and then parent it, you will have the same problem. The object won't be parented in it's new rotated orientation, as you'd expect.

Campbell Barton was assigned by Sebastian Parborg

2019-05-08 14:47:54 +02:00

Sebastian Parborg commented

2019-05-09 10:38:02 +02:00

Added subscriber: @ZedDB

Sebastian Parborg commented

2019-05-09 10:38:02 +02:00

I just note that this might be a duplicate of #64307 but I'll not merged them as I am quite uncertain.

MACHIN3 commented

2019-05-17 18:33:43 +02:00

The issues persists, even after the recent depsgraph changes.
I have update the blend: unparent_after_parent_rotation_depsgraph.blend

@Sergey

The issues persists, even after the recent depsgraph changes. I have update the blend: [unparent_after_parent_rotation_depsgraph.blend](https://archive.blender.org/developer/F7043708/unparent_after_parent_rotation_depsgraph.blend) @Sergey

Campbell Barton was unassigned by Sergey Sharybin

2019-05-17 18:41:36 +02:00

Sergey Sharybin self-assigned this 2019-05-17 18:41:36 +02:00

Sergey Sharybin commented

2019-05-17 18:41:36 +02:00

Added subscriber: @ideasman42

Sergey Sharybin commented

2019-05-17 18:41:36 +02:00

@MACHIN3 thanks for the updated file!

Re-assigning to me, think it's nothing to do with Campbell.

@MACHIN3 thanks for the updated file! Re-assigning to me, think it's nothing to do with Campbell.

blender-admin commented

2019-05-17 18:59:29 +02:00

This issue was referenced by be5fd9c09f

This issue was referenced by be5fd9c09f2539b9268f422252d9a1d01bc1769c

Sergey Sharybin commented

2019-05-17 19:01:29 +02:00

Changed status from 'Open' to: 'Resolved'

Sergey Sharybin closed this issue

2019-05-17 19:01:29 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Unparenting after transforming in an operator fails to update the depsgraph when using Redo Last #64300