Drag in empty space to box select does not work in animation editors #64565
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
8 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#64565
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
System Information
Operating system: Ubuntu 18.10
Graphics card: Radeon RX 560 Series (POLARIS11, DRM 3.31.0, 4.18.0-18-generic, LLVM 7.0.0)example_vse_cache_invalidated.webm
Blender Version
Broken: 2.80,
ebc44aae98
, master, 2018-05-11Short description of error
Cached frames become invalidated as soon as another video strip is selected.
Exact steps for others to reproduce the error
Add two video strips, one above the other. Select one of them and play, to get some frames cached. Then select the other strip and parts of the cache becomes invalidated.
Added subscriber: @JosefR
#65063 was marked as duplicate of this issue
#64961 was marked as duplicate of this issue
Added subscriber: @WilliamReynish
I was about to create this task.
@WilliamReynish is it OK to change sequence move operator to LMB + tweak?
Minor issue also is, when you box select strips and try to move them by mouse - only the one you move will be moved, because others will be deselected
@iss
Afaik that won't work, as tweak is used to box select. Ideally this could work so that if you tweak ON a clip, it moves, but if you tweak outside, it box selects. But the keymap cannot currently make this distinction in that way.
Yes, this is a known issue. It was just solved for the Node editor. This should become generic so we can use it in places like this too.
As for the cache, I guess it really should not be discarded if the clip was never actually moved?
Technically this would solve this, but often I actually move it, then it returns back to position, because it can not move.
Ok so I will do ideally both checks and run invalidation accordingly.
@WilliamReynish
Haven't got too far with this today, but I have noticed, that when you have effects applied on top of a strip, move operator will select whole chain.
This makes it hard to actually select a strip in such case.
So again I would rather make distinction at what I am pointing to when doing LMB+tweak and decide between box select / move.
Not quite sure how exactly I would do this though.
You should be able to check the Node editor which I think does it.
@WilliamReynish
Ok found it #63994 (Node Editor: Move All Selected Nodes when dragging)
To sum up / confirm behavior:
on click:
on click release:
on tweak:
is that correct?
Added subscriber: @mont29
I think that's correct - @mont29 coded this so should be able to confirm.
yes, that’s basically it. But I would advise you wait a bit here, going modal raised some annoying issue (#64660 and #64693 are actually same fundamental problem), that needs to be addressed before generalizing that approach.
Added subscriber: @snuq
Added subscriber: @WayneDixon
Selecting sequencer strips invlidates cacheto Drag in empty space to box select does not work in animation editorsAdded subscriber: @iss
Added subscriber: @brecht
I've reverted the commit that caused this in
244c39f1ab
. It was unusable for video editing and animation, we should first fix it and then enable the behavior again.As far as I know, this bug is not related to "Move All Selected Nodes when dragging" specifically. Even in Blender 2.7 could you box select from empty space in the node editor, without it causing issues like this.
The way this is handled in the node editor is like this:
I think the same fix could work in the sequencer and animation editors.
Added subscriber: @JacquesLucke
Implemented it for the sequencer using the approach Brecht mentioned:
8e125f278c
@JacquesLucke, regarding that commit:
244c39f1ab
, assuming they are compatible with this now.@JacquesLucke @brecht Now box select indeed works again, but should we also allow dragging multiple strips, just like we do for nodes? It seems like if we use the Node Editor method we could allow that too.
No, we should focus on stabilizing now, further improvements are for 2.81.
Thx guys for help here!
Do you want to do that or should this be closed?
If I understand this correctly,
marker.select
operator would have to be defined in sequencer region. But thenED_markers_find_nearest_marker
will always return marker if markers are used, which would prevent box select from working, so that would have to be modifiedWe still have to bring box selection for graph/dopesheet/NLA editors as well, they have the same issue.
For markers, what I meant is that
sequencer_box_select_invoke
should also check if the mouse is over any markers before allowing box select to start, to be sure it's really over empty space.Added subscriber: @AbidMaqbool
AFAIK markers are selected in their own area by own operator, so
sequencer_box_select_invoke
shouldn't have to do such check.Changed status from 'Open' to: 'Resolved'
b79976a9bd
,8b1ca3ec53
,04bac38731
,ab5219af34
,8e125f278c