Use aliased names for file versioning checks #64791
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#64791
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
System Information
Operating system: Linux-5.0.13-arch1-1-ARCH-x86_64-with-arch 64 Bits
Graphics card: GeForce GTX 1080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 418.74
Blender Version
Broken: version: 2.80 (sub 69), branch: blender2.7, commit date: 2019-05-17 21:54, hash:
3b8ae2c08fWorked: (optional)
Short description of error
The new angle setting of the Sun light type is not saved with the blend file. It always defaults back to 11.4°.
Exact steps for others to reproduce the error
Added subscriber: @MichaelHermann
Added subscribers: @ideasman42, @brecht
@ideasman42,
DNA_struct_elem_findas used in versioning seems to need "Lamp" rather than "Light". Can we change that? There's other old Light versioning code that assumes this.This issue was referenced by
8a5effe967Changed status from 'Open' to: 'Resolved'
Change of Sun Angle is not saved.to File versioning not working in some cases due to name aliasingChanged status from 'Resolved' to: 'Open'
Changed status from 'Open' to: 'Resolved'
Added function calls for aliased name lookups
73f7ed7ffaWe still need to make use of these in versioning code though so new code that's added doesn't trip up on the same issue.
Changed status from 'Resolved' to: 'Open'
File versioning not working in some cases due to name aliasingto Use aliased names for file versioning checksSet as TODO since the internal API's to do aliased checks are done and there is no need to make this change for 2.80 release.
Added subscriber: @dfelinto
Setting as a 2.81 target, I think this is one of these exceptions where we can do after Bcon1. And if no one does it I can work on it, it seems rather straightforward.
@ideasman42 can we be more specific of what is expected here? Because the original reported bug is fixed. So it is not clear to me what is left to be done.
This is marked with the 2.82 milestone. If no fix is planned for that release, please move it to 2.83 or untag it from a specific milestone.
@ideasman42 I can still put some hours on it, if I hear from you before 2.83 (unttaged from 2.82 indeed)
I changed the versioning names back to Lamp, that committed will need to be reverted when this is fixed.
Resolved as part of
3f8443ed6b,c5b53dcab4,e7ced9f595&fc6a0e9bd3.