"Batch-Generate Previews" crashes #64827

New Issue

Grayson Riffe · 2019-05-19T06:30:54+02:00

Grayson Riffe commented

2019-05-19 06:30:54 +02:00

Operating system: Windows 10 Home x64
Graphics card: GTX 970M

Blender Version
Broken: 2.80.69, 06c4139a68 (2019-5-19)

Short description of error
The operator to batch generate previews is broken. It ends up with a console window with the error, but it can't be closed and the ui window is completely normal. It also says "Blender quit."

Exact steps for others to reproduce the error

Save the default file.
File -> Data Previews -> Batch-Generate Previews -> point to the newly-saved file.
The console comes up.

Operating system: Windows 10 Home x64 Graphics card: GTX 970M **Blender Version** Broken: 2.80.69, 06c4139a6833 (2019-5-19) **Short description of error** The operator to batch generate previews is broken. It ends up with a console window with the error, but it can't be closed and the ui window is completely normal. It also says "Blender quit." **Exact steps for others to reproduce the error** 1. Save the default file. 2. File -> Data Previews -> Batch-Generate Previews -> point to the newly-saved file. 3. The console comes up. ![screenshot.png](https://archive.blender.org/developer/F7046667/screenshot.png)

Grayson Riffe commented

2019-05-19 06:30:54 +02:00

Added subscriber: @MrGrapeDave

Philipp Oeser commented

2019-05-19 17:48:19 +02:00

Added subscriber: @lichtwerk

Philipp Oeser self-assigned this 2019-05-19 17:48:19 +02:00

Philipp Oeser commented

2019-05-19 17:48:19 +02:00

Yep, this was left out from 77f92b8cb7. (still wanted to check something).

Yep, this was left out from 77f92b8cb7. (still wanted to check something).

blender-admin commented

2019-06-04 14:11:55 +02:00

This issue was referenced by 1d2e4c44bd

This issue was referenced by 1d2e4c44bddeb21e04f6ef73b96b51a759a3352e

Bastien Montagne commented

2019-06-04 14:40:48 +02:00

Changed status from 'Open' to: 'Resolved'

Bastien Montagne closed this issue

2019-06-04 14:40:48 +02:00

Grayson Riffe commented

2019-07-13 02:49:54 +02:00

Changed status from 'Resolved' to: 'Open'

Grayson Riffe reopened this issue

2019-07-13 02:49:54 +02:00

Grayson Riffe commented

2019-07-13 02:49:55 +02:00

(Version: 2.8 Release Candidate 1)
This issue is still present in the form of either another command prompt message, or it doesn't say anything and no previews are generated when viewing them when appending.

(Version: 2.8 Release Candidate 1) This issue is still present in the form of either another command prompt message, or it doesn't say anything and no previews are generated when viewing them when appending. ![previews.png](https://archive.blender.org/developer/F7604394/previews.png)

Grayson Riffe commented

2019-07-13 02:51:30 +02:00

Some files, like the default one, shows this message and writes the previews, but most don't write when that comes up.

Philipp Oeser commented

2019-07-14 21:54:56 +02:00

I noticed a memleak in D4917 as well, this I will track down [this should not be the reason for not writing the previews though...and is probably not that high priority atm...].

However, I cannot reproduce the issue of "it doesn't say anything and no previews are generated when viewing them when appending":
I ran this on multiple files and the previews seem to show:

Could you provide a file where generating the previews fails?
Do you possibly get a message like *NOT* Saving someblendfile.blend, because some error(s) happened while deleting temp render data... (or any other ERROR message)?

I noticed a memleak in [D4917](https://archive.blender.org/developer/D4917) as well, this I will track down [this should not be the reason for not writing the previews though...and is probably not that high priority atm...]. However, I cannot reproduce the issue of "it doesn't say anything and no previews are generated when viewing them when appending": I ran this on multiple files and the previews seem to show: ![T64827_heating_objects.png](https://archive.blender.org/developer/F7608786/T64827_heating_objects.png) ![T64827_heating_collections.png](https://archive.blender.org/developer/F7608807/T64827_heating_collections.png) ![T64827_heating_materials.png](https://archive.blender.org/developer/F7608810/T64827_heating_materials.png) - Could you provide a file where generating the previews fails? - Do you possibly get a message like `*NOT* Saving someblendfile.blend, because some error(s) happened while deleting temp render data...` (or any other ERROR message)?

Grayson Riffe commented

2019-07-14 22:25:23 +02:00

That message is what I was talking about at the end of the second comment. Here is that message with wasp_bot.blend from 2.8's page on blender.org .

I also can't quite remember what I did to get it to fail and not say anything.

That message is what I was talking about at the end of the second comment. Here is that message with wasp_bot.blend from [2.8's page on blender.org ](https://www.blender.org/download/releases/2-80/). ![wasp_bot.png](https://archive.blender.org/developer/F7608865/wasp_bot.png) I also can't quite remember what I did to get it to fail and not say anything.

Philipp Oeser commented

2019-07-14 22:51:42 +02:00

OK, get it, too, (on the race_spaceship.blend) if I remove try/except, it fails here:

Traceback (most recent call last):
  File "/build_linux/bin/2.80/scripts/modules/bl_previews_utils/bl_previews_render.py", line 511, in <module>
    main()
  File "/build_linux/bin/2.80/scripts/modules/bl_previews_utils/bl_previews_render.py", line 502, in main
    do_data_intern=args.no_data_intern)
  File "/build_linux/bin/2.80/scripts/modules/bl_previews_utils/bl_previews_render.py", line 425, in do_previews
    if not render_context_delete(render_context):
  File "/build_linux/bin/2.80/scripts/modules/bl_previews_utils/bl_previews_render.py", line 167, in render_context_delete
    rna_backup_restore(scene, render_context.backup_scene)
  File "/build_linux/bin/2.80/scripts/modules/bl_previews_utils/bl_previews_render.py", line 68, in rna_backup_restore
    setattr(dt, path[-1], val)
TypeError: bpy_struct: item.attr = val: enum "" not found in ('ADAPTIVE')
Error: Not freed memory blocks: 2413, total unfreed memory 1.000534

Here it seems to be about UnitSettings.length_unit [this might be more general though and affect other properties which have changed?]
Checking further...

OK, get it, too, (on the `race_spaceship.blend`) if I remove `try`/`except`, it fails here: ``` Traceback (most recent call last): File "/build_linux/bin/2.80/scripts/modules/bl_previews_utils/bl_previews_render.py", line 511, in <module> main() File "/build_linux/bin/2.80/scripts/modules/bl_previews_utils/bl_previews_render.py", line 502, in main do_data_intern=args.no_data_intern) File "/build_linux/bin/2.80/scripts/modules/bl_previews_utils/bl_previews_render.py", line 425, in do_previews if not render_context_delete(render_context): File "/build_linux/bin/2.80/scripts/modules/bl_previews_utils/bl_previews_render.py", line 167, in render_context_delete rna_backup_restore(scene, render_context.backup_scene) File "/build_linux/bin/2.80/scripts/modules/bl_previews_utils/bl_previews_render.py", line 68, in rna_backup_restore setattr(dt, path[-1], val) TypeError: bpy_struct: item.attr = val: enum "" not found in ('ADAPTIVE') Error: Not freed memory blocks: 2413, total unfreed memory 1.000534 ``` Here it seems to be about `UnitSettings`.`length_unit` [this might be more general though and affect other properties which have changed?] Checking further...

blender-admin commented

2019-07-15 11:53:57 +02:00

This issue was referenced by 8a5a8282ce

This issue was referenced by 8a5a8282ce48704e60e70cb02d747aede71e70b8

Philipp Oeser commented

2019-07-15 12:05:14 +02:00

Added subscriber: @mont29

Philipp Oeser commented

2019-07-15 12:05:14 +02:00

I think this is due to settings with bad/missing do_versions code?
Those values are empty in the failing files and then this empty value refuses to be set (e.g. on an enum)

seems like this fails for (again, I've disabled try/exept in rna_backup_restore):

UnitSettings (length_unit, ...), introduced in 2d21eb79ad ERROR: bpy_struct: item.attr = val: enum "" not found in ('ADAPTIVE')
FFmpegSettings (ffmpeg_preset, ...), introduced in 7e39d151d8, fails with ERROR: bpy_struct: item.attr = val: enum "" not found in ('BEST', 'GOOD', 'REALTIME'), not sure about FFM_PRESET_NONE in code...

@mont29: do you have a quick solution to this? Just skip them in exclude_props (D5255)?

I think this is due to settings with bad/missing do_versions code? Those values are empty in the failing files and then this empty value refuses to be set (e.g. on an enum) seems like this fails for (again, I've disabled try/exept in `rna_backup_restore`): - `UnitSettings` (`length_unit`, ...), introduced in 2d21eb79ad ERROR: `bpy_struct: item.attr = val: enum "" not found in ('ADAPTIVE')` - `FFmpegSettings` (`ffmpeg_preset`, ...), introduced in 7e39d151d8, fails with `ERROR: bpy_struct: item.attr = val: enum "" not found in ('BEST', 'GOOD', 'REALTIME')`, not sure about FFM_PRESET_NONE in code... @mont29: do you have a quick solution to this? Just skip them in `exclude_props` ([D5255](https://archive.blender.org/developer/D5255))?

Philipp Oeser commented

2019-07-15 16:40:08 +02:00

Changed status from 'Open' to: 'Resolved'

Philipp Oeser closed this issue

2019-07-15 16:40:08 +02:00

Bastien Montagne commented

2019-07-15 17:54:05 +02:00

@MrGrapeDave next time please open a new task, that new issue you are reporting here has absolutely nothing in common with the original one (except for the fact that they affect the same end-user tool), having different issues in a single task is really not ideal to manage the tracker.

blender-admin commented

2019-07-15 18:25:25 +02:00

This issue was referenced by 125e0cfb25

This issue was referenced by 125e0cfb2533b2f2323a5b37e5c98652b1e2e24f

blender-admin commented

2019-07-15 22:29:59 +02:00

This issue was referenced by f3899c13cd

This issue was referenced by f3899c13cd458b116fe4fd646632d11b1c26fda3

Philipp Oeser was unassigned by Bastien Montagne

2019-07-15 22:35:18 +02:00

Bastien Montagne self-assigned this 2019-07-15 22:35:18 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

"Batch-Generate Previews" crashes #64827