Active point of Curve objects is not displayed correctly #64829

New Issue

Yevgeny Makarov · 2019-05-19T08:39:22+02:00

Yevgeny Makarov commented

2019-05-19 08:39:22 +02:00

System Information
Operating system: Darwin-18.2.0-x86_64-i386-64bit 64 Bits
Graphics card: AMD Radeon Pro 455 OpenGL Engine ATI Technologies Inc. 4.1 ATI-2.4.10

Blender Version
Broken: version: 2.80 (sub 69), branch: blender2.7, commit date: 2019-05-18 17:13, hash: 1fce0460d5

Short description of error
The active point of the Curve/Surface objects is not displayed correctly (not highlighted in white) after you change it.

Exact steps for others to reproduce the error

Create Curve or Surface object
In Edit Mode select some points, the active point is not displayed in white

**System Information** Operating system: Darwin-18.2.0-x86_64-i386-64bit 64 Bits Graphics card: AMD Radeon Pro 455 OpenGL Engine ATI Technologies Inc. 4.1 ATI-2.4.10 **Blender Version** Broken: version: 2.80 (sub 69), branch: blender2.7, commit date: 2019-05-18 17:13, hash: `1fce0460d5` **Short description of error** The active point of the Curve/Surface objects is not displayed correctly (not highlighted in white) after you change it. **Exact steps for others to reproduce the error** - Create Curve or Surface object - In Edit Mode select some points, the active point is not displayed in white

Yevgeny Makarov commented

2019-05-19 08:39:22 +02:00

Added subscriber: @jenkm

Marco commented

2019-05-19 16:43:40 +02:00

Added subscriber: @nacioss

Marco commented

2019-05-19 16:43:40 +02:00

Changed status from 'Open' to: 'Archived'

Marco closed this issue

2019-05-19 16:43:40 +02:00

Marco self-assigned this 2019-05-19 16:43:40 +02:00

Marco commented

2019-05-19 16:43:40 +02:00

It is displayed in green as it should be. They changed the color of active verts to be green.

It is displayed in green as it should be. They changed the color of active verts to be green. ![Screenshot.jpg](https://archive.blender.org/developer/F7048147/Screenshot.jpg)

Yevgeny Makarov commented

2019-05-19 17:04:05 +02:00

Changed status from 'Archived' to: 'Open'

Yevgeny Makarov reopened this issue

2019-05-19 17:04:05 +02:00

Yevgeny Makarov commented

2019-05-19 17:04:05 +02:00

@nacioss green it's just selected points, active one is white

Marco was unassigned by Philipp Oeser

2019-05-20 14:14:35 +02:00

Philipp Oeser commented

2019-05-20 14:48:45 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2019-05-20 14:48:45 +02:00

note: seems to update (to white) if you actually move the active point...

Philipp Oeser commented

2019-05-20 15:39:18 +02:00

In #64829#683257, @lichtwerk wrote:
note: seems to update (to white) if you actually move the active point...

...but not if you use the select tools [box, lasso, ...] ...

> In #64829#683257, @lichtwerk wrote: > note: seems to update (to white) if you actually move the active point... ...but not if you use the select tools [box, lasso, ...] ...

Campbell Barton was assigned by Philipp Oeser

2019-05-20 16:08:25 +02:00

Philipp Oeser commented

2019-05-20 16:08:25 +02:00

Added subscribers: @fclem, @ideasman42

Philipp Oeser commented

2019-05-20 16:08:25 +02:00

I followed this a bit, so DEG seems to be tagging correctly ID_RECALC_SELECT, BKE_curve_batch_cache_dirty_tag gets called...

Maybe @fclem or @ideasman42 (campbell: will assign to you first if OK?) know what's going on?

I followed this a bit, so DEG seems to be tagging correctly `ID_RECALC_SELECT`, `BKE_curve_batch_cache_dirty_tag` gets called... Maybe @fclem or @ideasman42 (campbell: will assign to you first if OK?) know what's going on?

Jacques Lucke commented

2019-05-23 15:40:43 +02:00

Added subscribers: @Sergey, @JacquesLucke

Jacques Lucke commented

2019-05-23 15:40:43 +02:00

@Sergey, the issues seems to be that when tagging the curve with ID_RECALC_SELECT, cu->actvert is not copied to the curve-copy in the depsgraph. Is there a place where this just has to be added?

@Sergey, the issues seems to be that when tagging the curve with `ID_RECALC_SELECT`, `cu->actvert` is not copied to the curve-copy in the depsgraph. Is there a place where this just has to be added?

Sergey Sharybin commented

2019-05-23 16:44:51 +02:00

@JacquesLucke, BKE_curve_copy_data() would be my first guess.

@JacquesLucke, `BKE_curve_copy_data()` would be my first guess.

Jacques Lucke commented

2019-05-23 17:15:23 +02:00

Thanks. Unfortunately, BKE_curve_copy_data is not called when ID_RECALC_SELECT is used in ED_curve_editnurb_select_pick. However, it is called when ID_RECALC_ALL is used.

Thanks. Unfortunately, `BKE_curve_copy_data` is not called when `ID_RECALC_SELECT` is used in `ED_curve_editnurb_select_pick`. However, it is called when `ID_RECALC_ALL` is used.

Sergey Sharybin commented

2019-05-23 17:43:47 +02:00

Short answer: use ID_RECALC_COPY_ON_WRITE | ID_RECALC_SELECT.

Long answer: due to some historical reasons batch cache component (where selection is living) is not making CoW component to be run (was a measure to speed up updates on materials). Using explicit tag should solve this. And then in the future we can have a more closer look and hide CoW specifics from the "user space".

Short answer: use `ID_RECALC_COPY_ON_WRITE | ID_RECALC_SELECT`. Long answer: due to some historical reasons batch cache component (where selection is living) is not making CoW component to be run (was a measure to speed up updates on materials). Using explicit tag should solve this. And then in the future we can have a more closer look and hide CoW specifics from the "user space".

Philipp Oeser commented

2019-05-24 12:07:55 +02:00

Can confirm ID_RECALC_COPY_ON_WRITE | ID_RECALC_SELECT works.
There is still an issue when the curve has multiple nurbs [highlighting only works in the very first], as well as the issue with the other selection tools [box, lasso, ...].
Will check on these...

Can confirm `ID_RECALC_COPY_ON_WRITE | ID_RECALC_SELECT` works. There is still an issue when the curve has multiple nurbs [highlighting only works in the very first], as well as the issue with the other selection tools [box, lasso, ...]. Will check on these...

Campbell Barton was unassigned by Philipp Oeser

2019-05-24 12:08:59 +02:00

Philipp Oeser self-assigned this 2019-05-24 12:08:59 +02:00

blender-admin commented

2019-05-24 12:10:27 +02:00

This issue was referenced by 24b2fe50f3

This issue was referenced by 24b2fe50f3ec13ac538a0fb504d53016331b17bb

Jacques Lucke commented

2019-05-24 13:05:12 +02:00

@lichtwerk, then please also commit the fix mentioned by sergey.

Philipp Oeser commented

2019-05-28 16:10:25 +02:00

Changed status from 'Open' to: 'Resolved'

Philipp Oeser closed this issue

2019-05-28 16:10:25 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Active point of Curve objects is not displayed correctly #64829