Page MenuHome

Emitter (non-hair) Particle Edit mode: 2 Crashes
Confirmed, NormalPublicBUG

Description

System Information
Operating system: Windows-7-6.1.7601-SP1 64 Bits
Graphics card: GeForce GTX 760/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 390.65

Blender Version
Broken: version: 2.80 (sub 69), branch: blender2.7, commit date: 2019-05-17 23:36, hash: rB03672e77836d
Worked: (optional)

Short description of error
Particle Edit: 2 Crashes

Exact steps for others to reproduce the error
Particle Edit: 2 Crashes

  1. Open the blender file and click on the buttons "Particle select and display point"
  2. Crash 1 (Screenshot)
  1. Open the blender file and click on the tool "Weight" and click into the particles
  2. Crash 2 (Screenshot)
  1. Also had a crash with "Puff"
  2. file not included
  1. There are some tools that do nothing while others work
  2. User gets no feedback / error message but give no feedback

Event Timeline

I confirm all the crashes

Philipp Oeser (lichtwerk) lowered the priority of this task from 90 to 50.May 20 2019, 9:54 AM

Confirmed, checking...

some notes:
I think Puff, Cut and Add are just for hair [not for editing emmiter paths]?
Weight is not really for emmiter paths either (but can be used to tweak softbodies)

Maybe we can hide the brushes/tools (if they are not appropriate)?

crashes:

  • (1) happens when point->totkey is zero (checking for that in particle_batch_cache_ensure_edit_tip_pos and in ensure_edit_inner_points_count do nothing instead of assert helps), I assume these are unborn/died particles?
  • (2) Weight brush needs particle->hair (but doesnt check for it... see particle_key_weight)

I can do Diffs for both...

  • btw. edit point / tip drawing doesnt seem to be implemented yet?
  • btw. cloth editing seems to work (but misses edit paths drawing)?
  • btw. softbody editing seems to work (but misses edit paths drawing)?

Since this seems to be a mixed bag of issues, already subscribing @Sergey Sharybin (sergey) and @Brecht Van Lommel (brecht) here: shall I do the Diffs (and also look into the editpoint drawing / editpath missing implementations?)
Is this a high prio for 2.80?

EDIT: corrected previous comment about softbody editing (seems to work indeed -- still paths drawing is missing...)

Not super high priority, but still would be good to fix for 2.80.

What is the status here? Will it be fixed for 2.80? Thanks.

Can report that the Crash 2 is fixed (doesn't occur because there is no functionality), but Crash 1 is still valid.
Because this ticket is not assigned to anyone, I assigned it to @Brecht Van Lommel (brecht) (I know I'm not allowed to do this...)

Tested with blender-2.80.0-git.5f140e61c28c

Thanks, but we'll assign reports ourselves.

Philipp Oeser (lichtwerk) renamed this task from Particle Edit: 2 Crashes to Emitter (non-hair) Particle Edit mode: 2 Crashes.Sep 4 2019, 1:23 PM

(1) already asserts earlier now:
BLI_assert failed: /blender/draw/intern/draw_cache_impl_particles.c:1519, particle_batch_cache_ensure_edit_pos_and_seg(), at '!"Hairs are not in edit mode!"'
(Just dropping this here because I have seen in reports elsewhere - hopefully this will make it easier to track down the issue...)

Richard Antalik (ISS) changed the subtype of this task from "Report" to "Bug".