Added hotkeys to switch mode disfunctional / lost hotkeys in keymap #65064

New Issue

Reiner Prokein · 2019-05-24T10:27:14+02:00

Reiner Prokein commented

2019-05-24 10:27:14 +02:00

Blender Version
Broken: version: 2.80 (sub 69), branch: master (modified), commit date: 2019-05-19 04:56, hash: f2eef45200
Worked: (optional)

Short description of error
When i add hotkeys to the modes, then this hotkeys does simply nothing. I can't jump to edit mode with added hotkey alt 2 for example.

The second thing could be related, which i can't really test since the hotkeys are disfunctional anyways.

But when i add a hotkey to switch to pose mode, with a armature selected, and switch to a primitive then, and export the keymap, then the hotkey to switch to pose mode is destroyed in the exported keymap. The mode is missing. Vice versa too. When i export the keymap with the armature selected, then the modes for the mesh primitives, to switch to sculpt mode for example, are gone.

What is obvious in the keymap manager is, when i change the object type, then the mode button for not fitting modes turns blank. That's the hotkeys that are missing then after exporting the keymap ...

Exact steps for others to reproduce the error

Open Blender. Add Hotkey Alt 2 for Edit Mode, Hotkey Alt 4 for Sculpt Mode with the cube selected. Then add Alt 3 for Pose Mode with a armature selected. Try to use the hotkeys.

Now export the keymap with the cube selected. And have a look at the code.

testkeymap.py

**Blender Version** Broken: version: 2.80 (sub 69), branch: master (modified), commit date: 2019-05-19 04:56, hash: `f2eef45200` Worked: (optional) **Short description of error** When i add hotkeys to the modes, then this hotkeys does simply nothing. I can't jump to edit mode with added hotkey alt 2 for example. The second thing could be related, which i can't really test since the hotkeys are disfunctional anyways. But when i add a hotkey to switch to pose mode, with a armature selected, and switch to a primitive then, and export the keymap, then the hotkey to switch to pose mode is destroyed in the exported keymap. The mode is missing. Vice versa too. When i export the keymap with the armature selected, then the modes for the mesh primitives, to switch to sculpt mode for example, are gone. What is obvious in the keymap manager is, when i change the object type, then the mode button for not fitting modes turns blank. That's the hotkeys that are missing then after exporting the keymap ... **Exact steps for others to reproduce the error** Open Blender. Add Hotkey Alt 2 for Edit Mode, Hotkey Alt 4 for Sculpt Mode with the cube selected. Then add Alt 3 for Pose Mode with a armature selected. Try to use the hotkeys. Now export the keymap with the cube selected. And have a look at the code. ![modebyhotkey.jpg](https://archive.blender.org/developer/F7064865/modebyhotkey.jpg) ![posemode.jpg](https://archive.blender.org/developer/F7064869/posemode.jpg) [testkeymap.py](https://archive.blender.org/developer/F7064871/testkeymap.py)

Reiner Prokein commented

2019-05-24 10:27:14 +02:00

Added subscriber: @tiles

Sebastian Parborg commented

2019-06-12 18:00:34 +02:00

Added subscriber: @ZedDB

Sebastian Parborg commented

2019-06-12 18:00:34 +02:00

At least for the first issue, the problem is that alt + 2 is already bound to something in the default keymap.

Just search for the alt + 2 in the keymap any the conflicting key maps will show.

Is the second issue still happening for you?

At least for the first issue, the problem is that alt + 2 is already bound to something in the default keymap. Just search for the `alt + 2` in the keymap any the conflicting key maps will show. Is the second issue still happening for you?

Reiner Prokein commented

2019-06-13 07:48:08 +02:00

Ah sorry for overlooking that i use a hotkey that is already in use. Yes, it still happens. It doesn't matter what hotkey i assign here. The problem isn't the double, it's that the hotkey gets lost when saving the keymap.

Campbell Barton was assigned by Sebastian Parborg

2019-06-13 11:57:45 +02:00

Sebastian Parborg commented

2019-06-13 11:57:45 +02:00

I can confirm that the Mode for the pose keymap vanishes when selecting an object that doesn't have a pose mode.

I can confirm that the `Mode` for the pose keymap vanishes when selecting an object that doesn't have a pose mode.

Campbell Barton was unassigned by Brecht Van Lommel

2019-07-03 18:31:16 +02:00

Brecht Van Lommel commented

2019-07-03 18:31:16 +02:00

Added subscriber: @ideasman42

Jason Shoumar commented

2020-09-08 02:00:13 +02:00

Added subscriber: @XSI-Guy

Jason Shoumar commented

2020-09-08 02:00:13 +02:00

I am having the same issue even now with Blender 2.9 released version.

Has there been any progress on this issue ?

I am having the same issue even now with Blender 2.9 released version. Has there been any progress on this issue ?

Dalai Felinto commented

2020-10-15 10:57:14 +02:00

Added subscriber: @dfelinto

Dalai Felinto commented

2020-10-15 10:57:14 +02:00

Hi @XSI-Guy this was triaged as a known issue, which is a way to document the current limitations of a module.

Anyone is welcome to help tackling it, but the UI module has no plans of working on it in the foreseeable future.

Hi @XSI-Guy this was triaged as a known issue, which is a way to document the current limitations of a module. Anyone is welcome to help tackling it, but the UI module has no plans of working on it in the foreseeable future.

Alok Gandhi commented

2021-04-04 22:14:53 +02:00

Added subscriber: @alok1974

Alok Gandhi commented

2021-04-12 21:45:20 +02:00

I am trying to take a stab at this. Please note that the solutions that I propose down here might not be the best as I have started on Blender and its source code just a week ago!

Problem
While exporting, the keymap datais read from theuserpref` UI, which in turn is dynamically updated depending on the context of the selected object's mode . Object modes are culled for a context and thus modes available in one object context (like 'POSE' in armature) might not be available on another object context (mesh cube). This leads to blank UI and consequently <''> in the exported key config.

First Solution

Disable the mode field in the layout temporarily while exporting the keymaps. This can be done by calling draw_keymaps() in rna_keymap_ui.py with a modification to not draw box.template_keymap_item_properties(kmi). This keymap exports will be read from the internal memory correctly.

Pros

Cleaner solution in respect to other ones mentioned below

Cons

Hard to implement as calling the keymap UI redraw would need some serious effort (at least for me)

Second Solution (Tested and I have the code almost ready)

While reading the keymap from the UI, if the mode is not available, it's value is always returned as '', catch that and try to change the object context by creating alternative object types. I have figured out that all of the 13 available object modes can be covered with just 4 object types - Mesh, Armature, Grease Pencil and Particle Systems. The keymap mode must definitely belong to one of those. Changing to each one of them and then trying to get the mode will result in a non-empty value (or a str != "" in this case).

Pros

Works! (already tested and have an implementation ready)

Cons

Seems a bit hacky

I am looking to fix this, let me know if and how can I proceed @dfelinto, @ideasman42

Cheers!

I am trying to take a stab at this. Please note that the solutions that I propose down here might not be the best as I have started on Blender and its source code just a week ago! **Problem** While exporting, the `keymap` data` is read from the `userpref` UI, which in turn is dynamically updated depending on the context of the selected [object's mode ](https://github.com/blender/blender/blob/2b9e6943cdf5a892b874ce03ec0dea9d7b5399ff/source/blender/makesdna/DNA_object_enums.h#L30). Object modes are culled for a context and thus modes available in one object context (like 'POSE' in armature) might not be available on another object context (mesh cube). This leads to blank UI and consequently <''> in the exported key config. **First Solution** - Disable the mode field in the layout temporarily while exporting the keymaps. This can be done by calling `draw_keymaps()` in `rna_keymap_ui.py` with a modification to not draw [box.template_keymap_item_properties(kmi)](https://github.com/blender/blender/blob/2b9e6943cdf5a892b874ce03ec0dea9d7b5399ff/release/scripts/modules/rna_keymap_ui.py#L209). This keymap exports will be read from the internal memory correctly. ![mode.png](https://archive.blender.org/developer/F9930934/mode.png) Pros - Cleaner solution in respect to other ones mentioned below Cons - Hard to implement as calling the keymap UI redraw would need some serious effort (at least for me) **Second Solution (Tested and I have the code almost ready)** - While reading the keymap from the UI, if the mode is not available, it's value is always returned as '', catch that and try to change the object context by creating alternative object types. I have figured out that all of the 13 available object modes can be covered with just 4 object types - Mesh, Armature, Grease Pencil and Particle Systems. The keymap mode must definitely belong to one of those. Changing to each one of them and then trying to get the mode will result in a non-empty value (or a `str != ""` in this case). Pros - Works! (already tested and have an implementation ready) Cons - Seems a bit hacky I am looking to fix this, let me know if and how can I proceed @dfelinto, @ideasman42 Cheers!

Campbell Barton self-assigned this 2021-04-14 16:50:33 +02:00

blender-admin commented

2021-04-16 07:04:59 +02:00

This issue was referenced by 919558854d

This issue was referenced by 919558854d624f5db40acfa9f5674ac8c94873b6

Campbell Barton commented

2021-04-16 07:10:22 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Campbell Barton closed this issue

2021-04-16 07:10:22 +02:00

Alok Gandhi commented

2021-04-16 09:23:53 +02:00