Page MenuHome

Keymap conflict (Node Editor / Node Wrangler)
Closed, ResolvedPublic

Description

System Information
Operating system: Windows-10-10.0.17134 64 Bits
Graphics card: GeForce GTX 980/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 417.71

Blender Version
Broken: version: 2.80 (sub 72), branch: blender2.7, commit date: 2019-05-26 22:34, hash: rBd525c76003b3
Worked: (optional)

Short description of error
With the default keymap, Shift+RMB and drag on a connection on the Node Editor creates a reroute node, and Ctrl+RMB drag cuts the connections... but if Node Wrangler addon is enabled, Ctrl+RMB drag enables the "Lazy connect" option of Node Wrangler, overwriting the connection cutting shortcut. I understand that it's an addon, but being that it comes bundled in Blender and given that it's arguably necessary to get the most out of the Node Editor, it shouldn't create conflicts like this.

Exact steps for others to reproduce the error
Works in any file. Just try to cut connections between nodes using Ctrl+RMB drag with Node Wrangler addon enabled.

Thanks!

Event Timeline

@William Reynish (billreynish) : I am a bit on shaky ground when it comes to keymap convention: why are we having reroute/cut swapped from LMB to RMB (when choosing Select with Left in keymap preferences)?
in 2.79 it was always LMB (no matter what was chosen for Select with...)

Just asking here to see if NodeWrangler should also do some keymap swapping [LMB <-> RMB] depending on Select with User Preference.

@Philipp Oeser (lichtwerk) Well, Ctrl-LMB and Shift-LMB are use to add and remove for box select, so they are already used. Same in other editors, which is why setting the 3D Cursor in the 3D view is done with Shift-RMB.

hi, with addons overwriting built in key maps usually they provide same functionality, extended functionality or pie v's standard menu. They should where possible not overwrite built in functions. The simple solution in this case would be to remap the offending keymap conflict/s in the addon.
@Philipp Oeser (lichtwerk) as the default is now left click select, it's all that's required by the addon. To work with the defaults. That said, if there was a module that addons could call that generically swaps "left to right" it would be handy for old timers that still wish to use right mouse select?

@William Reynish (billreynish) : ok, I see (sort of -- I am RMB selector....we dont have LMB box in the node editor... except for the box-tool, then reroute/cut is not functional which is expected...)

hi, with addons overwriting built in key maps usually they provide same functionality, extended functionality or pie v's standard menu. They should where possible not overwrite built in functions. The simple solution in this case would be to remap the offending keymap conflict/s in the addon.
@Philipp Oeser (lichtwerk) as the default is now left click select, it's all that's required by the addon. To work with the defaults. That said, if there was a module that addons could call that generically swaps "left to right" it would be handy for old timers that still wish to use right mouse select?

having this swapping generic would be nice. for this report: should we just go over shortcuts and swap depending on preference?

Yes that should work. Maybe the offending key could be moved to alt shift?

Is this supposed to be assigned to someone or is this just not that much of a problem?

Brendon Murphy (meta-androcto) triaged this task as Confirmed, High priority.

hi, assigned to Philipp, We all know about this issue.
Changing priority to high. We need to make a decision and make a move on this before rc1.

Hesitating to just commit something here, but here is what I would do:

Default keymap current state
Alt RMB free
Ctrl RMB cut links
Ctrl Shift RMB free

NodeWrangler current state
Alt RMB Lazy mix
Ctrl RMB Lazy Connect (offending)
Ctrl Shift RMB Lazy Connect menu

NodeWrangler proposed future
Alt RMB Lazy Connect
Alt Shift RMB Lazy Connect menu
Ctrl Shift RMB Lazy mix

This keeps the two Lazy Connect on a common "base" key and moves Lazy mix... Does this sound OK?

Is there a way for cut links to go back to ctrl LMB? Right now LMB and Ctrl LMB both do box select

@ronald johnson (billyand) : LMB is select [Deselect on nothing ON], Ctrl LMB is select [Deselect on nothing OFF] (which is like toggle), so these are not the same...
Guess I will commit the above now...