Keymap conflict (Node Editor / Node Wrangler) #65202

New Issue

Oliver Villar · 2019-05-27T23:03:58+02:00

Oliver Villar commented

2019-05-27 23:03:58 +02:00

System Information
Operating system: Windows-10-10.0.17134 64 Bits
Graphics card: GeForce GTX 980/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 417.71

Blender Version
Broken: version: 2.80 (sub 72), branch: blender2.7, commit date: 2019-05-26 22:34, hash: blender/blender@d525c76003
Worked: (optional)

Short description of error
With the default keymap, Shift+RMB and drag on a connection on the Node Editor creates a reroute node, and Ctrl+RMB drag cuts the connections... but if Node Wrangler addon is enabled, Ctrl+RMB drag enables the "Lazy connect" option of Node Wrangler, overwriting the connection cutting shortcut. I understand that it's an addon, but being that it comes bundled in Blender and given that it's arguably necessary to get the most out of the Node Editor, it shouldn't create conflicts like this.

Exact steps for others to reproduce the error
Works in any file. Just try to cut connections between nodes using Ctrl+RMB drag with Node Wrangler addon enabled.

Thanks!

**System Information** Operating system: Windows-10-10.0.17134 64 Bits Graphics card: GeForce GTX 980/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 417.71 **Blender Version** Broken: version: 2.80 (sub 72), branch: blender2.7, commit date: 2019-05-26 22:34, hash: `blender/blender@d525c76003` Worked: (optional) **Short description of error** With the default keymap, Shift+RMB and drag on a connection on the Node Editor creates a reroute node, and Ctrl+RMB drag cuts the connections... but if Node Wrangler addon is enabled, Ctrl+RMB drag enables the "Lazy connect" option of Node Wrangler, overwriting the connection cutting shortcut. I understand that it's an addon, but being that it comes bundled in Blender and given that it's arguably necessary to get the most out of the Node Editor, it shouldn't create conflicts like this. **Exact steps for others to reproduce the error** Works in any file. Just try to cut connections between nodes using Ctrl+RMB drag with Node Wrangler addon enabled. Thanks!

Oliver Villar commented

2019-05-27 23:03:58 +02:00

Added subscriber: @OliverVillar

blender-admin commented

2019-05-27 23:03:58 +02:00

#66700 was marked as duplicate of this issue

blender-admin commented

2019-05-27 23:03:58 +02:00

blender/blender#66341 was marked as duplicate of this issue

Philipp Oeser commented

2019-05-28 11:24:39 +02:00

Added subscribers: @WilliamReynish, @lichtwerk

Philipp Oeser commented

2019-05-28 11:24:39 +02:00

@WilliamReynish : I am a bit on shaky ground when it comes to keymap convention: why are we having reroute/cut swapped from LMB to RMB (when choosing Select with Left in keymap preferences)?
in 2.79 it was always LMB (no matter what was chosen for Select with...)

Just asking here to see if NodeWrangler should also do some keymap swapping [LMB <-> RMB] depending on Select with User Preference.

@WilliamReynish : I am a bit on shaky ground when it comes to keymap convention: why are we having reroute/cut swapped from LMB to RMB (when choosing `Select with` `Left` in keymap preferences)? in 2.79 it was always LMB (no matter what was chosen for `Select with`...) Just asking here to see if NodeWrangler should also do some keymap swapping [LMB <-> RMB] depending on `Select with` User Preference.

William Reynish commented

2019-05-28 11:52:24 +02:00

@lichtwerk Well, Ctrl-LMB and Shift-LMB are use to add and remove for box select, so they are already used. Same in other editors, which is why setting the 3D Cursor in the 3D view is done with Shift-RMB.

Brendon Murphy commented

2019-05-28 12:25:06 +02:00

Added subscriber: @BrendonMurphy

Brendon Murphy commented

2019-05-28 12:25:06 +02:00

hi, with addons overwriting built in key maps usually they provide same functionality, extended functionality or pie v's standard menu. They should where possible not overwrite built in functions. The simple solution in this case would be to remap the offending keymap conflict/s in the addon.
@lichtwerk as the default is now left click select, it's all that's required by the addon. To work with the defaults. That said, if there was a module that addons could call that generically swaps "left to right" it would be handy for old timers that still wish to use right mouse select?

hi, with addons overwriting built in key maps usually they provide same functionality, extended functionality or pie v's standard menu. They should where possible not overwrite built in functions. The simple solution in this case would be to remap the offending keymap conflict/s in the addon. @lichtwerk as the default is now left click select, it's all that's required by the addon. To work with the defaults. That said, if there was a module that addons could call that generically swaps "left to right" it would be handy for old timers that still wish to use right mouse select?

Philipp Oeser commented

2019-05-28 13:05:36 +02:00

@WilliamReynish : ok, I see (sort of -- I am RMB selector....we dont have LMB box in the node editor... except for the box-tool, then reroute/cut is not functional which is expected...)

In #65202#689551, @BrendonMurphy wrote:
hi, with addons overwriting built in key maps usually they provide same functionality, extended functionality or pie v's standard menu. They should where possible not overwrite built in functions. The simple solution in this case would be to remap the offending keymap conflict/s in the addon.
@lichtwerk as the default is now left click select, it's all that's required by the addon. To work with the defaults. That said, if there was a module that addons could call that generically swaps "left to right" it would be handy for old timers that still wish to use right mouse select?

having this swapping generic would be nice. for this report: should we just go over shortcuts and swap depending on preference?

@WilliamReynish : ok, I see (sort of -- I am RMB selector....we dont have LMB box in the node editor... except for the box-tool, then reroute/cut is not functional which is expected...) > In #65202#689551, @BrendonMurphy wrote: > hi, with addons overwriting built in key maps usually they provide same functionality, extended functionality or pie v's standard menu. They should where possible not overwrite built in functions. The simple solution in this case would be to remap the offending keymap conflict/s in the addon. > @lichtwerk as the default is now left click select, it's all that's required by the addon. To work with the defaults. That said, if there was a module that addons could call that generically swaps "left to right" it would be handy for old timers that still wish to use right mouse select? having this swapping generic would be nice. for this report: should we just go over shortcuts and swap depending on preference?

Brendon Murphy commented

2019-05-28 13:16:07 +02:00

Yes that should work. Maybe the offending key could be moved to alt shift?

Brecht Van Lommel commented

2019-07-02 16:32:08 +02:00

Added subscriber: @AlexBitsadze

ronald johnson commented

2019-07-07 02:49:29 +02:00

Added subscriber: @billyand

ronald johnson commented

2019-07-07 02:52:11 +02:00

Is this supposed to be assigned to someone or is this just not that much of a problem?

Philipp Oeser was assigned by Brendon Murphy

2019-07-07 03:12:03 +02:00

Brendon Murphy commented

2019-07-07 03:12:03 +02:00

hi, assigned to Philipp, We all know about this issue.
Changing priority to high. We need to make a decision and make a move on this before rc1.

hi, assigned to Philipp, We all know about this issue. Changing priority to high. We need to make a decision and make a move on this before rc1.

Philipp Oeser commented

2019-07-08 15:30:53 +02:00

Hesitating to just commit something here, but here is what I would do:

Default keymap current state
Alt RMB free
Ctrl RMB cut links
Ctrl Shift RMB free

NodeWrangler current state
Alt RMB Lazy mix
Ctrl RMB Lazy Connect (offending)
Ctrl Shift RMB Lazy Connect menu

NodeWrangler proposed future
Alt RMB Lazy Connect
Alt Shift RMB Lazy Connect menu
Ctrl Shift RMB Lazy mix

This keeps the two Lazy Connect on a common "base" key and moves Lazy mix... Does this sound OK?

Hesitating to just commit something here, but here is what I would do: **Default keymap current state** `Alt` `RMB` free `Ctrl` `RMB` cut links `Ctrl` `Shift` `RMB` free **NodeWrangler current state** `Alt` `RMB` Lazy mix `Ctrl` `RMB` Lazy Connect (**offending**) `Ctrl` `Shift` `RMB` Lazy Connect menu **NodeWrangler proposed future** `Alt` `RMB` Lazy Connect `Alt` `Shift` `RMB` Lazy Connect menu `Ctrl` `Shift` `RMB` Lazy mix This keeps the two `Lazy Connect` on a common "base" key and moves `Lazy mix`... Does this sound OK?

Brecht Van Lommel commented

2019-07-08 15:36:50 +02:00

Added subscriber: @brecht

Brecht Van Lommel commented

2019-07-08 15:36:50 +02:00

Sounds good to me.

William Reynish commented

2019-07-08 16:06:23 +02:00

Seems reasonable

Sean Kennedy commented

2019-07-08 23:54:20 +02:00

Added subscriber: @SeanKennedy

ronald johnson commented

2019-07-09 02:07:49 +02:00

Is there a way for cut links to go back to ctrl LMB? Right now LMB and Ctrl LMB both do box select

Philipp Oeser commented

2019-07-09 09:55:18 +02:00

@billyand : LMB is select [Deselect on nothing ON], Ctrl LMB is select [Deselect on nothing OFF] (which is like toggle), so these are not the same...
Guess I will commit the above now...

@billyand : LMB is select [Deselect on nothing ON], Ctrl LMB is select [Deselect on nothing OFF] (which is like toggle), so these are not the same... Guess I will commit the above now...

blender-admin commented

2019-07-09 10:20:26 +02:00

This issue was referenced by e08d6983c0

This issue was referenced by e08d6983c05fde19b2cb21d1b01ea0939fc58b4f

Philipp Oeser commented

2019-07-09 10:26:06 +02:00

Changed status from 'Open' to: 'Resolved'

Philipp Oeser closed this issue

2019-07-09 10:26:06 +02:00

Brecht Van Lommel commented

2019-07-11 11:39:20 +02:00

Added subscriber: @Damjan-2