Changing Hotkey for Perspective/Orthographic isn't working after being changed #66741

Open
opened 2019-07-12 09:08:41 +02:00 by Tyson Matthews · 5 comments

System Information
Operating system: Windows-10-10.0.18362 64 Bits
Graphics card: GeForce RTX 2080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 430.86

Blender Version
Broken: version: 2.80 (sub 74), branch: master, commit date: 2019-06-30 19:51, hash: bbb3500c97
Worked: (optional)

Short description of error
When changing the hotkey for the Perspective/Orthographic Toggle to 'Ctrl + 5' or 'Shift + Ctrl + 5' the hotkey stops working (I cannot test whether it works with the default hotkey as I have no numpad).

Exact steps for others to reproduce the error

  1. Start up Blender.
  2. Open preferences.
  3. Go to keymap tab.
  4. Go to 'View Persp/Ortho' hotkey. (Can be searched by typing 'ortho' into search tab)
  5. Change Hotkey to 'Ctrl 5'.
  6. Unset the 'Subdivision Set' hotkey.
  7. Test hotkey.
    [Based on the default startup or an attached .blend file (as simple as possible)]
**System Information** Operating system: Windows-10-10.0.18362 64 Bits Graphics card: GeForce RTX 2080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 430.86 **Blender Version** Broken: version: 2.80 (sub 74), branch: master, commit date: 2019-06-30 19:51, hash: `bbb3500c97` Worked: (optional) **Short description of error** When changing the hotkey for the Perspective/Orthographic Toggle to 'Ctrl + 5' or 'Shift + Ctrl + 5' the hotkey stops working (I cannot test whether it works with the default hotkey as I have no numpad). **Exact steps for others to reproduce the error** 1. Start up Blender. 2. Open preferences. 3. Go to keymap tab. 4. Go to 'View Persp/Ortho' hotkey. (Can be searched by typing 'ortho' into search tab) 5. Change Hotkey to 'Ctrl 5'. 6. Unset the 'Subdivision Set' hotkey. 7. Test hotkey. [Based on the default startup or an attached .blend file (as simple as possible)]
Author

Added subscriber: @Trademark0928

Added subscriber: @Trademark0928

Added subscriber: @mano-wii

Added subscriber: @mano-wii
Brecht Van Lommel was assigned by Germano Cavalcante 2019-07-12 17:59:45 +02:00

This keymap conflicts with the operator Hide Collection.
We could add the PASS_THROUGH to this operator.

diff --git a/source/blender/editors/object/object_edit.c b/source/blender/editors/object/object_edit.c
index a390cf67cf5..9ea70b643be 100644
--- a/source/blender/editors/object/object_edit.c
+++ b/source/blender/editors/object/object_edit.c
@@ -283,7 +283,7 @@ static int object_hide_collection_exec(bContext *C, wmOperator *op)
   LayerCollection *lc = BKE_layer_collection_from_index(view_layer, index);
 
   if (!lc) {
-    return OPERATOR_CANCELLED;
+    return OPERATOR_CANCELLED | OPERATOR_PASS_THROUGH;
   }
 
   DEG_id_tag_update(&scene->id, ID_RECALC_BASE_FLAGS);

Operator created in commit 4234cddda9

This keymap conflicts with the operator `Hide Collection`. We could add the `PASS_THROUGH` to this operator. ``` diff --git a/source/blender/editors/object/object_edit.c b/source/blender/editors/object/object_edit.c index a390cf67cf5..9ea70b643be 100644 --- a/source/blender/editors/object/object_edit.c +++ b/source/blender/editors/object/object_edit.c @@ -283,7 +283,7 @@ static int object_hide_collection_exec(bContext *C, wmOperator *op) LayerCollection *lc = BKE_layer_collection_from_index(view_layer, index); if (!lc) { - return OPERATOR_CANCELLED; + return OPERATOR_CANCELLED | OPERATOR_PASS_THROUGH; } DEG_id_tag_update(&scene->id, ID_RECALC_BASE_FLAGS); ``` Operator created in commit 4234cddda9

Passing through events depending on the existence of the collection is not a good solution. That still leaves the same conflict when there are more than a few collections.

Passing through events depending on the existence of the collection is not a good solution. That still leaves the same conflict when there are more than a few collections.
Brecht Van Lommel was unassigned by Dalai Felinto 2019-12-23 16:33:48 +01:00

Added subscriber: @brecht

Added subscriber: @brecht
Philipp Oeser removed the
Interest
User Interface
label 2023-02-10 09:25:31 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#66741
No description provided.