In specific condition pressing ctrl + a -> 0 crashes the blender #66967

Closed
opened 2019-07-15 10:00:55 +02:00 by Abid Maqbool · 9 comments

System Information
Operating system: Windows-10-10.0.17134 64 Bits
Graphics card: AMD Radeon HD 8400 / R3 Series ATI Technologies Inc. 4.5.13399 Core Profile Context 15.200.1065.0

Blender Version
Broken: version: 2.80 (sub 74), branch: master, commit date: 2019-07-11 13:50, hash: 06312c6d2d
Worked: (optional)

Short description of error
[Please fill out a short description of the error here]

In specific condition pressing Ctrl + A & then 0 in edit mode for skin modifier cause the blender to completely crash.
The condition is think is that the at least two places should be where multiple edges are join and there is no root in any vertices then pressing ctrl + a and then entering 0 value crashes...

Exact steps for others to reproduce the error
[Please describe the exact steps needed to reproduce the issue]
[Based on the default startup or an attached .blend file (as simple as possible)]

Carefully see the GIF

In specific condition sking modifier crashes the blender.gif

**System Information** Operating system: Windows-10-10.0.17134 64 Bits Graphics card: AMD Radeon HD 8400 / R3 Series ATI Technologies Inc. 4.5.13399 Core Profile Context 15.200.1065.0 **Blender Version** Broken: version: 2.80 (sub 74), branch: master, commit date: 2019-07-11 13:50, hash: `06312c6d2d` Worked: (optional) **Short description of error** [Please fill out a short description of the error here] In specific condition pressing `Ctrl + A` & then 0 in edit mode for skin modifier cause the blender to completely crash. The condition is think is that the at least two places should be where multiple edges are join and there is no root in any vertices then pressing `ctrl + a` and then entering 0 value crashes... **Exact steps for others to reproduce the error** [Please describe the exact steps needed to reproduce the issue] [Based on the default startup or an attached .blend file (as simple as possible)] Carefully see the GIF ![In specific condition sking modifier crashes the blender.gif](https://archive.blender.org/developer/F7610196/In_specific_condition_sking_modifier_crashes_the_blender.gif)
Author

Added subscriber: @AbidMaqbool

Added subscriber: @AbidMaqbool
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Philipp Oeser self-assigned this 2019-07-15 10:32:14 +02:00
Member

Can confirm, will check on this.
#66967.blend

Can confirm, will check on this. [#66967.blend](https://archive.blender.org/developer/F7610274/T66967.blend)
Author

@lichtwerk I check the file and blender 2.8 crashes...

@lichtwerk I check the file and blender 2.8 crashes...
Member

@AbidMaqbool : yes, it is confirmed.
(it is not a regression though, 2.79 also crashed in this scenario...)

note: getting an error printed (still shouldnt crash though...):
ERROR (bke.modifier): /blender/blenkernel/intern/modifier.c:410 modifier_setError: No valid root vertex found (you need one per mesh island you want to skin)
checking further...

@AbidMaqbool : yes, it is confirmed. (it is not a regression though, 2.79 also crashed in this scenario...) note: getting an error printed (still shouldnt crash though...): `ERROR (bke.modifier): /blender/blenkernel/intern/modifier.c:410 modifier_setError: No valid root vertex found (you need one per mesh island you want to skin)` checking further...
Member

Note this also crashed in 2.79.

It does so in bullet (well, at least asserts there), #38521 was a similar case, I had my go at safeguarding this in D5285...

1   raise                                                                        0x7ffff1b5be75 
2   abort                                                                        0x7ffff1b46895 
3   __assert_fail_base.cold                                                      0x7ffff1b46769 
4   __assert_fail                                                                0x7ffff1b54566 
5   btConvexHullInternal::findEdgeForCoplanarFaces btConvexHullComputer.cpp 1474 0x696c6ff      
6   btConvexHullInternal::merge                    btConvexHullComputer.cpp 1720 0x696d877      
7   btConvexHullInternal::computeInternal          btConvexHullComputer.cpp 1313 0x696c136      
8   btConvexHullInternal::compute                  btConvexHullComputer.cpp 2058 0x696ec6d      
9   btConvexHullComputer::compute                  btConvexHullComputer.cpp 2656 0x697114d      
10  btConvexHullComputer::compute                  btConvexHullComputer.h   92   0x35de3d1      
11  plConvexHullCompute                            Bullet-C-API.cpp         411  0x695efee      
12  hull_from_bullet                               bmo_hull.c               487  0x27d75c9      
13  bmo_convex_hull_exec                           bmo_hull.c               575  0x27d7baf      
14  BMO_op_exec                                    bmesh_operators.c        223  0x2736b22      
15  build_hull                                     MOD_skin.c               244  0x29f9939      
16  skin_output_branch_hulls                       MOD_skin.c               1729 0x2a0525d      
17  build_skin                                     MOD_skin.c               1781 0x2a0540e      
18  base_skin                                      MOD_skin.c               1858 0x2a05652      
19  final_skin                                     MOD_skin.c               1894 0x2a05768      
20  applyModifier                                  MOD_skin.c               1918 0x2a057ed
Note this also crashed in 2.79. It does so in bullet (well, at least asserts there), #38521 was a similar case, I had my go at safeguarding this in [D5285](https://archive.blender.org/developer/D5285)... ``` 1 raise 0x7ffff1b5be75 2 abort 0x7ffff1b46895 3 __assert_fail_base.cold 0x7ffff1b46769 4 __assert_fail 0x7ffff1b54566 5 btConvexHullInternal::findEdgeForCoplanarFaces btConvexHullComputer.cpp 1474 0x696c6ff 6 btConvexHullInternal::merge btConvexHullComputer.cpp 1720 0x696d877 7 btConvexHullInternal::computeInternal btConvexHullComputer.cpp 1313 0x696c136 8 btConvexHullInternal::compute btConvexHullComputer.cpp 2058 0x696ec6d 9 btConvexHullComputer::compute btConvexHullComputer.cpp 2656 0x697114d 10 btConvexHullComputer::compute btConvexHullComputer.h 92 0x35de3d1 11 plConvexHullCompute Bullet-C-API.cpp 411 0x695efee 12 hull_from_bullet bmo_hull.c 487 0x27d75c9 13 bmo_convex_hull_exec bmo_hull.c 575 0x27d7baf 14 BMO_op_exec bmesh_operators.c 223 0x2736b22 15 build_hull MOD_skin.c 244 0x29f9939 16 skin_output_branch_hulls MOD_skin.c 1729 0x2a0525d 17 build_skin MOD_skin.c 1781 0x2a0540e 18 base_skin MOD_skin.c 1858 0x2a05652 19 final_skin MOD_skin.c 1894 0x2a05768 20 applyModifier MOD_skin.c 1918 0x2a057ed ```
Philipp Oeser was unassigned by Dalai Felinto 2019-12-23 16:33:46 +01:00

This issue was referenced by 50994eace6

This issue was referenced by 50994eace677e1775382ded567898f1ff4cb5467

This issue was referenced by 0a00fbd265

This issue was referenced by 0a00fbd265ac75e2d900f34570a6842e7ea70a2e

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Campbell Barton self-assigned this 2020-06-02 15:46:54 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#66967
No description provided.