Page MenuHome

In specific condition pressing `ctrl + a` -> 0 crashes the blender
Open, Confirmed, MediumPublic

Description

System Information
Operating system: Windows-10-10.0.17134 64 Bits
Graphics card: AMD Radeon HD 8400 / R3 Series ATI Technologies Inc. 4.5.13399 Core Profile Context 15.200.1065.0

Blender Version
Broken: version: 2.80 (sub 74), branch: master, commit date: 2019-07-11 13:50, hash: rB06312c6d2db8
Worked: (optional)

Short description of error
[Please fill out a short description of the error here]

In specific condition pressing Ctrl + A & then 0 in edit mode for skin modifier cause the blender to completely crash.
The condition is think is that the at least two places should be where multiple edges are join and there is no root in any vertices then pressing ctrl + a and then entering 0 value crashes...

Exact steps for others to reproduce the error
[Please describe the exact steps needed to reproduce the issue]
[Based on the default startup or an attached .blend file (as simple as possible)]

Carefully see the GIF

Event Timeline

Philipp Oeser (lichtwerk) claimed this task.
Philipp Oeser (lichtwerk) triaged this task as Confirmed, Medium priority.

Can confirm, will check on this.

@Philipp Oeser (lichtwerk) I check the file and blender 2.8 crashes...

@Abid Maqbool (cto.abid) : yes, it is confirmed.
(it is not a regression though, 2.79 also crashed in this scenario...)

note: getting an error printed (still shouldnt crash though...):
ERROR (bke.modifier): /blender/blenkernel/intern/modifier.c:410 modifier_setError: No valid root vertex found (you need one per mesh island you want to skin)
checking further...

Note this also crashed in 2.79.

It does so in bullet (well, at least asserts there), T38521 was a similar case, I had my go at safeguarding this in D5285...

1   raise                                                                        0x7ffff1b5be75 
2   abort                                                                        0x7ffff1b46895 
3   __assert_fail_base.cold                                                      0x7ffff1b46769 
4   __assert_fail                                                                0x7ffff1b54566 
5   btConvexHullInternal::findEdgeForCoplanarFaces btConvexHullComputer.cpp 1474 0x696c6ff      
6   btConvexHullInternal::merge                    btConvexHullComputer.cpp 1720 0x696d877      
7   btConvexHullInternal::computeInternal          btConvexHullComputer.cpp 1313 0x696c136      
8   btConvexHullInternal::compute                  btConvexHullComputer.cpp 2058 0x696ec6d      
9   btConvexHullComputer::compute                  btConvexHullComputer.cpp 2656 0x697114d      
10  btConvexHullComputer::compute                  btConvexHullComputer.h   92   0x35de3d1      
11  plConvexHullCompute                            Bullet-C-API.cpp         411  0x695efee      
12  hull_from_bullet                               bmo_hull.c               487  0x27d75c9      
13  bmo_convex_hull_exec                           bmo_hull.c               575  0x27d7baf      
14  BMO_op_exec                                    bmesh_operators.c        223  0x2736b22      
15  build_hull                                     MOD_skin.c               244  0x29f9939      
16  skin_output_branch_hulls                       MOD_skin.c               1729 0x2a0525d      
17  build_skin                                     MOD_skin.c               1781 0x2a0540e      
18  base_skin                                      MOD_skin.c               1858 0x2a05652      
19  final_skin                                     MOD_skin.c               1894 0x2a05768      
20  applyModifier                                  MOD_skin.c               1918 0x2a057ed