Page MenuHome

Need Safeguard to keep EEVEE from crashing when a file contains old blender internal shaders.
Open, Needs Triage by DeveloperPublic

Description

System Information
Operating system: Darwin-18.6.0-x86_64-i386-64bit 64 Bits
Graphics card: Intel Iris Pro OpenGL Engine Intel Inc. 4.1 INTEL-12.9.22

Blender Version
Broken: version: 2.80 (sub 74), branch: master, commit date: 2019-07-11 13:50, hash: rB06312c6d2db8
Worked: (optional)

Short description of error
[Need to create a safeguard to allowing shaders from Blender internal to avoid crashing when enabling viewport shading.]

Exact steps for others to reproduce the error
[Sometimes when opening an old file; or from a free online resource, a file containing an older shader for what I assume was Blender internal; causes the program to crash when enabling viewport shading with EEVEE. My thought is that there should be a way to either warn of the conflict before entering the shading; perhaps with a couple options to mitigate the problem:

Option 1) Allow Blender to try and replicate the desired shader using EEVEE Nodes; knowing it may still need some tuning later.
Option 2) Allow Blender to pinpoint the exact source of the conflict and allow the user to not it; and delete the node if there are nodes present.
Option 3) Allow the user to discard any Shaders altogether that will cause a crash.

I have attached a simple file with a chair I downloaded from Blendkit; which demonstrates this undesirable behavior.]

[

]

Details

Type
Bug

Event Timeline

Sebastian Parborg (zeddb) triaged this task as Needs Information from User priority.

I can not reproduce the crash with the provided file. It seems to be using linked files that is not included.

Sorry, I forgot to check link verses append when I downloaded the object in question. Here is a new file that should work to diagnose.

I also just noticed that Option 2) may not have been communicate properly.
It should read like this:

Option 2) Allow Blender to pinpoint the exact source of the conflict and allow the user to 'note' it, and 'manually' delete the 'offending' node; if there are nodes present.

I can not reproduce the crash. Does it happen with the latest build bot?

Yes it does happen with the latest; at least for me. I moved over the last year and left my desktop that ran Windows 10 with family. The only thing I have currently is a MacBook Pro from about Mid 2015.

To try and describe in slightly more detail; there are two scenarios where I can get it to crash.

  1. I go to the "Shading" workspace where viewport shading (Look Dev) is already on; and it crashes instantly.
  1. While in a normal "Layout" workspace; I click on the "Viewport Shading" (Look Dev button Grouped with Wireframe, Solid, and Rendered, etc in the header; and it crashes as soon as I hit that button.

Also note that when I deleted the shader called "cedar wood"; it no longer crashes. The other shader which was for the seat didn't seem to cause any crashes.

Here is a screenshot of the viewport button; just before crashing:

Sebastian Parborg (zeddb) raised the priority of this task from Needs Information from User to Needs Triage by Developer.

@William Reynish (billreynish) can you reproduce this?