Blender is unable to generate a complete error message when there is bad indentation in python code #67295

New Issue

nBurn · 2019-07-20T08:10:31+02:00

nBurn commented

2019-07-20 08:10:31 +02:00

Blender Version
Broken: 2.80 RC2 (Win 64)
Worked: 2.79b (Win 64)

Short description of error
Blender's built in Python interpreter is not able to load part of the error message when an IndentationError is thrown in 2.80.

Exact steps for others to reproduce the error

Open Blender from a console,
Paste the script below into Blender's text editor and run it

import bpy

def foo():
print("hello")

foo()

Console output from 2.79

location: <unknown location>:-1
Error:   File "\Text", line 4
    print("hello")
        ^
IndentationError: expected an indented block

Console output from 2.80

AttributeError: 'IndentationError' object has no attribute 'msg'
Error: Python script failed, check the message in the system console

**Blender Version** Broken: 2.80 RC2 (Win 64) Worked: 2.79b (Win 64) **Short description of error** Blender's built in Python interpreter is not able to load part of the error message when an `IndentationError` is thrown in 2.80. **Exact steps for others to reproduce the error** - Open Blender from a console, - Paste the script below into Blender's text editor and run it ``` import bpy def foo(): print("hello") foo() ``` Console output from 2.79 ``` location: <unknown location>:-1 Error: File "\Text", line 4 print("hello") ^ IndentationError: expected an indented block ``` Console output from 2.80 ``` AttributeError: 'IndentationError' object has no attribute 'msg' Error: Python script failed, check the message in the system console

nBurn commented

2019-07-20 08:10:31 +02:00

Added subscriber: @nBurn

blender-admin commented

2019-07-20 08:10:31 +02:00

#65863 was marked as duplicate of this issue

blender-admin commented

2019-07-20 08:10:31 +02:00

blender/blender#68512 was marked as duplicate of this issue

nBurn changed title from ~~bpy is not including line number when there is bad indentation~~ to bpy is not including a line number when there is bad indentation

2019-07-20 08:12:00 +02:00

nBurn changed title from ~~bpy is not including a line number when there is bad indentation~~ to Blender is unable to generate a complete error message when there is bad indentation in python code

2019-07-20 08:37:20 +02:00

Ulysse Martin commented

2019-07-20 12:09:53 +02:00

Added subscribers: @ideasman42, @you.le

Ulysse Martin commented

2019-07-20 12:09:53 +02:00

I don't know if bpy_traceback.c changed, or if python was updated since 2.79b.

In bpy_traceback.c, void python_script_error_jump(...), there is this line:

if (exception && PyErr_GivenExceptionMatches(exception, PyExc_SyntaxError)) {

What is weird is that an Indentation error is considered as a Syntax error.

I'm wondering if instead we should write:

if (exception && PyErr_GivenExceptionMatches(exception, PyExc_NotImplementedError)) {

In this case, the errors messages seems to be displayed correctly.

But this needs to be reviewed by @ideasman42 . Furthermore, this doesn't solve the issue to not have the line number in the error if we have a "NonImplemented" error I guess.

python C 3 exception handling code: https://docs.python.org/3/c-api/exceptions.html

I don't know if bpy_traceback.c changed, or if python was updated since 2.79b. In bpy_traceback.c, void python_script_error_jump(...), there is this line: if (exception && PyErr_GivenExceptionMatches(exception, PyExc_SyntaxError)) { What is weird is that an Indentation error is considered as a Syntax error. I'm wondering if instead we should write: if (exception && PyErr_GivenExceptionMatches(exception, PyExc_NotImplementedError)) { In this case, the errors messages seems to be displayed correctly. But this needs to be reviewed by @ideasman42 . Furthermore, this doesn't solve the issue to not have the line number in the error if we have a "NonImplemented" error I guess. python C 3 exception handling code: https://docs.python.org/3/c-api/exceptions.html

Germano Cavalcante commented

2019-07-22 14:18:09 +02:00

Added subscriber: @mano-wii

Campbell Barton was assigned by Germano Cavalcante

2019-07-22 14:18:09 +02:00

Germano Cavalcante commented

2019-07-22 14:18:09 +02:00

It seems that this can even result in crash.

Campbell Barton was unassigned by Dalai Felinto

2019-12-23 16:33:40 +01:00

Richard Antalik commented

2020-01-07 19:22:16 +01:00