highlighted wireframe in sculpt mode
Closed, ResolvedPublicBUG
Actions

Description

System Information
Operating system: Windows 10
Graphics card: nvidia 1060 Ti

Blender Version
2.8 RC2
Short description of error
If you are in sculpt mode with the wireframe overlay active and create a shape key or add a modifier, the mesh becomes highlighted which is not convenient in sculpt mode.

Exact steps for others to reproduce the error
-Add UV Sphere
-Sculpt mode
-Activate wireframe overlay
-Add a shapekey or a modifier like Subdivision Surface

Revisions and Commits

rB Blender
	rB162cb7432030 Fix T67305: Sculptmode Wireframe Coloring

Related Objects

Mentioned In: T67303: mask visibility in sculpt mode using shape keys

Event Timeline

Daniele Viagi (d.viagi) created this task.Jul 20 2019, 11:10 AM

I confirm. Same thing happens on ubuntu 18.04 nvidia titan black.

ronan ducluzeau (zeauro) mentioned this in T67303: mask visibility in sculpt mode using shape keys.Jul 20 2019, 5:06 PM

Basically the BKE_sculptsession_use_pbvh_draw(ob, draw_ctx->v3d) returns false in these cases.

If DRW_object_use_pbvh_drawing returns true, then the modifier isn't visible. This should do the trick for this case.

diff --git a/source/blender/draw/modes/overlay_mode.c b/source/blender/draw/modes/overlay_mode.c
index a5b1133abf4..b9048b4bed4 100644
--- a/source/blender/draw/modes/overlay_mode.c
+++ b/source/blender/draw/modes/overlay_mode.c
@@ -405,7 +405,7 @@ static void overlay_cache_populate(void *vedata, Object *ob)
       const bool is_wire = (ob->dt < OB_SOLID);
       const bool is_xray = (ob->dtx & OB_DRAWXRAY);
       const bool use_coloring = (pd->show_overlays && !is_edit_mode && !use_sculpt_pbvh &&
-                                 !has_edit_mesh_cage);
+                                 !has_edit_mesh_cage && ob->mode != OB_MODE_SCULPT);
       DRWShadingGroup *shgrp = NULL;

       struct GPUBatch *geom;