highlighted wireframe in sculpt mode #67305

New Issue

Daniele Viagi · 2019-07-20T11:10:55+02:00

Daniele Viagi commented

2019-07-20 11:10:55 +02:00

System Information
Operating system: Windows 10
Graphics card: nvidia 1060 Ti

Blender Version
2.8 RC2
Short description of error
If you are in sculpt mode with the wireframe overlay active and create a shape key or add a modifier, the mesh becomes highlighted which is not convenient in sculpt mode.

Exact steps for others to reproduce the error

Add UV Sphere
Sculpt mode
Activate wireframe overlay
Add a shapekey or a modifier like Subdivision Surface

**System Information** Operating system: Windows 10 Graphics card: nvidia 1060 Ti **Blender Version** 2.8 RC2 **Short description of error** If you are in sculpt mode with the wireframe overlay active and create a shape key or add a modifier, the mesh becomes highlighted which is not convenient in sculpt mode. **Exact steps for others to reproduce the error** - Add UV Sphere - Sculpt mode - Activate wireframe overlay - Add a shapekey or a modifier like Subdivision Surface

Daniele Viagi commented

2019-07-20 11:10:55 +02:00

Added subscriber: @DanieleViagi

ronan ducluzeau commented

2019-07-20 16:51:42 +02:00

Added subscriber: @zeauro

ronan ducluzeau commented

2019-07-20 16:51:42 +02:00

I confirm. Same thing happens on ubuntu 18.04 nvidia titan black.

Germano Cavalcante commented

2019-07-22 19:16:10 +02:00

Added subscriber: @mano-wii

Clément Foucault was assigned by Germano Cavalcante

2019-07-22 19:16:10 +02:00

Germano Cavalcante commented

2019-07-22 19:16:10 +02:00

Basically the BKE_sculptsession_use_pbvh_draw(ob, draw_ctx->v3d) returns false in these cases.

Basically the `BKE_sculptsession_use_pbvh_draw(ob, draw_ctx->v3d)` returns `false` in these cases.

matc commented

2019-07-28 11:32:34 +02:00

Added subscriber: @matc

matc commented

2019-07-28 11:32:34 +02:00

If DRW_object_use_pbvh_drawing returns true, then the modifier isn't visible. This should do the trick for this case.

diff --git a/source/blender/draw/modes/overlay_mode.c b/source/blender/draw/modes/overlay_mode.c
index a5b1133abf4..b9048b4bed4 100644
--- a/source/blender/draw/modes/overlay_mode.c
+++ b/source/blender/draw/modes/overlay_mode.c
@@ -405,7 +405,7 @@ static void overlay_cache_populate(void *vedata, Object *ob)
       const bool is_wire = (ob->dt < OB_SOLID);
       const bool is_xray = (ob->dtx & OB_DRAWXRAY);
       const bool use_coloring = (pd->show_overlays && !is_edit_mode && !use_sculpt_pbvh &&
-                                 !has_edit_mesh_cage);
+                                 !has_edit_mesh_cage && ob->mode != OB_MODE_SCULPT);
       DRWShadingGroup *shgrp = NULL;

       struct GPUBatch *geom;

If DRW_object_use_pbvh_drawing returns true, then the modifier isn't visible. This should do the trick for this case. ``` diff --git a/source/blender/draw/modes/overlay_mode.c b/source/blender/draw/modes/overlay_mode.c index a5b1133abf4..b9048b4bed4 100644 --- a/source/blender/draw/modes/overlay_mode.c +++ b/source/blender/draw/modes/overlay_mode.c @@ -405,7 +405,7 @@ static void overlay_cache_populate(void *vedata, Object *ob) const bool is_wire = (ob->dt < OB_SOLID); const bool is_xray = (ob->dtx & OB_DRAWXRAY); const bool use_coloring = (pd->show_overlays && !is_edit_mode && !use_sculpt_pbvh && - !has_edit_mesh_cage); + !has_edit_mesh_cage && ob->mode != OB_MODE_SCULPT); DRWShadingGroup *shgrp = NULL; struct GPUBatch *geom; ```

Clément Foucault was unassigned by Dalai Felinto

2019-12-23 16:33:39 +01:00

Dalai Felinto commented

2019-12-23 16:33:39 +01:00

Added subscriber: @fclem

Jeroen Bakker self-assigned this 2020-01-10 13:31:02 +01:00

blender-admin commented

2020-01-13 12:46:54 +01:00

This issue was referenced by 162cb74320

This issue was referenced by 162cb74320303e91da28f103d0f1cd47442946af

Jeroen Bakker commented

2020-01-13 12:58:14 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Jeroen Bakker closed this issue

2020-01-13 12:58:14 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

highlighted wireframe in sculpt mode #67305