Background images ignore View transform
Closed, ResolvedPublicKNOWN ISSUE
Actions

Assigned To

Authored By

	Sergey Sharybin (sergey)
	Jul 28 2019, 12:28 PM

Description

System Information
Operating system: Darwin-18.7.0-x86_64-i386-64bit 64 Bits
Graphics card: Intel(R) Iris(TM) Plus Graphics 655 Intel Inc. 4.1 INTEL-12.10.12

Blender Version
Broken: version: 2.80 (sub 75), branch: master, commit date: 2019-07-28 07:53, hash: rB233f78c01746
Worked: (optional)

Short description of error
View transform is ignored for both images and movie clips used as a background images in the viewport.

Ideally image will follow its "View as Render", and movie clip probably should just always respect view transform, similar to what's happening in the Clip Editor.

Exact steps for others to reproduce the error
Open attached file and see the difference between how texture on a cube is color managed and how is the background image is not.

Note that changes to color space might not be immediately visible in the viewport due to T66872 (which is a sepaarte root of the issue, and i'll fix that).

colorspace_example.blend165 KBDownload

mango.exr978 KBDownload

Revisions and Commits

rB Blender
	D7067	rB3ffa0452af9a Fix T67832: Camera Background Images View Transform

Related Objects

Mentioned In: T74565: Incorrect redraw state when mouse moves between movie clip editors
T69546: Tag or clear 2.81 Milestone Tasks
T69103: Motion Tracking Module
T68926: Color Management Improvements
Mentioned Here: T65347: Unify overlay engines
T66872: Changing the Colorspace settings of a Movieclip is not properly updating Camera Background Images

Event Timeline

Sergey Sharybin (sergey) created this task.Jul 28 2019, 12:28 PM

@Brecht Van Lommel (brecht), on a more technical note i've looked into gpu_texture_create_from_ibuf which is used by the background images, but it is not really clear to me how view transform fits there. Linearize the result of view transform, and apply sRGB transform in there? Or separate split the background image and make them always be in display space?

As discussed, this is a consequence of the current design and similar to 2.7. Background images are drawn as overlays, and those are drawn without view transform.

The solution would probably be to either pre-transform the image on the CPU, or the change the overlay background image shader to optionally included a view transform. This would be based on the View as Render setting, with the goal of matching the image in the image editor and 3D viewport.

Philipp Oeser (lichtwerk) added a project: GPU / Viewport.Aug 21 2019, 9:03 PM

Sam Van Hulle (sam_vh) mentioned this in T68926: Color Management Improvements.Aug 22 2019, 3:12 PM

Sebastian Koenig (sebastian_k) mentioned this in T69103: Motion Tracking Module.Aug 23 2019, 9:57 PM

Dalai Felinto (dfelinto) mentioned this in T69546: Tag or clear 2.81 Milestone Tasks.Sep 5 2019, 5:25 PM

Dalai Felinto (dfelinto) edited projects, added BF Blender (2.81); removed BF Blender.Sep 5 2019, 8:48 PM

Jeroen Bakker (jbakker) added a subscriber: Jeroen Bakker (jbakker).Nov 4 2019, 10:12 AM

Wouldn't mind take a look on this task, after the T65347: Unify overlay engines that is currently in development. This task is somewhat related as it is hard to keep track of the loose changes.

@Jeroen Bakker (jbakker), be my guest to pick it up, you'll be more familiar with the draw manager thingamajig anyway :)

Jeroen Bakker (jbakker) edited projects, added BF Blender (2.82); removed BF Blender (2.81).Nov 4 2019, 10:27 AM

Julien Leménicier (mistajuliax) awarded a token.Dec 7 2019, 3:26 PM

Julien Leménicier (mistajuliax) added a subscriber: Julien Leménicier (mistajuliax).

Dalai Felinto (dfelinto) removed Sergey Sharybin (sergey) as the assignee of this task.Dec 23 2019, 4:33 PM

Dalai Felinto (dfelinto) added a project: Tracker Curfew.

It is actually a todo as it wasn't designed this way.

This is marked with the 2.82 milestone. If no fix is planned for that release, please move it to 2.83 or untag it from a specific milestone.

Ping, is this for 2.82 or not?

Ow, was too busy with the tracker curfew. Will set it to 2.83. Change is isolated, but would not want to add this at the last moment.

Brecht Van Lommel (brecht) moved this task from Backlog to bcon2: Features on the BF Blender (2.83) board.Feb 4 2020, 3:17 PM

Jeroen Bakker (jbakker) triaged this task as High priority.Mar 3 2020, 4:30 PM

Users are reporting performance issues with large files. It is not sure this ticket will improve it, but we might want to check on it as it is most likely related to color management performance.
It could also be the case that the viewport color management improvements in b283 has reduced this. When the performance is still below expected we should create a new ticket to solve this.

Francesco Siddi (fsiddi) added a subscriber: Francesco Siddi (fsiddi).Mar 4 2020, 4:44 PM

Jeroen Bakker (jbakker) mentioned this in T74565: Incorrect redraw state when mouse moves between movie clip editors.Mar 9 2020, 9:31 AM

Jeroen Bakker (jbakker) added a revision: D7067: Fix T67832: Camera Background Images View Transform.Mar 9 2020, 12:32 PM

Jose (Dogway) added a subscriber: Jose (Dogway).Mar 9 2020, 7:28 PM

Nathan Letwory (jesterking) moved this task from bcon2: Features to bcon3: Bugs on the BF Blender (2.83) board.Apr 20 2020, 8:23 AM

Nathan Letwory (jesterking) edited projects, added BF Blender (2.90); removed BF Blender (2.83).

Jeroen Bakker (jbakker) lowered the priority of this task from High to Normal.Apr 20 2020, 8:25 AM

Brecht Van Lommel (brecht) merged a task: T76188: Camera Background Images wrong Display with OCIO.Apr 28 2020, 4:13 PM

Brecht Van Lommel (brecht) added a subscriber: Hartmut Nörenberg (hartworx).

Clément Foucault (fclem) edited projects, added EEVEE & Viewport; removed GPU / Viewport.Jun 19 2020, 10:23 PM

Clément Foucault (fclem) moved this task from Backlog to Long-Term on the EEVEE & Viewport board.Jul 1 2020, 7:27 PM

Jeroen Bakker (jbakker) changed the subtype of this task from "To Do" to "Known Issue".Aug 18 2020, 2:28 PM