Using "a" hotkey in nested collapsible menus only affects the parent menu #68317

Closed
opened 2019-08-06 16:21:02 +02:00 by Danny McGrath · 11 comments
Member

Blender 2.80 release

In this screenshot:
ac569b9b81ee5b900b06c0aa3e84064dc85525a1.png

If you try to use the "a" key to expand and collapse the menus, it works fine, but not in sub menus. Seems like a bit of a design bug? Originally discussed here .

Blender 2.80 release In this screenshot: ![ac569b9b81ee5b900b06c0aa3e84064dc85525a1.png](https://archive.blender.org/developer/F7651700/ac569b9b81ee5b900b06c0aa3e84064dc85525a1.png) If you try to use the "a" key to expand and collapse the menus, it works fine, but not in sub menus. Seems like a bit of a design bug? Originally discussed [here ](https://devtalk.blender.org/t/uing-a-hotkey-in-nested-collapsible-menus/8795).
Author
Member

Added subscriber: @dmcgrath

Added subscriber: @dmcgrath

Added subscribers: @brecht, @WilliamReynish

Added subscribers: @brecht, @WilliamReynish
Brecht Van Lommel was assigned by William Reynish 2019-08-06 18:26:05 +02:00

@brecht a small bug in sub-panels it seems. Feel free to re-assign as you wish.

@brecht a small bug in sub-panels it seems. Feel free to re-assign as you wish.
Brecht Van Lommel removed their assignment 2019-08-07 04:22:00 +02:00

We don't usually assign low priority bugs to anyone.

We don't usually assign low priority bugs to anyone.

Added subscriber: @pedroreis.ad

Added subscriber: @pedroreis.ad

I have a question regarding this, about what would be the best behaviour for the end user, assuming that all sub-panels would correctly open when 'a' is pressed.

If I click 'a' on a sub-panel that is already opened, should it only close that sub-panel, or should it close the entire panel?

In my opinion as an user, if I clicked 'a' then I wanted everything to open up, or everything to close down, regardless of whether I clicked on a sub-panel or not. Currently, if I have an open panel, but a closed sub-panel, and I click 'a' on that sub-panel, its state would be toggled, but it would close the entire panel. This means the sub-panel is now open, but on a closed panel, which doesn't seem useful.

What are your opinions on this? I think I can do this task, but I don't know what should be the best solution for the user.

I have a question regarding this, about what would be the best behaviour for the end user, assuming that all sub-panels would correctly open when 'a' is pressed. If I click 'a' on a sub-panel that is already opened, should it only close that sub-panel, or should it close the entire panel? In my opinion as an user, if I clicked 'a' then I wanted everything to open up, or everything to close down, regardless of whether I clicked on a sub-panel or not. Currently, if I have an open panel, but a closed sub-panel, and I click 'a' on that sub-panel, its state would be toggled, but it would close the entire panel. This means the sub-panel is now open, but on a closed panel, which doesn't seem useful. What are your opinions on this? I think I can do this task, but I don't know what should be the best solution for the user.

I've been trying to fix this for a couple of weeks on and off, and it seems like I hit a wall, and I'm having a bit of troubles uncovering how I can go about this.

I intended to minimize at the maximum the amount of code that was being called, and so I had the idea of only calling the ui_handle_panel_header function for the main menu, not the sub-menus, and cascade the collapse or opening to all the children.

However, I need the uiBlock responsible for that panel for that to happen. Unfortunately, even after "ui_handle_panel_header" the inside blocks haven't been "spawned" inside the area, so there's no way to access them.

I thought about simply invoking "panel_activate_state()", with the correct child panel, didn't work. Tried to go through all the ScreenArea in the Screen, go through all the uiBlocks, but it almost looks like they're non existent.

@brecht Can you give me a pointer at where to look at, or maybe indicate me someone who might?

I've been trying to fix this for a couple of weeks on and off, and it seems like I hit a wall, and I'm having a bit of troubles uncovering how I can go about this. I intended to minimize at the maximum the amount of code that was being called, and so I had the idea of only calling the ui_handle_panel_header function for the main menu, not the sub-menus, and cascade the collapse or opening to all the children. However, I need the uiBlock responsible for that panel for that to happen. Unfortunately, even after "ui_handle_panel_header" the inside blocks haven't been "spawned" inside the area, so there's no way to access them. I thought about simply invoking "panel_activate_state()", with the correct child panel, didn't work. Tried to go through all the ScreenArea in the Screen, go through all the uiBlocks, but it almost looks like they're non existent. @brecht Can you give me a pointer at where to look at, or maybe indicate me someone who might?

Added subscriber: @mano-wii

Added subscriber: @mano-wii

This seems to be a task for #63726 (User Interface Module ) and not a bug.

This seems to be a task for #63726 (User Interface Module ) and not a bug.

This issue was referenced by a8766de5d5

This issue was referenced by a8766de5d59be699f47f7daedf8ac35f46e9b2e2
Member

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Hans Goudey self-assigned this 2020-08-27 21:23:21 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
7 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#68317
No description provided.