Grease Pencil: L (key) / cmd z / crash #68414

New Issue

Jadwiga Kowalska · 2019-08-08T16:23:10+02:00

Jadwiga Kowalska commented

2019-08-08 16:23:10 +02:00

hi there

it happens that blender grease pencil crashes regularly, when I'm in drawing modus and press:
l (L Key) - then cmd+z

best
jadi

System Information
Operating system:
Graphics card:

Blender Version
Broken: (example: 2.80, edbf15d3c0, master, 2018-11-28, as found on the splash screen)
Worked: (optional)

Short description of error

Exact steps for others to reproduce the error
Based on the default startup or an attached .blend file (as simple as possible).

hi there it happens that blender grease pencil crashes regularly, when I'm in drawing modus and press: l (L Key) - then cmd+z best jadi **System Information** Operating system: Graphics card: **Blender Version** Broken: (example: 2.80, edbf15d3c044, master, 2018-11-28, as found on the splash screen) Worked: (optional) **Short description of error** **Exact steps for others to reproduce the error** Based on the default startup or an attached .blend file (as simple as possible).

Jadwiga Kowalska commented

2019-08-08 16:23:10 +02:00

Added subscriber: @jedi-kawasaki

Jadwiga Kowalska commented

2019-08-08 16:26:02 +02:00

hi there

it happens that blender grease pencil crashes regularly, when I'm in drawing modus and press:
l (L Key) - then cmd+z

best
jadi

hi there it happens that blender grease pencil crashes regularly, when I'm in drawing modus and press: l (L Key) - then cmd+z best jadi

ChristopherAnderssarian commented

2019-08-08 17:17:28 +02:00

Added subscribers: @antoniov, @ChristopherAnderssarian

ChristopherAnderssarian commented

2019-08-08 17:17:28 +02:00

@antoniov

2D animation
Draw
Hold L and Undo
Crash

@antoniov - 2D animation - Draw - Hold L and Undo - Crash

Antonio Vazquez commented

2019-08-08 17:24:05 +02:00

Added subscriber: @CharlieJolly

Antonio Vazquez commented

2019-08-08 17:24:05 +02:00

@CharlieJolly The error is gpencil_paint.c

    GP_Sculpt_Guide *guide = &p->scene->toolsettings->gp_sculpt.guide;
    if (guide->use_guide) {
      ED_workspace_status_text(```


The guide is NULL.

@CharlieJolly The error is `gpencil_paint.c` ```case GP_PAINTMODE_DRAW: { ``` GP_Sculpt_Guide *guide = &p->scene->toolsettings->gp_sculpt.guide; if (guide->use_guide) { ED_workspace_status_text(``` ``` The guide is NULL.

Charlie Jolly was assigned by Antonio Vazquez

2019-08-08 17:24:38 +02:00

Antonio Vazquez commented

2019-08-08 17:24:38 +02:00

I assign to you. If you don't find the problem let me know.

Antonio Vazquez commented

2019-08-08 17:28:29 +02:00

I have seen after undo, the p has NaN

tGPsdata *p = op->customdata;```


I don't know why. It looks the Undo is running while the modal operator is still running.

@ideasman42 any idea here?

I have seen after undo, the `p` has NaN ```static int gpencil_draw_modal(bContext *C, wmOperator *op, const wmEvent *event) { ``` tGPsdata *p = op->customdata;``` ``` I don't know why. It looks the Undo is running while the modal operator is still running. @ideasman42 any idea here?

Antonio Vazquez commented

2019-08-08 17:29:37 +02:00

Added subscriber: @ideasman42

Philipp Oeser changed title from ~~L (key) / cmd z / crash~~ to Grease Pencil: L (key) / cmd z / crash

2019-08-09 09:43:22 +02:00

Antonio Vazquez commented

2019-08-09 11:08:04 +02:00

Added subscriber: @lichtwerk

Antonio Vazquez commented

2019-08-09 11:08:04 +02:00

@lichtwerk Not sure this problem is only GP. I tested and the problem is the customdata of the operator is corrupted when use Undo. Not sure if this can be a problem for more operators.

@lichtwerk Not sure this problem is only GP. I tested and the problem is the `customdata` of the operator is corrupted when use Undo. Not sure if this can be a problem for more operators.

Charlie Jolly commented

2019-08-09 13:33:25 +02:00

@antoniov gpencil_paint.c has undo function but gpencil_primitive.c doesn't. This might be the cause.

Not sure what OPTYPE_UNDO does in this case.

@antoniov gpencil_paint.c has undo function but gpencil_primitive.c doesn't. This might be the cause. Not sure what OPTYPE_UNDO does in this case.

Antonio Vazquez commented

2019-08-09 15:41:46 +02:00

@CharlieJolly No idea...this was old code done before I enter in GP project. If you can, try your ideas and maybe works.

Charlie Jolly commented

2019-08-09 16:45:36 +02:00

@antoniov I can't get Blender to crash.

Antonio Vazquez commented

2019-08-09 18:18:46 +02:00

@CharlieJolly For me fails always.

Open 2D template
Draw something
Press L
Press Ctrl+Z
Crash

@CharlieJolly For me fails always. 1) Open 2D template 2) Draw something 3) Press `L` 4) Press `Ctrl+Z` 5) Crash

Antonio Vazquez commented

2019-08-10 10:42:07 +02:00

@CharlieJolly Proposed fix:

index 06ff0e744b9..894fb6eced4 100644
    - a/source/blender/editors/gpencil/gpencil_paint.c
+++ b/source/blender/editors/gpencil/gpencil_paint.c
@@ -3460,12 +3460,18 @@ static int gpencil_draw_modal(bContext *C, wmOperator *op, const wmEvent *event)

/* We don't pass on key events, GP is used with key-modifiers -

    * prevents Dkey to insert drivers. */

if (ISKEYBOARD(event->type)) {

- if (ELEM(event->type, LEFTARROWKEY, DOWNARROWKEY, RIGHTARROWKEY, UPARROWKEY, ZKEY)) {
+    if (ELEM(event->type, LEFTARROWKEY, DOWNARROWKEY, RIGHTARROWKEY, UPARROWKEY)) {

 /* allow some keys:

        *   - for frame changing [#33412]
        *   - for undo (during sketching sessions)
        */

}

+    else if (event->type == ZKEY) {
+      if (event->ctrl) {
+        p->status = GP_STATUS_DONE;
+        estate = OPERATOR_FINISHED;
+      }
+    }

else if (ELEM(event->type, PAD0, PAD1, PAD2, PAD3, PAD4, PAD5, PAD6, PAD7, PAD8, PAD9)) {
/* allow numpad keys so that camera/view manipulations can still take place

        * - PAD0 in particular is really important for Grease Pencil drawing,

@CharlieJolly Proposed fix: ```diff --git a/source/blender/editors/gpencil/gpencil_paint.c b/source/blender/editors/gpencil/gpencil_paint.c index 06ff0e744b9..894fb6eced4 100644 - a/source/blender/editors/gpencil/gpencil_paint.c +++ b/source/blender/editors/gpencil/gpencil_paint.c @@ -3460,12 +3460,18 @@ static int gpencil_draw_modal(bContext *C, wmOperator *op, const wmEvent *event) ``` /* We don't pass on key events, GP is used with key-modifiers - ``` * prevents Dkey to insert drivers. */ ``` if (ISKEYBOARD(event->type)) { ``` - if (ELEM(event->type, LEFTARROWKEY, DOWNARROWKEY, RIGHTARROWKEY, UPARROWKEY, ZKEY)) { + if (ELEM(event->type, LEFTARROWKEY, DOWNARROWKEY, RIGHTARROWKEY, UPARROWKEY)) { ``` /* allow some keys: ``` * - for frame changing [#33412] * - for undo (during sketching sessions) */ ``` } ``` + else if (event->type == ZKEY) { + if (event->ctrl) { + p->status = GP_STATUS_DONE; + estate = OPERATOR_FINISHED; + } + } ``` else if (ELEM(event->type, PAD0, PAD1, PAD2, PAD3, PAD4, PAD5, PAD6, PAD7, PAD8, PAD9)) { /* allow numpad keys so that camera/view manipulations can still take place ``` * - PAD0 in particular is really important for Grease Pencil drawing, ```

blender-admin commented

2019-08-10 10:44:44 +02:00

This issue was referenced by b99c616b9b

This issue was referenced by b99c616b9bd6218e18c6ecf13558b4a2a756d294

Charlie Jolly commented

2019-08-10 15:44:48 +02:00

@antoniov I've managed to finally reproduce the bug and your fix works.

I can commit the fix under my name but might be better for you to commit as it is your fix!

@antoniov I've managed to finally reproduce the bug and your fix works. I can commit the fix under my name but might be better for you to commit as it is your fix!

Charlie Jolly was unassigned by Antonio Vazquez

2019-08-10 15:59:44 +02:00

Antonio Vazquez self-assigned this 2019-08-10 15:59:44 +02:00

Antonio Vazquez commented

2019-08-10 16:05:03 +02:00

Changed status from 'Open' to: 'Resolved'

Antonio Vazquez closed this issue

2019-08-10 16:05:03 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Grease Pencil: L (key) / cmd z / crash #68414