Image Editor: Enable Rotation of the canvas #68461

Open
opened 2019-08-09 15:44:23 +02:00 by Jeroen Bakker · 7 comments
Member
  • currently we have the ofs and zoom. we should add an angle. IMO we should store this internally as a matrix so we can use this for drawing. Check stabmat and unistabmat from SpaceClip
  • migrate all operations to work on view matrix.

Current implementation it is hard to implement as the image and overlays are drawn in with different matrices. I would suggest to use multiple transformation spaces so we can rotate in the current transformation space.

Seems it is better to first migrate to the draw manager as so we can do mayor refactorings at once... Still this project seems to become large, when we want to do this in a maintainable way.

* currently we have the ofs and zoom. we should add an angle. IMO we should store this internally as a matrix so we can use this for drawing. Check `stabmat` and `unistabmat` from `SpaceClip` * migrate all operations to work on view matrix. Current implementation it is hard to implement as the image and overlays are drawn in with different matrices. I would suggest to use multiple transformation spaces so we can rotate in the current transformation space. Seems it is better to first migrate to the draw manager as so we can do mayor refactorings at once... Still this project seems to become large, when we want to do this in a maintainable way.
Jeroen Bakker self-assigned this 2019-08-09 15:44:23 +02:00
Author
Member

Added subscriber: @Jeroen-Bakker

Added subscriber: @Jeroen-Bakker

Added subscribers: @PabloDobarro, @ThinkingPolygons

Added subscribers: @PabloDobarro, @ThinkingPolygons

Yo @PabloDobarro isn't this that feature you already experimented with?
https://twitter.com/pablodp606/status/1146063560499318784
WBc_zdVkA838RORx.mp4
It died?

Yo @PabloDobarro isn't this that feature you already experimented with? https://twitter.com/pablodp606/status/1146063560499318784 [WBc_zdVkA838RORx.mp4](https://archive.blender.org/developer/F7656382/WBc_zdVkA838RORx.mp4) It died?
Author
Member

@ThinkingPolygons I discussed it with @pablodp606. His approach was only the rotational of the images and missed many things. All tools inside the Image/UV editor needs to be adjusted to work with a rotated canvas for example. The outcome was that I would redo the feature so it will be well maintained.

@ThinkingPolygons I discussed it with @pablodp606. His approach was only the rotational of the images and missed many things. All tools inside the Image/UV editor needs to be adjusted to work with a rotated canvas for example. The outcome was that I would redo the feature so it will be well maintained.

Thanks for clearing things out. ?

Thanks for clearing things out. ?

Added subscriber: @ZexMaxwell

Added subscriber: @ZexMaxwell

I can assist with testing. I'm currently working in the image editor with my graphics tablet and would like to use this feature so I dont have to twist my wrist or physically move an expensive kamvos.

I can assist with testing. I'm currently working in the image editor with my graphics tablet and would like to use this feature so I dont have to twist my wrist or physically move an expensive kamvos.
Jeroen Bakker removed their assignment 2022-02-14 15:47:33 +01:00
Julien Kaspar added this to the Sculpt, Paint & Texture project 2023-02-08 10:48:53 +01:00
Philipp Oeser removed the
Interest
Sculpt, Paint & Texture
label 2023-02-10 09:12:49 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#68461
No description provided.