Page MenuHome

Particle Edit Mode Hair vertex doesn't follow vertex theme color ( non selected and selected )
Closed, ResolvedPublicBUG

Description

System Information
Operating system: Windows-10-10.0.17763 64 Bits
Graphics card: GeForce GTX 970/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 417.35

Blender Version
Broken: version: 2.81 (sub 2), branch: master, commit date: 2019-08-16 18:51, hash: rBe8ffe25eb111
Worked: (optional)

Short description of error
Changing vertex theme color on particle edit mode Hair will not reflect on 3D Viewport. It relfects on mesh edit mode though.
I also tried on 2.80 official build same problem. But It's fine in 2.79.


Exact steps for others to reproduce the error
01. Give default Cube hair particle system
02. Change the mode to Particle Edit mode
03. Press 2 to switch to Point
04. Open Preferences / Theme / 3D View. Find Vertex and change the color will not changing the point color

[Based on the default startup or an attached .blend file (as simple as possible)]

Event Timeline

Philipp Oeser (lichtwerk) lowered the priority of this task from 90 to 50.Aug 19 2019, 3:14 PM

Can confirm, havent checked code but selected seems to (falsely) follow Edge Select theme color...

Philipp Oeser (lichtwerk) triaged this task as Low priority.Fri, Jan 31, 1:05 PM
Philipp Oeser (lichtwerk) changed the subtype of this task from "Report" to "Bug".

Not sure anymore if we should keep this open.

  • Atm., it uses the TH_EDGE_SELECT / colorVertexSelect (as stated in the previous comment), true.
  • Atm. it interpolates the strand in the shader (two shaders here: strand and point, both use TH_EDGE_SELECT, doesnt make a distinction between the hair key and the segments inbetween)
  • I am not sure if it makes sense to have a distinction here (to me, a separate color for keys and segments would not make a lot of sense, you are only ever interacting with keys, not segments -- selection, grooming, etc.)
  • If we stick with one color, which one is better? TH_EDGE_SELECT (because hair is such a long "edge") or TH_VERTEX_SELECT (because you are mainly interacting with hair keys / verts)?

Personally, I would go with TH_VERTEX_SELECT, like 2.79 did.

Sidenote:

  • CacheEditrPathsIterData and PTCacheEdit have sel_col and nosel_col, to me it looks like these are not used and could go?

CC @Clément Foucault (fclem) , @William Reynish (billreynish)