Graph Editor: Curve channel colour #68972

Closed
opened 2019-08-21 15:06:50 +02:00 by Sybren A. Stüvel · 15 comments

Problem: the curve colour is shown in the same button as the visibility eye. Since the eye is drawn in white, this can make it hard to see when the curve colour is bright.

image.png

Proposal: show the curve colour in a separate little strip on the side, and put the visibility button next to it. Some examples:

image.png image.png

Note that it's important to keep the colour well-visible; moving the eye icon away from it shouldn't detriment from the visibility of the colour.

Problem: the curve colour is shown in the same button as the visibility eye. Since the eye is drawn in white, this can make it hard to see when the curve colour is bright. ![image.png](https://archive.blender.org/developer/F7680293/image.png) **Proposal**: show the curve colour in a separate little strip on the side, and put the visibility button next to it. Some examples: ![image.png](https://archive.blender.org/developer/F7680332/image.png) ![image.png](https://archive.blender.org/developer/F7680584/image.png) Note that it's important to keep the colour well-visible; moving the eye icon away from it shouldn't detriment from the visibility of the colour.
Author
Member
Added subscribers: @dr.sybren, @Hjalti, @NachoConesa, @PabloFournier
Pablo Vazquez was assigned by Sybren A. Stüvel 2019-08-21 16:42:16 +02:00
Author
Member

Added subscriber: @WilliamReynish

Added subscriber: @WilliamReynish

Added subscriber: @item412

Added subscriber: @item412

Added subscriber: @seviscache

Added subscriber: @seviscache

Added subscriber: @L0Lock

Added subscriber: @L0Lock

Why not coloring the text instead? It doesn't get in the way of the icons, doesn't require to add a little strip on the side, and IMHO it would be clearer since you would "read" right away the color and the transform type instead of needing to go find the strip on the side.

Here's an example from Maya:

image.png

Why not coloring the text instead? It doesn't get in the way of the icons, doesn't require to add a little strip on the side, and IMHO it would be clearer since you would "read" right away the color and the transform type instead of needing to go find the strip on the side. Here's an example from Maya: ![image.png](https://archive.blender.org/developer/F7773198/image.png)
Author
Member

In #68972#782479, @L0Lock wrote:
Why not coloring the text instead?

Because there are more colours than just R/G/B for X/Y/Z, and it will be very hard to have coloured text work with different themes. It'll be very hard to pick channel colours that are readable on both light and dark backgrounds.

> In #68972#782479, @L0Lock wrote: > Why not coloring the text instead? Because there are more colours than just R/G/B for X/Y/Z, and it will be very hard to have coloured text work with different themes. It'll be very hard to pick channel colours that are readable on both light and dark backgrounds.

I consider that the proposals should respect the design scheme for the interface as in the outliner all the icons to the right, hierarchy line and alternate rows

The curve color does not represent an axis so it may be far from the text X, Y and Z

The axes can be grouped using the hierarchy

Default Dark theme
graph_dark_hierarchy.png

Without "Show Group Colors"
graph_dark_hierarchy_2.png

I consider that the proposals should respect the design scheme for the interface as in the outliner all the icons to the right, hierarchy line and alternate rows The curve color does not represent an axis so it may be far from the text X, Y and Z The axes can be grouped using the hierarchy Default Dark theme ![graph_dark_hierarchy.png](https://archive.blender.org/developer/F7775138/graph_dark_hierarchy.png) Without "Show Group Colors" ![graph_dark_hierarchy_2.png](https://archive.blender.org/developer/F7775142/graph_dark_hierarchy_2.png)

or like this

(probably this option has already been considered)

eyes.jpg

or like this (probably this option has already been considered) ![eyes.jpg](https://archive.blender.org/developer/F7775193/eyes.jpg)

Another color icon is the same drawback as a color text

here another icon distribution more similar to outliner
graph_dark_hierarchy_3.png graph_light_hierarchy_3.png

Another color icon is the same drawback as a color text here another icon distribution more similar to outliner ![graph_dark_hierarchy_3.png](https://archive.blender.org/developer/F7776684/graph_dark_hierarchy_3.png) ![graph_light_hierarchy_3.png](https://archive.blender.org/developer/F7776685/graph_light_hierarchy_3.png)

This comment was removed by @item412

*This comment was removed by @item412*

Added subscriber: @a.monti

Added subscriber: @a.monti

Oh.. @dr.sybren I completely missed this thread, since there was also an older paper cut posted by William in the UI module; following that one I had made a patch that moves the color bands on the right side: https://developer.blender.org/D5882

If having the colors away from the visibility icons is a big problem it can easily be changed to be as in your proposal, like this: Selezione_0077.png

Oh.. @dr.sybren I completely missed this thread, since there was also an older paper cut posted by William in the UI module; following that one I had made a patch that moves the color bands on the right side: https://developer.blender.org/D5882 If having the colors away from the visibility icons is a big problem it can easily be changed to be as in your proposal, like this: ![Selezione_0077.png](https://archive.blender.org/developer/F7776924/Selezione_0077.png)
Author
Member

We should merge #65841 and this task as they pretty much cover the same thing. For the proposed design we (being mostly @NachoConesa and me, with the blessing of @Hjalti and @PabloFournier) used the following rules that we feel are important:

  • The colour should be close to the channel name, so that it's easy to spot the relation between name & colour.
  • The colour should be shown in a large enough area to be well visible (so not just 1 or 2 pixels wide).
  • The eye icon should be well visible, regardless of the channel colour.
  • Any indentation/tree structure should move the labels to the right-hand side as little as possible, to maximise the available space for labels.
We should merge #65841 and this task as they pretty much cover the same thing. For the proposed design we (being mostly @NachoConesa and me, with the blessing of @Hjalti and @PabloFournier) used the following rules that we feel are important: - The colour should be close to the channel name, so that it's easy to spot the relation between name & colour. - The colour should be shown in a large enough area to be well visible (so not just 1 or 2 pixels wide). - The eye icon should be well visible, regardless of the channel colour. - Any indentation/tree structure should move the labels to the right-hand side as little as possible, to maximise the available space for labels.

Closed as duplicate of #68973

Closed as duplicate of #68973
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
6 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#68972
No description provided.