Hair: changing children related settings not updating in particle editmode #69000
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
8 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#69000
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
System Information
Operating system: Windows-10-10.0.17134 64 Bits
Graphics card: GeForce GTX 1050/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 388.73
Blender Version
Broken: version: 2.80 (sub 75), branch: master, commit date: 2019-07-29 14:47, hash:
f6cb5f5449
Worked: (optional)
Short description of error
Hair particle system children won't update/refresh in viewport when editing their parameters
Exact steps for others to reproduce the error
bug1.blend
Added subscriber: @TarkanV
#76506 was marked as duplicate of this issue
#68655 was marked as duplicate of this issue
#71105 was marked as duplicate of this issue
Added subscriber: @lichtwerk
Can confirm
Blender, you keep confusing me.
Did a little digging, and this seems to work:
P1076: #69000 part 1
What is still unclear to me is this:
Even without this, I can see this being done in objectmode:
And this is in particle editmode:
Seems to do the same stuff, no?
Also
BKE_particle_batch_cache_dirty_tag
is called for both... (as part ofBKE_object_eval_uber_data
)But edits just dont seem to come over to the correct ParticleSystems...
(this can go wrong the other way around as well: change children length in PE mode, then in OB mode --> go back to PE mode --> out of sync...)
Anyways, this all seem to be resolved by above patch (it seems)
Same is true for
EffectorWeights
btw. (changing those in particle editmode has no influence at all).Here I am not even sure if these should be displayed in PE mode (2.79 also didnt do this), and doing the correct update in
rna_EffectorWeight_update
might be tricky...This all being said, there might be a better way to do this, or this might not be look at at all (since new particles and hair are already on the way...)
This is the backtracke for deleting a whole particle, then Undo (cannot reproduce an Undo crash if I only delete a particle key...)
There, some ParticleCacheKey is broken...
Hair particle system refresh and crash problemto Hair: changing children related settings not updating in particle editmode (also crash when deleting a particle, then undo)Note the crasher on delete, undo is also fixed by D5755: Fix #68645: Hair Particle Edit - Particle Mirror crash when children are visible in the viewport
Added subscriber: @Floatharr
Added subscriber: @grosgood
@lichtwerk
Ah me. I can't connect the dot(s) from what I'm seeing to your August 21 musings.
Generally, what I'm seeing is AddressSanitizer catching a heap-buffer-overflow at particle.c:2549 in psys_thread_create_path. Just before falling into the abyss:
where:
But:
which offends the AddressSanitizer Gods.
A few lines up, at line 2549 where PTCacheEdit *edit is initialized, and from that pcache,
there seems to be a predicator of the buffer overflow in the bowels of *edit, in that the total point count exceeds the total cache count by one:
psys_thread_create_path() is a busy boy, being called once for each child particle in a head of hair. In the example blend file I'm debugging with (hair_bug.blend), there are four child hair particles, so four threads run: two for parent hair zero, and two for parent hair one. ChildParticle *cpa is set up by the caller, and its parent index reflects this relationship. In this simple setting, two threads will index a parent that isn't in the cache, and stuff hits the fan.
So the obvious thing is out-of-sync structures, and I surmise that your August 21 musings on dependency graphs stems from this out-of-sync-ness, which I trust you've seen in one form or another. I haven't confirmed these guesses, because it is getting late, there are dogs to walk, and tomorrow I am with clients. Ah me.
Blend file and other artifacts attached, which may be useful. Take care.
hair_bug.blend
hair_bug.blend
system-info.txt
**system-info.txt
address_sanitizer.txt
address_sanitizer.txt
Debugger command line, to get dependency graph dumps and single-thread as much as possible.
@lichtwerk
For what it is worth, I applied D5912 & D5914 here - no longer seeing the buffer overwrite or total point count / total cache count disagreement. These look like a go. Gave me useful insights as well; thank you for that. Very much appreciate your work in this dusty old particle code. Thank you for that as well.
Added subscriber: @LucaDiCecca
Hair: changing children related settings not updating in particle editmode (also crash when deleting a particle, then undo)to Hair: changing children related settings not updating in particle editmodeCrasher is resolved, only missing update left for this report, updated report accordingly.
Will have a look at the patch again as it might some tweaking (totally forgot about this one).
Added subscriber: @rwman
Added subscriber: @Vyach
Added subscriber: @TheOldBen
Added subscriber: @aleksijuvani