Segment Fault using Undo for file with several scenes and script #69146

Closed
opened 2019-08-25 13:41:41 +02:00 by Antonio Vazquez · 6 comments

Last source code compiled at 25/08/2019 13:30 CET using VS2019
Windows 10 64 bits
NVIDIA RTX2080TI

The attached file has several scenes and a script that is executed when opening file. The script only register a panel and two operators and it's not doing anything else at start.

To reproduce:

  1. Open attached file.
  2. Change to Storyboarding workspace Tab.
  3. Change Scene to Panel.001
  4. Press Ctrl-Z
  5. Crash in Release mode and Assert in Debug mode.
33: BLI_system_backtrace - 0x7FF61FBC1860
32: id_us_plus_no_lib - 0x7FF61F835990
31: id_refcount_recompute_callback - 0x7FF61F834D70
30: library_foreach_idproperty_ID_link - 0x7FF61F9DBC80
29: library_foreach_idproperty_ID_link - 0x7FF61F9DBC80
28: library_foreach_ID_link - 0x7FF61F9CAAC0
27: BKE_library_foreach_ID_link - 0x7FF61F9C8C80
26: BKE_main_id_refcount_recompute - 0x7FF61F832AB0
25: setup_app_data - 0x7FF623996760
24: setup_app_blend_file_data - 0x7FF623996680
23: BKE_blendfile_read_from_memfile - 0x7FF623994C00
22: BKE_memfile_undo_decode - 0x7FF6239C1000
21: memfile_undosys_step_decode - 0x7FF6214FCEB0
20: undosys_step_decode - 0x7FF62399CA00
19: BKE_undosys_step_undo_with_data_ex - 0x7FF62399B5F0
18: BKE_undosys_step_undo_with_data - 0x7FF62399B570
17: BKE_undosys_step_undo - 0x7FF62399B3A0
16: ed_undo_step_impl - 0x7FF6214FF170
15: ed_undo_step_direction - 0x7FF6214FF0F0
14: ed_undo_exec - 0x7FF6214FEB70
13: wm_operator_invoke - 0x7FF6202C2B30
12: wm_handler_operator_call - 0x7FF6202BE080
BLI_assert failed: D:\MyBlender\BlenderDEV\blender\source\blender\blenkernel\intern\library.c:220, id_us_plus_no_lib(), at 'id->us >= 1'

Test File:
SB_test01.blend

Last source code compiled at 25/08/2019 13:30 CET using VS2019 Windows 10 64 bits NVIDIA RTX2080TI The attached file has several scenes and a script that is executed when opening file. The script only register a panel and two operators and it's not doing anything else at start. To reproduce: 1) Open attached file. 2) Change to Storyboarding workspace Tab. 3) Change Scene to Panel.001 4) Press Ctrl-Z 5) Crash in Release mode and Assert in Debug mode. ``` 33: BLI_system_backtrace - 0x7FF61FBC1860 32: id_us_plus_no_lib - 0x7FF61F835990 31: id_refcount_recompute_callback - 0x7FF61F834D70 30: library_foreach_idproperty_ID_link - 0x7FF61F9DBC80 29: library_foreach_idproperty_ID_link - 0x7FF61F9DBC80 28: library_foreach_ID_link - 0x7FF61F9CAAC0 27: BKE_library_foreach_ID_link - 0x7FF61F9C8C80 26: BKE_main_id_refcount_recompute - 0x7FF61F832AB0 25: setup_app_data - 0x7FF623996760 24: setup_app_blend_file_data - 0x7FF623996680 23: BKE_blendfile_read_from_memfile - 0x7FF623994C00 22: BKE_memfile_undo_decode - 0x7FF6239C1000 21: memfile_undosys_step_decode - 0x7FF6214FCEB0 20: undosys_step_decode - 0x7FF62399CA00 19: BKE_undosys_step_undo_with_data_ex - 0x7FF62399B5F0 18: BKE_undosys_step_undo_with_data - 0x7FF62399B570 17: BKE_undosys_step_undo - 0x7FF62399B3A0 16: ed_undo_step_impl - 0x7FF6214FF170 15: ed_undo_step_direction - 0x7FF6214FF0F0 14: ed_undo_exec - 0x7FF6214FEB70 13: wm_operator_invoke - 0x7FF6202C2B30 12: wm_handler_operator_call - 0x7FF6202BE080 BLI_assert failed: D:\MyBlender\BlenderDEV\blender\source\blender\blenkernel\intern\library.c:220, id_us_plus_no_lib(), at 'id->us >= 1' ``` Test File: [SB_test01.blend](https://archive.blender.org/developer/F7702955/SB_test01.blend)
Author
Member

Added subscriber: @antoniov

Added subscriber: @antoniov
Author
Member

Added subscribers: @mont29, @ideasman42

Added subscribers: @mont29, @ideasman42
Author
Member

@mont29 Not sure if this is for you or @ideasman42

Let me know if you need help or more info.

@mont29 Not sure if this is for you or @ideasman42 Let me know if you need help or more info.
Bastien Montagne self-assigned this 2019-08-26 10:37:04 +02:00

that's a problem with several new features and undo system (which preserves some old datablocks, WM, screens and workspace ones). Looks like we are missing some remappings here, especially in IDProperties ID pointers.

that's a problem with several new features and undo system (which preserves *some* old datablocks, WM, screens and workspace ones). Looks like we are missing some remappings here, especially in IDProperties ID pointers.

This issue was referenced by 16c1b10ed2

This issue was referenced by 16c1b10ed240b930b29f81ae5970a174808f53d7

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#69146
No description provided.