inconsistent handling of filenames derived from image names #69221

New Issue

Gaia Clary · 2019-08-27T17:14:01+02:00

Gaia Clary commented

2019-08-27 17:14:01 +02:00

System Information
Operating system: windows-10
Graphics card: nvidia

Blender Version
Broken: 2.80
Worked:

Short description of error

special characters in image names are treated differently depending on how an image is saved to file. the issue seems to happen on Windows-10 and on MAC. See also related report: https://developer.blender.org/T69064

Exact steps for others to reproduce the error

open the blendfile image_with_special_character.blend
from the top row of the UV editor select image -> save
Check that the filename in the file selector input field is preset to "template:uvgrid.png"
do not change the filename in the file selector box
store the file to the file system
check on the file system that the file is named "template" and has length 0 (actually this is a stream and not a file)

Now do the very same thing except in step 2:

reopen the blend file
from the top row of the UV editor select image -> save as ...

proceed as described above ...

You see that blender now tries to replace the ":" in the filename by "_" as soon as you try to save the file.

I guess the correct behavior is to:

either allow the ":" in the filename and never modify the filename automatically (let the user handle this)
or always take care that no special characters can ever be used for filenames (let blender handle this)

the current mix seems to be not ideal :)

**System Information** Operating system: windows-10 Graphics card: nvidia **Blender Version** Broken: 2.80 Worked: **Short description of error** special characters in image names are treated differently depending on how an image is saved to file. the issue seems to happen on Windows-10 and on MAC. See also related report: https://developer.blender.org/T69064 **Exact steps for others to reproduce the error** - open the blendfile [image_with_special_character.blend](https://archive.blender.org/developer/F7706321/image_with_special_character.blend) - from the top row of the UV editor select image -> save - Check that the filename in the file selector input field is preset to "template:uvgrid.png" - do not change the filename in the file selector box - store the file to the file system - check on the file system that the file is named "template" and has length 0 (actually this is a stream and not a file) Now do the very same thing except in step 2: - reopen the blend file - from the top row of the UV editor select image -> save as ... # proceed as described above ... You see that blender now tries to replace the ":" in the filename by "_" as soon as you try to save the file. I guess the correct behavior is to: - either allow the ":" in the filename and never modify the filename automatically (let the user handle this) - or always take care that no special characters can ever be used for filenames (let blender handle this) the current mix seems to be not ideal :)

Gaia Clary commented

2019-08-27 17:14:01 +02:00

Added subscriber: @GaiaClary

Bastien Montagne was assigned by Campbell Barton

2019-08-27 17:58:47 +02:00

Ray molenkamp commented

2019-08-27 18:14:15 +02:00

Added subscriber: @LazyDodo

Ray molenkamp commented

2019-08-27 18:14:15 +02:00

Just for reference on why windows is just not flat out rejecting filenames with : in it

NTFS supports a thing called alternate data streams

the following is completely legal

f:\test>echo hi > hi.txt
f:\test>echo hello world > hi.txt:hello
f:\test>dir hi.txt
 Volume in drive F is BlahBlah
 Volume Serial Number is 1234-1234

 Directory of f:\test

2019-08-27  10:08 AM                 5 hi.txt

f:\test>more < hi.txt
hi

f:\test>more < h1.txt:hello:$DATA
hello world

however not many apps can deal with this construct and if we just not support it and forbid the : character in a filename, I doubt anyone would miss it.

Just for reference on why windows is just not flat out rejecting filenames with `:` in it NTFS supports a thing called alternate data streams the following is completely legal ``` f:\test>echo hi > hi.txt f:\test>echo hello world > hi.txt:hello f:\test>dir hi.txt Volume in drive F is BlahBlah Volume Serial Number is 1234-1234 Directory of f:\test 2019-08-27 10:08 AM 5 hi.txt f:\test>more < hi.txt hi f:\test>more < h1.txt:hello:$DATA hello world ``` however not many apps can deal with this construct and if we just not support it and forbid the `:` character in a filename, I doubt anyone would miss it.

Stephen Swaney commented

2019-08-27 18:24:05 +02:00

Added subscriber: @StephenSwaney

Stephen Swaney commented

2019-08-27 18:24:05 +02:00

or always take care that no special characters can ever be used for filenames (let blender handle this)

That seems the simplest approach.
A good principle is "Be liberal in what you accept and conservative in what you output", which applied to this case means sanitizing the filenames by replacing weird characters with '_' or such.

> or always take care that no special characters can ever be used for filenames (let blender handle this) That seems the simplest approach. A good principle is "Be liberal in what you accept and conservative in what you output", which applied to this case means sanitizing the filenames by replacing weird characters with '_' or such.

Bastien Montagne commented

2019-08-27 19:20:07 +02:00

No special chars are supposed to be allowed in our filnames... that's just a bug of a missing check somewhere in the code

blender-admin commented

2019-08-28 17:51:40 +02:00

This issue was referenced by 01bd22929f

This issue was referenced by 01bd22929fdb2c7ec0f564faee46c0ad84d11687

Bastien Montagne commented

2019-08-28 17:52:52 +02:00

Changed status from 'Open' to: 'Resolved'

Bastien Montagne closed this issue

2019-08-28 17:52:52 +02:00

Kent Davis commented

2019-08-30 23:29:23 +02:00

Added subscriber: @Kent-Davis

Kent Davis commented

2019-08-30 23:29:23 +02:00

Did not resolve because of "/" and ":" for Macintosh.
https://developer.blender.org/T69064

Did not resolve because of "/" and ":" for Macintosh. https://developer.blender.org/T69064

Kent Davis commented

2019-09-01 02:00:10 +02:00

@mont29 did not resolve yet. Need to fix automatic " : " change to " _ " itself because of Macintosh cause appear " / " on Finder from " : " on Blender 2.81 beta.

Bastien Montagne commented

2019-09-01 12:59:20 +02:00

@Kent-Davis afaik issue reported here has been fixed. If you think it is not, please explain properly your problem, your sentence above make no sense to me. Or open a new report with all expected info, and a precise and complete description of the issue.

@Kent-Davis afaik issue reported here has been fixed. If you think it is not, please explain properly your problem, your sentence above make no sense to me. Or open a new report with all expected info, and a *precise and complete* description of the issue.

Kent Davis commented

2019-09-01 20:01:37 +02:00

This one https://developer.blender.org/T69064
@mont29

This one https://developer.blender.org/T69064 @mont29

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

inconsistent handling of filenames derived from image names #69221

proceed as described above ...