New File Browser no longer automatically appends file extensions #69457

New Issue

William Reynish · 2019-09-03T21:55:57+02:00

William Reynish commented

2019-09-03 21:55:57 +02:00

System Information
Operating system: Darwin-18.6.0-x86_64-i386-64bit 64 Bits
Graphics card: Intel(R) Iris(TM) Plus Graphics 640 Intel Inc. 4.1 INTEL-12.9.22

Blender Version
Broken: version: 2.81 (sub 5), branch: master (modified), commit date: 2019-09-03 17:51, hash: 9e3cd98529
Worked: (optional)

Short description of error
Previously, saving a Blender file would automatically add the file extension when you type in a fine name. This no longer works

Exact steps for others to reproduce the error

New Blender file
File > Save As
type in a name, such as 'bob'
the .blend file extension isn't added (should be 'bob.blend')

**System Information** Operating system: Darwin-18.6.0-x86_64-i386-64bit 64 Bits Graphics card: Intel(R) Iris(TM) Plus Graphics 640 Intel Inc. 4.1 INTEL-12.9.22 **Blender Version** Broken: version: 2.81 (sub 5), branch: master (modified), commit date: 2019-09-03 17:51, hash: `9e3cd98529` Worked: (optional) **Short description of error** Previously, saving a Blender file would automatically add the file extension when you type in a fine name. This no longer works **Exact steps for others to reproduce the error** - New Blender file - File > Save As - type in a name, such as 'bob' - the .blend file extension isn't added (should be 'bob.blend')

William Reynish commented

2019-09-03 21:55:57 +02:00

Added subscriber: @WilliamReynish

Julian Eisel was assigned by William Reynish

2019-09-03 21:56:27 +02:00

Julian Eisel commented

2019-09-04 01:15:22 +02:00

Added subscribers: @mont29, @brecht

Julian Eisel commented

2019-09-04 01:15:22 +02:00

Okay, seems I went a bit fast with removing the old file/path button drawing... That was one of the first changes I did and months later, I forgot there were things to check on still...

By removing the C defined file/path text button drawing, I also (unintentionally) removed:

Auto completion for paths and file names
Additional handling applied on changes, like automatic extension appending (file_filename_enter_handle, file_directory_enter_handle)
Red highlight when the file name already exists

I can think of ways to address these (e.g. auto-complete callbacks for RNA, special handling through RNA set/update callbacks, etc), but some ugly hacks would be required. E.g. file_filename_enter_handle() needs a uiBut to function properly, which we can't pass from .py/RNA.

So right now I'm leaning towards moving the EXECUTE region drawing (buttons for file name, open and cancel) back to C. The file-path button (upper region) could be created through a layout template.
That way we could also bring back the fixed size Open and Cancel buttons, which we wanted anyway.

Any opinion @mont29 & @brecht?

Okay, seems I went a bit fast with removing the old file/path button drawing... That was one of the first changes I did and months later, I forgot there were things to check on still... By removing the C defined file/path text button drawing, I also (unintentionally) removed: * Auto completion for paths and file names * Additional handling applied on changes, like automatic extension appending (`file_filename_enter_handle`, `file_directory_enter_handle`) * Red highlight when the file name already exists I can think of ways to address these (e.g. auto-complete callbacks for RNA, special handling through RNA set/update callbacks, etc), but some ugly hacks would be required. E.g. `file_filename_enter_handle()` needs a `uiBut` to function properly, which we can't pass from .py/RNA. So right now I'm leaning towards moving the `EXECUTE` region drawing (buttons for file name, open and cancel) back to C. The file-path button (upper region) could be created through a layout template. That way we could also bring back the fixed size *Open* and *Cancel* buttons, which we wanted anyway. Any opinion @mont29 & @brecht?

Stephen Swaney commented

2019-09-04 01:24:39 +02:00

Added subscriber: @StephenSwaney

Brecht Van Lommel commented

2019-09-04 13:22:30 +02:00

This is a bad regression and should be fixed as soon as possible, preferably today.

Moving it to a template is fine with me.

This is a bad regression and should be fixed as soon as possible, preferably today. Moving it to a template is fine with me.

Bastien Montagne commented

2019-09-04 13:25:12 +02:00

A template also sounds like a good solution to me…

Julian Eisel commented

2019-09-04 14:20:55 +02:00

The template should work fine for the file-path button.
However for the buttons in the execute region (lower bar) I'd suggest moving them back to C entirely. We wanted to make the Open and Cancel buttons use a fixed width like previously, so they behave better on resize. The layout code doesn't allow me to do it. uiLayout.ui_units_x doesn't work as expected, some careful tweaks to the layout code would be needed and I don't really want to spend time on that.
It's an embarrassingly difficult problem, I've tried multiple things, but I don't see a different solution than having the entire region in C.

So, I'll just bring back C defined drawing code for the lower region, and add a template for the file path if there are no objections.

The template should work fine for the file-path button. However for the buttons in the execute region (lower bar) I'd suggest moving them back to C entirely. We wanted to make the *Open* and *Cancel* buttons use a fixed width like previously, so they behave better on resize. The layout code doesn't allow me to do it. `uiLayout.ui_units_x` doesn't work as expected, some careful tweaks to the layout code would be needed and I don't really want to spend time on that. It's an embarrassingly difficult problem, I've tried multiple things, but I don't see a different solution than having the entire region in C. So, I'll just bring back C defined drawing code for the lower region, and add a template for the file path if there are no objections.

Brecht Van Lommel commented

2019-09-04 15:10:07 +02:00

Fine with me. I don't really care about having any of these buttons in Python, if it's easy why not, but it's not something we are tweaking all the time.

blender-admin commented

2019-09-04 16:21:42 +02:00

This issue was referenced by 45d4c92579

This issue was referenced by 45d4c925799e94c6d442a9a9066af2d3305724e1

Julian Eisel commented

2019-09-04 16:33:59 +02:00

Changed status from 'Open' to: 'Resolved'

Julian Eisel closed this issue

2019-09-04 16:33:59 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

New File Browser no longer automatically appends file extensions #69457