Undo/Adjust Last Operation: vertex and weightpaint operators/strokes undo more then they should (change back any setting changed prior to execution) #69760

Open
opened 2019-09-11 18:36:14 +02:00 by Yegor · 51 comments

System Information
Operating system: Linux-3.10.0-957.10.1.el7.x86_64-x86_64-with-centos-7.6.1810-Core 64 Bits
Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 418.56

Blender Version
Broken: version: 3.1.0 Alpha, branch: master, commit date: 2022-01-27 01:09, hash: a7f7b0b77e
Broken: version: 2.81 (sub 10), branch: master, commit date: 2019-09-10 22:12, hash: 4ce3fbd52a
Worked: 2.79

For reference: this commit 4a08b974f4 is relevant:
From the commit message:
"don't store undo steps for property changes in paint & edit modes."

Short description of error
vertex and weightpaint operators/strokes undo more then they should (change back any setting changed prior to execution)

UPDATE: vertex paint strokes are no longer affected, this was fixed by 575ade22d4 because doing vertex paint strokes now does a SCULPT_undo_push in vpaint_invoke [which leads to BKE_undosys_step_push using sculpt undo instead of plain memfile undo].

Exact steps for others to reproduce the error
There are multiple scenarios from different reports:


  • Enter weight paint
  • Toggle X/Y/Z mirror
  • Draw weight paint
  • Undo the weight paint
  • BUG: X/Y/Z mirror are undone
    This is true for any setting on the mesh (could be paint mask face/vertex selection as well, but also Auto Smooth Normals for example which is best for testing this in other modes).
    Same does not happen in editmode, Texture Paint and Sculptmode. In these modes, changing a setting does not seem to produce an undo push at all.
    In objectmode, changing such setting will create an undo push on its own.

  • Enter weight paint
  • Hide an object (via Outliner)
  • Draw weight paint
  • Undo the weight paint
  • BUG: Hidden object is revealed again

NOTE: this scenario was fixed by 575ade22d4 because doing vertex paint strokes now does a SCULPT_undo_push in vpaint_invoke [which leads to BKE_undosys_step_push using sculpt undo instead of plain memfile undo]

  • Create Suzanne
  • Go to vertex paint mode
  • Enable faces mask
  • Select a couple of faces
  • Paint them with some color
  • Disable faces mask
  • Apply dirty vertex color
  • Go to the last operation dialogue
  • Change the highlight angle property
  • BUG: Mask enables and dirty vertex color applies to the mask
**System Information** Operating system: Linux-3.10.0-957.10.1.el7.x86_64-x86_64-with-centos-7.6.1810-Core 64 Bits Graphics card: GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 418.56 **Blender Version** Broken: version: 3.1.0 Alpha, branch: master, commit date: 2022-01-27 01:09, hash: `a7f7b0b77e` Broken: version: 2.81 (sub 10), branch: master, commit date: 2019-09-10 22:12, hash: `4ce3fbd52a` Worked: 2.79 For reference: this commit 4a08b974f4 is relevant: From the commit message: "don't store undo steps for property changes in paint & edit modes." **Short description of error** vertex and weightpaint operators/strokes undo more then they should (change back any setting changed prior to execution) UPDATE: vertex paint strokes are no longer affected, this was fixed by 575ade22d4de because doing vertex paint strokes now does a SCULPT_undo_push in `vpaint_invoke` [which leads to `BKE_undosys_step_push` using sculpt undo instead of plain memfile undo]. **Exact steps for others to reproduce the error** There are multiple scenarios from different reports: --- - Enter weight paint - Toggle X/Y/Z mirror - Draw weight paint - Undo the weight paint - BUG: X/Y/Z mirror are undone This is true for any setting on the mesh (could be paint mask face/vertex selection as well, but also Auto Smooth Normals for example which is best for testing this in other modes). Same does not happen in editmode, Texture Paint and Sculptmode. In these modes, changing a setting does not seem to produce an undo push at all. In objectmode, changing such setting will create an undo push on its own. --- - Enter weight paint - Hide an object (via Outliner) - Draw weight paint - Undo the weight paint - BUG: Hidden object is revealed again --- NOTE: this scenario was fixed by 575ade22d4de because doing vertex paint strokes now does a SCULPT_undo_push in `vpaint_invoke` [which leads to `BKE_undosys_step_push` using sculpt undo instead of plain memfile undo] - Create Suzanne - Go to vertex paint mode - Enable faces mask - Select a couple of faces - Paint them with some color - Disable faces mask - Apply dirty vertex color - Go to the last operation dialogue - Change the highlight angle property - BUG: Mask enables and dirty vertex color applies to the mask
Author

Added subscriber: @YegorSmirnov

Added subscriber: @YegorSmirnov

#102780 was marked as duplicate of this issue

#102780 was marked as duplicate of this issue

#101112 was marked as duplicate of this issue

#101112 was marked as duplicate of this issue

#100478 was marked as duplicate of this issue

#100478 was marked as duplicate of this issue

#98804 was marked as duplicate of this issue

#98804 was marked as duplicate of this issue

#85012 was marked as duplicate of this issue

#85012 was marked as duplicate of this issue

#85896 was marked as duplicate of this issue

#85896 was marked as duplicate of this issue

#84184 was marked as duplicate of this issue

#84184 was marked as duplicate of this issue

#84226 was marked as duplicate of this issue

#84226 was marked as duplicate of this issue

#81460 was marked as duplicate of this issue

#81460 was marked as duplicate of this issue

#78814 was marked as duplicate of this issue

#78814 was marked as duplicate of this issue

#75362 was marked as duplicate of this issue

#75362 was marked as duplicate of this issue

#73302 was marked as duplicate of this issue

#73302 was marked as duplicate of this issue

#72639 was marked as duplicate of this issue

#72639 was marked as duplicate of this issue

#72984 was marked as duplicate of this issue

#72984 was marked as duplicate of this issue
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

Can confirm, this is true for any vertex or weightpaint operator (it basically also does an Undo of the last changed setting -- which can be totally unrelated).
Looks like this is not true for most editmode operators on first sight.

Pretty sure there was another report for this, cannot find it atm. though.

Can confirm, this is true for any vertex or weightpaint operator (it basically also does an Undo of the last changed setting -- which can be totally unrelated). Looks like this is not true for most editmode operators on first sight. Pretty sure there was another report for this, cannot find it atm. though.
Philipp Oeser changed title from Dirty vertex color applies to a paint mask if you change the highlight angle option afterward and paint mask were applied previously and it's disabled atm to Undo/Adjust Last Operation: vertex and weightpaint operators undo more then they should (change back any setting changed prior to execution) 2019-12-28 21:25:26 +01:00

Added subscriber: @JohnCox-3

Added subscriber: @JohnCox-3

Also happens in Sculpt mode I think.
Is this the report you want?
https://developer.blender.org/T71759

Also happens in Sculpt mode I think. Is this the report you want? https://developer.blender.org/T71759
Added subscribers: @mooncaine, @mano-wii, @TheRedWaxPolice, @rocketman

Added subscriber: @iss

Added subscriber: @iss

Can somebody with this problem try loading factory settings and see if that helps?

Can somebody with this problem try loading factory settings and see if that helps?
Author

In #69760#845519, @iss wrote:
Can somebody with this problem try loading factory settings and see if that helps?

Yes. The same.

> In #69760#845519, @iss wrote: > Can somebody with this problem try loading factory settings and see if that helps? Yes. The same.
Member

Added subscribers: @chiko_moreno, @JacquesLucke, @ronsn

Added subscribers: @chiko_moreno, @JacquesLucke, @ronsn
Member

Added subscriber: @Gillissie

Added subscriber: @Gillissie

Added subscriber: @Interference

Added subscriber: @Interference
Member

Added subscriber: @GabrielMoro

Added subscriber: @GabrielMoro
Member

Added subscriber: @DanielGrauer

Added subscriber: @DanielGrauer

Added subscriber: @Vyach

Added subscriber: @Vyach

Added subscriber: @vasiln

Added subscriber: @vasiln

Added subscribers: @QazQwer, @EAW, @StephenSwaney

Added subscribers: @QazQwer, @EAW, @StephenSwaney
Member

Added subscriber: @PasqualeDeCrescenzo

Added subscriber: @PasqualeDeCrescenzo
Member

Added subscriber: @JerBot

Added subscriber: @JerBot

Can confirm.
As mentioned in newly closed/merged task #84184.
When painting vertex weights: After locking specific vertex groups and then immediately executing a weighting operation (i.e. Smooth or Levels), the vertex weight groups will revert back to unlocked states and yet the weighting operations are still performed, causing unexpected (and sometime unnoticed) damage to the weights that were assumed to be locked (safe).
Example:
weightsUnlock_2020-12-27.mp4

Can confirm. As mentioned in newly closed/merged task #84184. When painting vertex weights: After locking specific vertex groups and then immediately executing a weighting operation (i.e. Smooth or Levels), the vertex weight groups will revert back to unlocked states and yet the weighting operations are still performed, causing unexpected (and sometime unnoticed) damage to the weights that were assumed to be locked (safe). Example: [weightsUnlock_2020-12-27.mp4](https://archive.blender.org/developer/F9532295/weightsUnlock_2020-12-27.mp4)

Added subscriber: @JacobFerrero

Added subscriber: @JacobFerrero

I have observed these three instances that are driving me crazy!

Enter weight paint
Hide an object (via Outliner)
Draw weight paint
Undo the weight paint
BUG: Hidden object is revealed again

Enter weight paint
Change weight/size/strength
Draw weight paint
Undo the weight paint
BUG: brush settings are undone

Enter weight paint
Toggle X/Y/Z mirror
Draw weight paint
Undo the weight paint
BUG: X/Y/Z mirror are undone

I have observed these three instances that are driving me crazy! 1. Enter weight paint Hide an object (via Outliner) Draw weight paint Undo the weight paint BUG: Hidden object is revealed again 2. Enter weight paint Change weight/size/strength Draw weight paint Undo the weight paint BUG: brush settings are undone 3. Enter weight paint Toggle X/Y/Z mirror Draw weight paint Undo the weight paint BUG: X/Y/Z mirror are undone
Member

Added subscriber: @blr-4

Added subscriber: @blr-4

Added subscriber: @usuallyreggie

Added subscriber: @usuallyreggie

Update: It seems that this issue is being caused by having the option in Preferences > Input > Emulate 3 Button Mouse. Turning this off instantly solved the issue for me.

Hope this helps!

Update: It seems that this issue is being caused by having the option in Preferences > Input > Emulate 3 Button Mouse. Turning this off instantly solved the issue for me. Hope this helps!

Added subscriber: @sok0

Added subscriber: @sok0

Emulate 3 Button Mouse did not fix it for me, on or off it's the same issue. If I undo a Paint brush stroke with any non Default brush in the Image Editor then Undo, it automatically switches my brush back to Brush Default unexpectedly.

Emulate 3 Button Mouse did not fix it for me, on or off it's the same issue. If I undo a Paint brush stroke with any non Default brush in the Image Editor then Undo, it automatically switches my brush back to Brush Default unexpectedly.
Philipp Oeser changed title from Undo/Adjust Last Operation: vertex and weightpaint operators undo more then they should (change back any setting changed prior to execution) to Undo/Adjust Last Operation: vertex and weightpaint operators/strokes undo more then they should (change back any setting changed prior to execution) 2022-01-27 18:54:24 +01:00
Member

Added subscribers: @TodorNikolov, @PratikPB2123, @zanqdo, @mont29, @PabloDobarro, @ideasman42

Added subscribers: @TodorNikolov, @PratikPB2123, @zanqdo, @mont29, @PabloDobarro, @ideasman42
Member

Added subscriber: @CreativeDrone

Added subscriber: @CreativeDrone

Added subscriber: @spiraloid-3

Added subscriber: @spiraloid-3
Member

Added subscribers: @TonatiuhdeSanJulian, @OmarEmaraDev

Added subscribers: @TonatiuhdeSanJulian, @OmarEmaraDev
Member

Added subscriber: @euphoreka7

Added subscriber: @euphoreka7
Philipp Oeser removed the
Interest
Animation & Rigging
label 2023-02-09 14:36:37 +01:00
Member

@mont29 : dou you want this as responsibility of the Core module instread?

@mont29 : dou you want this as responsibility of the Core module instread?

@lichtwerk yes, Undo is indeed part of the Core module :(

@lichtwerk yes, Undo is indeed part of the Core module :(
Member

#114016 (comment) is noteworthy

https://projects.blender.org/blender/blender/issues/114016#issuecomment-1050745 is noteworthy

I've been directed to this issue after having #119740 closed as a duplicate. Interestingly, my situation most closely resembles the third scenario of the original post, even though that's the one that's supposedly fixed?

  1. Enter weight paint mode
  2. In the 'weights' menu, select 'smooth'
  3. Change any of the settings in the last operator panel
  4. Suddenly, a different vertex group is being edited (and the smooth operation is being applied to THAT vertex group, rather than the one you tried to operate on)

Notably, the vertex group that gets selected is always one that I'd been working with earlier in the session, so it does seem to be related to undo history?

I've also had it toggle paint mask mode on, if it had been on at some earlier point in the session.

I haven't worked out the exact steps to reproduce this yet; I can't reproduce it on demand in a new document, but it keeps tripping me up during actual work.

This is happening to me in 4.0.2.

I've been directed to this issue after having #119740 closed as a duplicate. Interestingly, my situation most closely resembles the third scenario of the original post, even though that's the one that's supposedly fixed? 1. Enter weight paint mode 2. In the 'weights' menu, select 'smooth' 3. Change any of the settings in the last operator panel 4. Suddenly, a different vertex group is being edited (and the smooth operation is being applied to THAT vertex group, rather than the one you tried to operate on) Notably, the vertex group that gets selected is always one that I'd been working with earlier in the session, so it does seem to be related to undo history? I've also had it toggle paint mask mode on, if it had been on at some earlier point in the session. I haven't worked out the exact steps to reproduce this yet; I can't reproduce it on demand in a new document, but it keeps tripping me up during actual work. This is happening to me in 4.0.2.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
18 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#69760
No description provided.