Sculpt Tools (not brushes) treated like brushes #69786

New Issue

Juanfran Matheu · 2019-09-12T11:02:15+02:00

Juanfran Matheu commented

2019-09-12 11:02:15 +02:00

System Information
Operating system: Windows-10-10.0.18362 64 Bits
Graphics card: Radeon RX 580 Series ATI Technologies Inc. 4.5.13570 Core Profile Context 19.8.1 26.20.13001.29010

Blender Version
Broken: version: 2.81 (sub 10), branch: master, commit date: 2019-09-11 21:31, hash: 1e375ab5a1

Short description of error
If you use any brush and then switch to Mesh Filter or any Transformation Tool, Box Mask.....
the info of the previous brush is still there. Fox example:

You choose the mask brush
Then switch to mesh filter
Mesh filter still has the data of the mask brush and is treated like a mask brush

This is true because if you create some tool or addon that filter some option only for mask brush with

context.tool_settings.sculpt.brush == 'MASK'

or

self.paint_settings(context).brush == 'MASK'  #using UnifiedPaintPanel

when switching to mesh filter or any other mentioned, you still can see those options

This ends up that devs have to make a previous pass to filter all tools that are not brushes and are treated like if they were (before filter by brush type)

if context.workspace.tools.from_space_view3d_mode("SCULPT", create=False).idname == "builtin.mesh_filter":  exclude = True

or filter all brushes by idname of the tool and not by brush type

Probably there's a better way to filter those tools but the matter is they are treated like brushes, not only internally, also visually in the UI... when they aren't

**System Information** Operating system: Windows-10-10.0.18362 64 Bits Graphics card: Radeon RX 580 Series ATI Technologies Inc. 4.5.13570 Core Profile Context 19.8.1 26.20.13001.29010 **Blender Version** Broken: version: 2.81 (sub 10), branch: master, commit date: 2019-09-11 21:31, hash: `1e375ab5a1` **Short description of error** If you use any brush and then switch to Mesh Filter or any Transformation Tool, Box Mask..... the info of the previous brush is still there. Fox example: - You choose the mask brush - Then switch to mesh filter - Mesh filter still has the data of the mask brush and is treated like a mask brush This is true because if you create some tool or addon that filter some option only for mask brush with ``` context.tool_settings.sculpt.brush == 'MASK' ``` or ``` self.paint_settings(context).brush == 'MASK' #using UnifiedPaintPanel ``` when switching to mesh filter or any other mentioned, you still can see those options This ends up that devs have to make a previous pass to filter all **tools that are not brushes and are treated like if they were** (before filter by brush type) ``` if context.workspace.tools.from_space_view3d_mode("SCULPT", create=False).idname == "builtin.mesh_filter": exclude = True ``` or filter all brushes by idname of the tool and not by brush type ![image.png](https://archive.blender.org/developer/F7738720/image.png) Probably there's a better way to filter those tools but the matter is they are treated like brushes, not only internally, also visually in the UI... when they aren't

Juanfran Matheu commented

2019-09-12 11:02:15 +02:00

Added subscriber: @jfmatheu

blender-admin commented

2019-09-12 11:02:15 +02:00

#70111 was marked as duplicate of this issue

Brecht Van Lommel commented

2019-10-03 00:16:30 +02:00

Added subscriber: @capnm

Pablo Dobarro commented

2020-01-09 23:18:02 +01:00

Added subscriber: @PabloDobarro

Pablo Dobarro commented

2020-01-09 23:18:02 +01:00

I would prefer considering this a design task and not a brush. Maybe in the future we want to include some tools that need an active brush at the same time, so I would rather have a solution that fits all areas of Blender (this also happens in other modes) and not the specific case of Sculpt mode and the mesh filter.

Campbell Barton commented

2020-02-12 07:52:52 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Sculpt Tools (not brushes) treated like brushes #69786