Grease pencil slows down vertex painting #70015

Closed
opened 2019-09-18 12:47:59 +02:00 by Brecht Van Lommel · 6 comments

In the default startup .blend, painting on a cube, I see about 10% of time spent freeing grease pencil data.

This makes no sense because there are no grease pencil objects in the scene.

gp_vertex_painting.png

In the default startup .blend, painting on a cube, I see about 10% of time spent freeing grease pencil data. This makes no sense because there are no grease pencil objects in the scene. ![gp_vertex_painting.png](https://archive.blender.org/developer/F7755273/gp_vertex_painting.png)
Author
Owner

Added subscribers: @brecht, @antoniov

Added subscribers: @brecht, @antoniov
Antonio Vazquez self-assigned this 2019-09-18 16:11:12 +02:00
Antonio Vazquez removed their assignment 2019-09-18 16:26:09 +02:00

I have been looking at the code and really is not doing anything, it's a group of DRW_TEXTURE_FREE_SAFE and all textures are NULL except one of 1x1 pixel. The problem here is the GPencil engine is enabled when no GPencil objects are in the scene, so the Engine_init, cache init/populate/finish and draw scene, free is called... and this is to do nothing. This uneeded call is creating the passes and a lot of things that we don't need.

Could be possible add a check in draw manager to not call GPencil engine at all if no GPencil objects in the scene?

I have been looking at the code and really is not doing anything, it's a group of DRW_TEXTURE_FREE_SAFE and all textures are NULL except one of 1x1 pixel. The problem here is the GPencil engine is enabled when no GPencil objects are in the scene, so the Engine_init, cache init/populate/finish and draw scene, free is called... and this is to do nothing. This uneeded call is creating the passes and a lot of things that we don't need. Could be possible add a check in draw manager to not call GPencil engine at all if no GPencil objects in the scene?
Author
Owner

Maybe there is no real overhead from grease pencil and it's just happens to be waiting for the graphics driver there.

But you can move the allocation and freeing of that 1x1 texture to GPENCIL_engine_init and GPENCIL_engine_free I think? No need to do it for every redraw.

Maybe there is no real overhead from grease pencil and it's just happens to be waiting for the graphics driver there. But you can move the allocation and freeing of that 1x1 texture to `GPENCIL_engine_init` and `GPENCIL_engine_free` I think? No need to do it for every redraw.

yes, I will do that.

yes, I will do that.

Proposed change D5845

Proposed change [D5845](https://archive.blender.org/developer/D5845)
Author
Owner

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'
Brecht Van Lommel self-assigned this 2019-09-18 21:11:01 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#70015
No description provided.