volumetric broken, not refresh #70091

New Issue

noki paike · 2019-09-20T04:13:03+02:00

noki paike commented

2019-09-20 04:13:03 +02:00

System Information
Operating system: Windows-10-10.0.17763 64 Bits
Graphics card: AMD Radeon HD 7600M Series ATI Technologies Inc. 4.5.13422 Core Profile Context 0

Blender Version
Broken: version: 2.81 (sub 12), branch: master, commit date: 2019-09-19 20:35, hash: c8df6f2cf9
Worked: (optional)

Short description of error
volumetric broken, not refresh, it is necessary to enter and exit in local mode to update the parameters

only on these gpus, I tried on the intel HD and they work well.

Exact steps for others to reproduce the error
see the gif

**System Information** Operating system: Windows-10-10.0.17763 64 Bits Graphics card: AMD Radeon HD 7600M Series ATI Technologies Inc. 4.5.13422 Core Profile Context 0 **Blender Version** Broken: version: 2.81 (sub 12), branch: master, commit date: 2019-09-19 20:35, hash: `c8df6f2cf9` Worked: (optional) **Short description of error** volumetric broken, not refresh, it is necessary to enter and exit in local mode to update the parameters only on these gpus, I tried on the intel HD and they work well. **Exact steps for others to reproduce the error** see the gif ![volumetrc.gif](https://archive.blender.org/developer/F7759858/volumetrc.gif)

noki paike commented

2019-09-20 04:13:03 +02:00

Added subscriber: @nokipaike

blender-admin commented

2019-09-20 04:13:03 +02:00

#70308 was marked as duplicate of this issue

Jacques Lucke commented

2019-09-20 12:18:21 +02:00

Added subscriber: @JacquesLucke

Jacques Lucke commented

2019-09-20 12:18:21 +02:00

Please provide a minimal example .blend file that allows us to reproduce the issue more easily.

noki paike commented

2019-09-20 12:40:26 +02:00

Added subscriber: @mano-wii

noki paike commented

2019-09-20 12:40:26 +02:00

here is the blend file, it's not really necessary, it happens with any scene, and with both volumetric shaders, it's a bug related to these GPUs.

volumetrics_bug.blend

for those who do a test, @mano-wii ^____^ it should disable the local auto zoom, otherwise is mess and you don't understand what happens.

here is the blend file, it's not really necessary, it happens with any scene, and with both volumetric shaders, it's a bug related to these GPUs. [volumetrics_bug.blend](https://archive.blender.org/developer/F7760597/volumetrics_bug.blend) for those who do a test, @mano-wii ^____^ it should disable the local auto zoom, otherwise is mess and you don't understand what happens. ![Screenshot (174).png](https://archive.blender.org/developer/F7760620/Screenshot__174_.png)

noki paike commented

2019-09-23 01:30:00 +02:00

I checked in blender 2.80 official it worked.

already didn't work before this:
3a08153d7a DRW: Refactor to support draw call batching

bug probably introduced by this:
caf494444c EEVEE: Volume: Speedup: Use Image load store extension

I checked in blender 2.80 official it worked. already didn't work before this: 3a08153d7a84 DRW: Refactor to support draw call batching bug probably introduced by this: caf494444cd7 EEVEE: Volume: Speedup: Use Image load store extension

noki paike commented

2019-09-23 13:55:08 +02:00

I made a comparison video between blender 2.80 and the latest build of 2.81
the samples loop refresh appears to be broken
(the refresh of the first samples, in the video it does it because it is I who press the switch between local and normal view)

volumetric.mp4

I made a comparison video between blender 2.80 and the latest build of 2.81 the samples loop refresh appears to be broken (the refresh of the first samples, in the video it does it because it is I who press the switch between local and normal view) [volumetric.mp4](https://archive.blender.org/developer/F7771956/volumetric.mp4)

Philipp Oeser commented

2019-09-23 14:36:24 +02:00

Added subscribers: @fclem, @lichtwerk

Philipp Oeser commented

2019-09-23 14:36:24 +02:00

CC @fclem

noki paike commented

2019-09-29 01:41:38 +02:00

This comment was removed by @nokipaike

*This comment was removed by @nokipaike*

noki paike commented

2019-09-29 02:09:52 +02:00

I did tests with a nebula file a little more complex, it always has the problem of refreshing, but it seems to work partially.

volume_so_better.mp4

Nebula_ColorNodes.blend

I did tests with a nebula file a little more complex, it always has the problem of refreshing, but it seems to work partially. [volume_so_better.mp4](https://archive.blender.org/developer/F7779093/volume_so_better.mp4) [Nebula_ColorNodes.blend](https://archive.blender.org/developer/F7779092/Nebula_ColorNodes.blend)

Brecht Van Lommel commented

2019-10-02 23:44:29 +02:00

Added subscriber: @brecht

Brecht Van Lommel commented

2019-10-02 23:44:29 +02:00

Changed status from 'Open' to: 'Archived'

Brecht Van Lommel closed this issue

2019-10-02 23:44:29 +02:00

Brecht Van Lommel self-assigned this 2019-10-02 23:44:29 +02:00

Brecht Van Lommel commented

2019-10-02 23:44:29 +02:00

This GPU is not officially supported, so I think this can be closed. Not supported really means that, we should not spend time on it but focus on making the supported GPUs work well.

noki paike commented

2019-10-03 03:45:20 +02:00

@brecht
but come on, what way is this to solve problems,

the volumetrics worked well in this gpu until a few weeks ago of blender 2.81!

close a bug report without even giving it a look at the code
maybe you find out that it is a problem that takes two minutes.

In #70091#788179, @brecht wrote:
This GPU is not officially supported, so I think this can be closed. Not supported really means that, we should not spend time on it but focus on making the supported GPUs work well.

also means that they should not be broken ... don't you think?
if the volumetric had never worked, I could also understand it.

And I'm sure some newer AMD gpu will come out with broken volumetrics more recently ......
Still not many have done extensive checks on volumetric on blender 2.81

@brecht but come on, what way is this to solve problems, the volumetrics worked well in this gpu until a few weeks ago of blender 2.81! close a bug report without even giving it a look at the code maybe you find out that it is a problem that takes two minutes. > In #70091#788179, @brecht wrote: > This GPU is not officially supported, so I think this can be closed. Not supported really means that, we should not spend time on it but focus on making the supported GPUs work well. also means that they should not be broken ... don't you think? if the volumetric had never worked, I could also understand it. And I'm sure some newer AMD gpu will come out with broken volumetrics more recently ...... Still not many have done extensive checks on volumetric on blender 2.81

Brecht Van Lommel commented

2019-10-03 09:36:18 +02:00

also means that they should not be broken ... don't you think?

No, unsupported means we don't spend time on it and things should not be expected to work.

> also means that they should not be broken ... don't you think? No, unsupported means we don't spend time on it and things should not be expected to work.

noki paike commented

2019-10-03 11:04:52 +02:00

They really worked well. especially volumetric.
They worked in blender 2.80, they worked until a couple of weeks ago. Until then, EVERYTHING worked in this gpu.

Of course, workarounds were needed, and now they exist and these work. but you have decided that these GPUs must now work partially.

But oh well, who cares, for a few million users who own these generations of GPUs, they will have to be thrown away. We all order a new GPU. Or rather specify a new laptop in my case if I want to use blender in a worthy way.
Now that you will do when so many other people, especially after blender 2.81 is officially released, and in this gpu everything worked in blender 2.80, will you torpedo them immediately and continuously because this million gpus no longer has a right to a workaround or a bug that is fixed?

You haven't even seen what it this bug, is and you have closed the report.
it's just a refresh loop that doesn't work anymore for some reason.
I even specified the right time when it stopped working.

You have decided to snub it.
Not even low priority bug, directly archiveid.

I apologize, but I'm pissed, put yourself in my shoes ...

They really worked well. especially volumetric. They worked in blender 2.80, they worked until a couple of weeks ago. Until then, EVERYTHING worked in this gpu. Of course, workarounds were needed, and now they exist and these work. but you have decided that these GPUs must now work partially. But oh well, who cares, for a few million users who own these generations of GPUs, they will have to be thrown away. We all order a new GPU. Or rather specify a new laptop in my case if I want to use blender in a worthy way. Now that you will do when so many other people, especially after blender 2.81 is officially released, and in this gpu everything worked in blender 2.80, will you torpedo them immediately and continuously because this million gpus no longer has a right to a workaround or a bug that is fixed? You haven't even seen what it this bug, is and you have closed the report. it's just a refresh loop that doesn't work anymore for some reason. I even specified the right time when it stopped working. You have decided to snub it. Not even low priority bug, directly archiveid. I apologize, but I'm pissed, put yourself in my shoes ...

noki paike commented

2019-10-22 00:21:07 +02:00

@mano-wii sorry if I insist on this, but I think it's not a problem related to volumetrics system ... and I'll explain why ..
Remember when the new eevee batch cache system was implemented, and that the framebuffer didn't update the mesh position on these GPUs? ... it was this bug #69853 which has been successfully solved by you ...

I believe that it is the same problem, but linked to the shading system .. look at this video ...

just click on a new position of the 3d cursor and everything "re-works" but only for that framebuffer, then if I move the objects don't refresh anymore until I reposition the 3d cursor.

refresh.mp4

fishy.mp4

why do we need to position the 3d cursor so that the framebuffer is refreshed?

I think it's due to the fact that this problem is related to the old workaround that is still partially working for some shaders and creates these refresh problems...

so what happens if the old workaround that no longer makes sense to exist were removed altogether?
i think maybe could solve this problem...

this is the nebula file in case you want to do a quick test by simply "turning off the old workaround."
Nebula_ColorNodes.blend

@mano-wii sorry if I insist on this, but I think it's not a problem related to volumetrics system ... and I'll explain why .. Remember when the new eevee batch cache system was implemented, and that the framebuffer didn't update the mesh position on these GPUs? ... it was this bug #69853 **which has been successfully solved by you ...** I believe that it is the same problem, but linked to the shading system .. look at this video ... just click on a new position of the 3d cursor and everything "re-works" but only for that framebuffer, then if I move the objects don't refresh anymore until I reposition the 3d cursor. [refresh.mp4](https://archive.blender.org/developer/F7845067/refresh.mp4) [fishy.mp4](https://archive.blender.org/developer/F7845062/fishy.mp4) why do we need to position the 3d cursor so that the framebuffer is refreshed? I think it's due to the fact that this problem is related to the old workaround that is still partially working for some shaders and creates these refresh problems... so what happens if the old workaround that no longer makes sense to exist were removed altogether? i think maybe could solve this problem... ____ this is the nebula file in case you want to do a quick test by simply "turning off the old workaround." [Nebula_ColorNodes.blend](https://archive.blender.org/developer/F7845075/Nebula_ColorNodes.blend)

Germano Cavalcante commented

2019-10-29 14:48:46 +01:00

I'm not sure where the problem is, but I know this change solves it:

diff --git a/source/blender/draw/engines/eevee/eevee_volumes.c b/source/blender/draw/engines/eevee/eevee_volumes.c
index aaa351a1922..8220c0e9501 100644
--- a/source/blender/draw/engines/eevee/eevee_volumes.c
+++ b/source/blender/draw/engines/eevee/eevee_volumes.c
@@ -41,6 +41,7 @@
 
 - include "eevee_private.h"
 - include "GPU_draw.h"
+#include "GPU_extensions.h"
 - include "GPU_texture.h"
 - include "GPU_material.h"
 
@@ -81,7 +82,9 @@ extern char datatoc_volumetric_integration_frag_glsl[];
 extern char datatoc_volumetric_lib_glsl[];
 extern char datatoc_common_fullscreen_vert_glsl[];
 
-#define USE_VOLUME_OPTI (GLEW_ARB_shader_image_load_store && GLEW_ARB_shading_language_420pack)
+#define USE_VOLUME_OPTI \
+  (GLEW_ARB_shader_image_load_store && GLEW_ARB_shading_language_420pack && \
+   !GPU_crappy_amd_driver())
 
 static void eevee_create_shader_volumes(void)
 {

I'm not sure where the problem is, but I know this change solves it: ``` diff --git a/source/blender/draw/engines/eevee/eevee_volumes.c b/source/blender/draw/engines/eevee/eevee_volumes.c index aaa351a1922..8220c0e9501 100644 --- a/source/blender/draw/engines/eevee/eevee_volumes.c +++ b/source/blender/draw/engines/eevee/eevee_volumes.c @@ -41,6 +41,7 @@ - include "eevee_private.h" - include "GPU_draw.h" +#include "GPU_extensions.h" - include "GPU_texture.h" - include "GPU_material.h" @@ -81,7 +82,9 @@ extern char datatoc_volumetric_integration_frag_glsl[]; extern char datatoc_volumetric_lib_glsl[]; extern char datatoc_common_fullscreen_vert_glsl[]; -#define USE_VOLUME_OPTI (GLEW_ARB_shader_image_load_store && GLEW_ARB_shading_language_420pack) +#define USE_VOLUME_OPTI \ + (GLEW_ARB_shader_image_load_store && GLEW_ARB_shading_language_420pack && \ + !GPU_crappy_amd_driver()) static void eevee_create_shader_volumes(void) { ```

blender-admin commented

2019-10-29 15:10:26 +01:00

This issue was referenced by d0d57f1712

This issue was referenced by d0d57f17121f1649b4347a14769d274204945717

Clément Foucault commented

2019-10-29 15:18:32 +01:00

Changed status from 'Archived' to: 'Resolved'

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

volumetric broken, not refresh #70091