VSE: 'Prefetch frames' causes excessive CPU usage whenever there is animation on a strip (freezes when tweaking animation [Graph Editor, Dopesheet, typing in new values]) #70194

New Issue

Telmo Silva · 2019-09-23T23:30:52+02:00

Telmo Silva commented

2019-09-23 23:30:52 +02:00

System Information
Operating system: Linux-5.2.15-200.fc30.x86_64-x86_64-with-fedora-30-Thirty 64 Bits
Graphics card: Mesa DRI Intel(R) HD Graphics 620 (Kaby Lake GT2) Intel Open Source Technology Center 4.5 (Core Profile) Mesa 19.1.6

Blender Version
Broken: version: 2.81 (sub 12), branch: master, commit date: 2019-09-22 20:38, hash: 52bdf522af
Worked: (optional)

Short description of error
When using the Graph Editor Slider on f-curve with Sequencer "Prefetch Frames" ON, Blender Freezes

Exact steps for others to reproduce the error

Start New Video Editing File
Activate "Prefetch Frames" in the "Sequencer Preview" N-Panel
Create a simple "Animation" with a "Color Strip"
Go to "Graph Editor", menu "View > Show Sliders"
Move the Slider on the animation f-curve -> Freeze

Example File
slider_graphEditor_freeze.blend

**System Information** Operating system: Linux-5.2.15-200.fc30.x86_64-x86_64-with-fedora-30-Thirty 64 Bits Graphics card: Mesa DRI Intel(R) HD Graphics 620 (Kaby Lake GT2) Intel Open Source Technology Center 4.5 (Core Profile) Mesa 19.1.6 **Blender Version** Broken: version: 2.81 (sub 12), branch: master, commit date: 2019-09-22 20:38, hash: `52bdf522af` Worked: (optional) **Short description of error** When using the Graph Editor Slider on f-curve with Sequencer "Prefetch Frames" ON, Blender Freezes **Exact steps for others to reproduce the error** - Start New Video Editing File - Activate "Prefetch Frames" in the "Sequencer Preview" N-Panel - Create a simple "Animation" with a "Color Strip" - Go to "Graph Editor", menu "View > Show Sliders" - Move the Slider on the animation f-curve -> Freeze Example File [slider_graphEditor_freeze.blend](https://archive.blender.org/developer/F7772623/slider_graphEditor_freeze.blend)

Telmo Silva commented

2019-09-23 23:30:52 +02:00

Added subscriber: @nottelmo-4

Philipp Oeser commented

2019-09-24 14:53:45 +02:00

Added subscribers: @iss, @lichtwerk

Philipp Oeser commented

2019-09-24 14:53:45 +02:00

Can confirm the freeze.

This is actually true for all keyframe transforms [be it Graph Editor, Dopesheet, can be sliders, keyframes, tangents...]
Should call BKE_sequencer_prefetch_stop(scene) or similar in the appropriate places in transform code, I guess...

CC @iss

Can confirm the freeze. This is actually true for all keyframe transforms [be it Graph Editor, Dopesheet, can be sliders, keyframes, tangents...] Should call `BKE_sequencer_prefetch_stop(scene)` or similar in the appropriate places in transform code, I guess... CC @iss

Philipp Oeser changed title from ~~[FREEZE] Graph Editor Slider with Prefetch Frames~~ to [FREEZE] tweaking animation on a VSE strip [Graph Editor, Dopwsheet, ...]

2019-09-24 15:13:09 +02:00

Philipp Oeser commented

2019-09-25 11:39:54 +02:00

Just noticed that it actually hangs in BKE_sequencer_prefetch_stop, for some reason the thread is not suspended, loops infinitely here

  while (pfjob->running) {
    BLI_condition_notify_one(&pfjob->prefetch_suspend_cond);
  }

Just noticed that it actually hangs in `BKE_sequencer_prefetch_stop`, for some reason the thread is not suspended, loops infinitely here ``` while (pfjob->running) { BLI_condition_notify_one(&pfjob->prefetch_suspend_cond); } ```

Philipp Oeser commented

2019-09-25 12:12:55 +02:00

Added subscriber: @Sergey

Philipp Oeser commented

2019-09-25 12:12:55 +02:00

Also: just opening that file seems to spawn a thread that never really finishes?
(keeps one CPU core busy here all the time -- without doing anything in that file)

Can even be reproduced much simpler:

File > New > Video Editing
in the Sequencer Editor: Add > Color
on the created Color strip: insert a keyframe (e.g. on Opacity)
in the Preview Editor: enable Prefetch frames
inspect CPU usage :( [never finishes...]

Guess this should be fixed asap?
CC @Sergey

Also: just opening that file seems to spawn a thread that never really finishes? (keeps one CPU core busy here all the time -- without doing anything in that file) Can even be reproduced much simpler: - `File` > `New` > `Video Editing` - in the Sequencer Editor: `Add` > `Color` - on the created Color strip: insert a keyframe (e.g. on Opacity) - in the Preview Editor: enable `Prefetch frames` - inspect CPU usage :( [never finishes...] Guess this should be fixed asap? CC @Sergey

Philipp Oeser changed title from ~~[FREEZE] tweaking animation on a VSE strip [Graph Editor, Dopwsheet, ...]~~ to VSE: 'Prefetch frames' causes excessive CPU usage whenever there is animation on a strip (freezes when tweaking animation [Graph Editor, Dopesheet, typing in new values])

2019-09-25 12:15:34 +02:00

Richard Antalik was assigned by Sergey Sharybin

2019-09-25 12:21:14 +02:00

Sergey Sharybin commented

2019-09-25 12:21:14 +02:00

My guess is that it's caused by ab3a9dc1ed.

My guess is that it's caused by ab3a9dc1ed.

Philipp Oeser commented

2019-09-25 16:51:52 +02:00

Yes, caused by ab3a9dc1ed.

Adding this to 2.81 milestone, if this cant be fixed until then it should probably be reverted?

Yes, caused by ab3a9dc1ed. Adding this to 2.81 milestone, if this cant be fixed until then it should probably be reverted?

Richard Antalik commented

2019-09-26 03:09:27 +02:00

@Sergey
I modified prefetch to use same method as pipeline.c to update animdata (not sure if that has changed), but I get random crashes in depsgraph module.

I am using depsgraph to generate scene copy, and rendering it in separate thread. Not sure if method I use (copied from pipeline.c) is designed to do what I need. This was suggested to me by brecht, but I was not 100% sure about what I was doing.

I can revert to making scene copy using scene API, but this may be bug in depsgraph itself.
You can check my attempt to fix this by patching P1118, and messing with animation, while prefetch is enabled.

To confirm bug in depsgraph, I tried to mess with animation while rendering - no crash and no effect on original data.
(did crash when rendering movie strip, but thats unrelated)

@Sergey I modified prefetch to use same method as pipeline.c to update animdata (not sure if that has changed), but I get random crashes in depsgraph module. I am using depsgraph to generate scene copy, and rendering it in separate thread. Not sure if method I use (copied from pipeline.c) is designed to do what I need. This was suggested to me by brecht, but I was not 100% sure about what I was doing. I can revert to making scene copy using scene API, but this may be bug in depsgraph itself. You can check my attempt to fix this by patching [P1118](https://archive.blender.org/developer/P1118.txt), and messing with animation, while prefetch is enabled. To confirm bug in depsgraph, I tried to mess with animation while rendering - no crash and no effect on original data. (did crash when rendering movie strip, but thats unrelated)

blender-admin commented

2019-10-02 22:04:48 +02:00

This issue was referenced by 2b29bf25fc

This issue was referenced by 2b29bf25fcaa22812a4656c2f4243c037b6b2bb2

Richard Antalik commented

2019-10-02 22:54:08 +02:00

Changed status from 'Open' to: 'Resolved'

Richard Antalik closed this issue

2019-10-02 22:54:08 +02:00

Thomas Dinges added this to the 2.81 milestone 2023-02-08 16:46:56 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

VSE: 'Prefetch frames' causes excessive CPU usage whenever there is animation on a strip (freezes when tweaking animation [Graph Editor, Dopesheet, typing in new values]) #70194