Sculpt partial redraw not working #70295

Open
opened 2019-09-27 11:20:18 +02:00 by Brecht Van Lommel · 9 comments

There are a number of sculpting optimizations that were never made to work in Blender 2.8, which have a significant impact on performance.

  • Clipping of PBVH nodes outside of the viewport is missing, due to missing clipping planes: float(*planes)- [x] = NULL; /* TODO proper culling. */
  • Clipping of PBVH nodes does not use Z planes, so objects behind the camera are not skipped.
  • Workbench anti-aliasing happens during a sculpt stroke, causing the entire 3D viewport to be redrawn while painting a stroke. During a stroke, AA could be disabled similar to RV3D_NAVIGATING. However the area outside of the stroke would remain anti-aliased, which might look bad?

Partial redraw is not working at all currently. The smaller render region never makes it into GPUViewport and the clipping planes for PBVH nodes do not take it into account either.

  • Support partial redraw in GPUViewport
  • Ensure it works for all render passes
  • For effects like cavity and depth of field, make sure the region is expanded to avoid drawing artifacts.
  • Use partial redraw clipping planes for PBVH nodes.
There are a number of sculpting optimizations that were never made to work in Blender 2.8, which have a significant impact on performance. - [x] Clipping of PBVH nodes outside of the viewport is missing, due to missing clipping planes: `float(*planes)- [x] = NULL; /* TODO proper culling. */` - [x] Clipping of PBVH nodes does not use Z planes, so objects behind the camera are not skipped. - [x] Workbench anti-aliasing happens during a sculpt stroke, causing the entire 3D viewport to be redrawn while painting a stroke. During a stroke, AA could be disabled similar to `RV3D_NAVIGATING`. However the area outside of the stroke would remain anti-aliased, which might look bad? Partial redraw is not working at all currently. The smaller render region never makes it into `GPUViewport` and the clipping planes for PBVH nodes do not take it into account either. - [ ] Support partial redraw in `GPUViewport` - [ ] Ensure it works for all render passes - [ ] For effects like cavity and depth of field, make sure the region is expanded to avoid drawing artifacts. - [ ] Use partial redraw clipping planes for PBVH nodes.
Author
Owner

Added subscribers: @brecht, @PabloDobarro

Added subscribers: @brecht, @PabloDobarro

Added subscriber: @ErickNyanduKabongo

Added subscriber: @ErickNyanduKabongo

Added subscriber: @TheRedWaxPolice

Added subscriber: @TheRedWaxPolice

This issue was referenced by f6fc863acd

This issue was referenced by f6fc863acd7c24874026202d4c2aec50c60b40d2

This issue was referenced by 0ffb96f701

This issue was referenced by 0ffb96f701176fe5b3eb03bd90414ed7fd4502cf

Added subscriber: @SirPigeonz

Added subscriber: @SirPigeonz

This issue was referenced by 1ca105ebdc

This issue was referenced by 1ca105ebdccc386aa0a49e5d323be65123881243

This issue was referenced by 9b0fd5ef2a

This issue was referenced by 9b0fd5ef2ae0b2748e505b8bef29c6e25f58efe2
Brecht Van Lommel changed title from Sculpting partial redraw and clipping not working to Sculpt partial redraw not working 2019-09-29 17:39:50 +02:00

Added subscriber: @Andruxa696

Added subscriber: @Andruxa696
Julien Kaspar added this to the Sculpt, Paint & Texture project 2023-02-08 10:48:53 +01:00
Philipp Oeser removed the
Interest
Sculpt, Paint & Texture
label 2023-02-10 09:12:47 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No Assignees
6 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#70295
No description provided.