File browser remembers filters too well #70583

New Issue

Sybren A. Stüvel · 2019-10-06T13:05:30+02:00

Sybren A. Stüvel commented

2019-10-06 13:05:30 +02:00

System Information
Operating system: Windows-10-10.0.17763 64 Bits
Graphics card: GeForce GTX 970/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 436.30

Blender Version
Broken: version: 2.81 (sub 14), branch: master, commit date: 2019-10-05 20:51, hash: 4707f1982d
Worked: probably a week or two ago, before the "it remembers stuff" feature was implemented.

Short description of error
The new File Browser remembers various things, like its layout and filter settings, between invocations. After saving the current blend file, the file browser in the "Video Editing" workspace is set up for showing only blend files.

Exact steps for others to reproduce the error

Open Blender in factory default settings.
Set user preference Interface → Temporary Windows → File Browser to Full Screen.
Save the blend file to a directory that contains video files, say $DIR.
Add the "Video Editing" workspace from the "Video Editing" category.
Look at the file browser in the top left of the screen; it is showing $DIR (which IMO is good), but it doesn't show any of the video files (which is bad for a video editing workspace).
Look at the file browser's filter settings; it's set up to only show blend files.

**System Information** Operating system: Windows-10-10.0.17763 64 Bits Graphics card: GeForce GTX 970/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 436.30 **Blender Version** Broken: version: 2.81 (sub 14), branch: master, commit date: 2019-10-05 20:51, hash: `4707f1982d` Worked: probably a week or two ago, before the "it remembers stuff" feature was implemented. **Short description of error** The new File Browser remembers various things, like its layout and filter settings, between invocations. After saving the current blend file, the file browser in the "Video Editing" workspace is set up for showing only blend files. **Exact steps for others to reproduce the error** * Open Blender in factory default settings. * Set user preference Interface → Temporary Windows → File Browser to Full Screen. * Save the blend file to a directory that contains video files, say $DIR. * Add the "Video Editing" workspace from the "Video Editing" category. * Look at the file browser in the top left of the screen; it is showing $DIR (which IMO is good), but it doesn't show any of the video files (which is bad for a video editing workspace). * Look at the file browser's filter settings; it's set up to only show blend files.

Sybren A. Stüvel commented

2019-10-06 13:05:30 +02:00

Added subscriber: @dr.sybren

Julian Eisel was assigned by Sybren A. Stüvel

2019-10-06 13:06:13 +02:00

Julian Eisel commented

2019-10-07 17:51:39 +02:00

I can't recreate this here, at least not with given steps.
Opening a file browser through an operator like Ctrl+S intentionally runs a different initialization path than a regular file browser editor. Only in the former case we restore the settings.

The only way I see this could break is when the file browser is launched in full screen mode ({nav Preferences > Interface > Editors > Temporary Windows}) from the already opened file browser editor in the Video Editing workspace. The old fullscreen code uses the same space data then for the regular and the fullscreen file browser. We might in fact want to change this here.

Anyway, I'm not sure how this could break and I can't recreate this. Are you sure the given steps are correct?

I can't recreate this here, at least not with given steps. Opening a file browser through an operator like Ctrl+S intentionally runs a different initialization path than a regular file browser editor. Only in the former case we restore the settings. The only way I see this could break is when the file browser is launched in full screen mode ({nav Preferences > Interface > Editors > Temporary Windows}) from the already opened file browser editor in the *Video Editing* workspace. The old fullscreen code uses the same space data then for the regular and the fullscreen file browser. We might in fact want to change this here. Anyway, I'm not sure how this could break and I can't recreate this. Are you sure the given steps are correct?

Bastien Montagne commented

2019-10-14 10:56:36 +02:00

Added subscriber: @mont29

Bastien Montagne commented

2019-10-14 10:56:36 +02:00

This is still needing feedback… You should be able to sort that at the studio directly?

Julian Eisel commented

2019-10-14 11:01:16 +02:00

Sybren wasn't here for most of last week, he will be back tomorrow I think.

Sybren A. Stüvel commented

2019-10-14 14:09:59 +02:00

Yup, I'll be @ BI tomorrow.

Sybren A. Stüvel commented

2019-10-15 12:25:53 +02:00

It requires setting the user pref Interface → Temporary Windows → File Browser to Full Screen. @JulianEisel and I did a quick test and it also happens in 2.79 (and probably older).

Julian Eisel commented

2019-10-15 12:33:47 +02:00

It's also important that your mouse hovers the existing File Editor while doing {nav Ctrl+S}, {nav Ctrl+O} or whatever.
My earlier post explains what's happening. Basically it is an old issue from the way the fullscreen areas are designed/implemented.
Strictly speaking it isn't a bug even. I'd like to look into it nevertheless.

Again for the records, this was not introduced by our changes, they just made it more apparent.

It's also important that your mouse hovers the existing File Editor while doing {nav Ctrl+S}, {nav Ctrl+O} or whatever. My earlier post explains what's happening. Basically it is an old issue from the way the fullscreen areas are designed/implemented. Strictly speaking it isn't a bug even. I'd like to look into it nevertheless. Again for the records, this was not introduced by our changes, they just made it more apparent.

Brecht Van Lommel commented

2019-10-25 05:21:10 +02:00

Added subscriber: @brecht

Brecht Van Lommel commented

2019-10-25 05:21:10 +02:00

If it happens in 2.79 it's not a 2.81 blocker.

Julian Eisel commented

2019-11-11 12:34:52 +01:00

This isn't a bug strictly speaking, since it behaves as designed. The old design is pretty useless though, so leaving this open as a ToDo task.

Julian Eisel commented

2019-12-09 15:27:11 +01:00

Changed status from 'Open' to: 'Archived'

Julian Eisel closed this issue

2019-12-09 15:27:11 +01:00

Julian Eisel commented

2019-12-09 15:27:11 +01:00

Getting this to work in a non hackish way would require some general changes. Ideally, I'd like to rework the entire fullscreen code, the way it is currently is not very flexible and has long reached its limits. We already added many hacks to get it to do what we want, it's very difficult to understand what's going on internally.

So while I agree this sucks, this is something for the UI TODO list, added an entry there.

Getting this to work in a non hackish way would require some general changes. Ideally, I'd like to rework the entire fullscreen code, the way it is currently is not very flexible and has long reached its limits. We already added many hacks to get it to do what we want, it's very difficult to understand what's going on internally. So while I agree this sucks, this is something for the UI TODO list, added an entry there.

Julian Eisel commented

2019-12-10 16:59:18 +01:00

Thinking about this while investigating a related bug - what are you thoughts on entirely destroying SpaceFile.params when closing a temp file browser @mont29? That would solve issues like these, and I think it's reasonable to keep these parameters separate for regular file editors from temporary ones.

I guess we'd want to keep the params of the regular editor around so we can restore them on temp editor exit.

Sounds like a reasonable & simple workaround that doesn't require rewriting fullscreen handling.

Thinking about this while investigating a related bug - what are you thoughts on entirely destroying `SpaceFile.params` when closing a temp file browser @mont29? That would solve issues like these, and I think it's reasonable to keep these parameters separate for regular file editors from temporary ones. I guess we'd want to keep the params of the regular editor around so we can restore them on temp editor exit. Sounds like a reasonable & simple workaround that doesn't require rewriting fullscreen handling.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

File browser remembers filters too well #70583