Switch Blender task scheduler to use TBB #70709

Closed
opened 2019-10-10 17:46:41 +02:00 by Brecht Van Lommel · 11 comments

In 6c302d6 we switched to TBB for sculpting, to avoid threading overhead issues on some platforms.

Rather than trying to make our own optimize task scheduler implementation, we should switch to TBB. If we use it everywhere, we can have a single thread pool for Cycles, Mantaflow, OpenVDB and the rest of Blender. It could also help improve performance in some areas.

An experimental patch from 2017 by Sergey is here:
0001-Experiment-using-TBB-for-task-scheduling.patch

In 6c302d6 we switched to TBB for sculpting, to avoid threading overhead issues on some platforms. Rather than trying to make our own optimize task scheduler implementation, we should switch to TBB. If we use it everywhere, we can have a single thread pool for Cycles, Mantaflow, OpenVDB and the rest of Blender. It could also help improve performance in some areas. An experimental patch from 2017 by Sergey is here: [0001-Experiment-using-TBB-for-task-scheduling.patch](https://archive.blender.org/developer/F7801002/0001-Experiment-using-TBB-for-task-scheduling.patch)
Author
Owner

Added subscribers: @brecht, @mont29, @Sergey

Added subscribers: @brecht, @mont29, @Sergey

I hope that this partial switch to tbb does not bite us in some unexpected ways… would have rather switched entirely…

But in general, yes, think switching to tbb would avoid us spending a lot of time re-inventing the wheel, since there's already a state-of-the-art lib available for that.

Also, would not mind to get D5371 in before we do that switch, otherwise i’ll have to redo that work again.

I hope that this partial switch to tbb does not bite us in some unexpected ways… would have rather switched entirely… But in general, yes, think switching to tbb would avoid us spending a lot of time re-inventing the wheel, since there's already a state-of-the-art lib available for that. Also, would not mind to get [D5371](https://archive.blender.org/developer/D5371) in before we do that switch, otherwise i’ll have to redo that work again.

Added subscriber: @bent

Added subscriber: @bent
Author
Owner

Here's an initial implementation I made a few weeks ago:
https://developer.blender.org/diffusion/B/history/temp-tbb-task-scheduler/

I don't intend to work on this in the next two months, but if someone else wants to work in this area it's there.

Here's an initial implementation I made a few weeks ago: https://developer.blender.org/diffusion/B/history/temp-tbb-task-scheduler/ I don't intend to work on this in the next two months, but if someone else wants to work in this area it's there.
vedawyqaj commented 2020-03-11 19:03:27 +01:00 (Migrated from localhost:3001)

Added subscriber: @vedawyqaj

Added subscriber: @vedawyqaj
vedawyqaj commented 2020-03-11 19:03:27 +01:00 (Migrated from localhost:3001)

This comment was removed by @vedawyqaj

*This comment was removed by @vedawyqaj*

This issue was referenced by 78f56d5582

This issue was referenced by 78f56d5582d71e001cc1326b7182aa39f9bdedec
Jeroen Bakker self-assigned this 2020-04-17 08:14:56 +02:00

This issue was referenced by d923fb784f

This issue was referenced by d923fb784f4f429c066ceb807c669a4308c1d9b4

Added subscriber: @ckohl_art

Added subscriber: @ckohl_art

This issue was referenced by d8a3f3595a

This issue was referenced by d8a3f3595af0fb3ca5937e41c2728fd750d986ef
Author
Owner

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#70709
No description provided.