GPencil: New Primitive Polyline Tool #70927

Closed
opened 2019-10-18 22:12:43 +02:00 by Charlie Jolly · 15 comments
Member

Create a new polyline tool for GPencil. This is to replace functionality removed in a general tidy up of GPcode.

Create a new polyline tool for GPencil. This is to replace functionality removed in a general tidy up of GPcode.
Author
Member

Added subscriber: @CharlieJolly

Added subscriber: @CharlieJolly
Antonio Vazquez changed title from GPencil: Primitive: Polyline Tool to GPencil: New Primitive Polyline Tool 2019-10-18 22:13:48 +02:00
Charlie Jolly was assigned by Antonio Vazquez 2019-10-18 22:14:35 +02:00

Added subscriber: @antoniov

Added subscriber: @antoniov

I will do the cleanup of the old unused polyline code in gpencil.draw operator.

I will do the cleanup of the old unused polyline code in gpencil.draw operator.

Added subscriber: @WilliamReynish

Added subscriber: @WilliamReynish

@WilliamReynish We will need a new tool icon for the poly line tool. The tool is to draw polygons clicking with the mouse.

@WilliamReynish We will need a new tool icon for the poly line tool. The tool is to draw polygons clicking with the mouse.

Added subscribers: @mendio, @pepe-school-land

Added subscribers: @mendio, @pepe-school-land

@CharlieJolly We have missed the F and Shift+F keys in this primitive as we have in the other primitives. Could you implement it?

@CharlieJolly We have missed the `F` and `Shift+F` keys in this primitive as we have in the other primitives. Could you implement it?

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'

Added subscriber: @AdamEarle

Added subscriber: @AdamEarle

This guys is doing some pretty amazing work.
https:*youtu.be/4XrjpWwLU4M?t=90
It's worthwhile taking a look at his playlist and seeing what tools could be integrated.

We also need a way to control line thickness something to similar to this https:*www.youtube.com/watch?v=1YtLrMOoai

  • The that we achieve this at the moment is that we use the thickness tool crush the line down to 0 first
  • then we scale the thickness of the line

It shouldn't be too hard to string those activities together. I'll make a clip to demonstrate the workflow at the moment to gain more control over the line.
Here is a link to how to get around line weight.
Link: https:*www.youtube.com/watch?v=nUPIBMgZI0M&feature=youtu.be

Circle tool could also be used this way: https:*youtu.be/oYgDHxBp_z4?t=306

This guys is doing some pretty amazing work. [https:*youtu.be/4XrjpWwLU4M?t=90 ](https:*www.youtube.com/watch?v=4XrjpWwLU4M&feature=youtu.be&t=90) It's worthwhile taking a look at his playlist and seeing what tools could be integrated. We also need a way to control line thickness something to similar to this [https:*www.youtube.com/watch?v=1YtLrMOoai ](https:*www.youtube.com/watch?v=1YtLrMOoaiY) - The that we achieve this at the moment is that we use the thickness tool crush the line down to 0 first - then we scale the thickness of the line It shouldn't be too hard to string those activities together. I'll make a clip to demonstrate the workflow at the moment to gain more control over the line. Here is a link to how to get around line weight. Link: [https:*www.youtube.com/watch?v=nUPIBMgZI0M&feature=youtu.be ](https:*www.youtube.com/watch?v=nUPIBMgZI0M&feature=youtu.be) Circle tool could also be used this way: [https:*youtu.be/oYgDHxBp_z4?t=306 ](https:*youtu.be/oYgDHxBp_z4?t=306)

@AdamEarle Looks good. Does he want to submit his work as patches here?

@AdamEarle Looks good. Does he want to submit his work as patches here?

I guess its just a matter of asking. I will see if I can make proper formal contact with him and point him to here

I guess its just a matter of asking. I will see if I can make proper formal contact with him and point him to here

In #70927#845026, @WilliamReynish wrote:
@AdamEarle Looks good. Does he want to submit his work as patches here?

Introducing the addon as a patch.
It is a python Addon and is about 8000 lines.

I am wondering if there is a way that we can help this guy out.

Bellow is the email:

Hello Mr Earle

I appreciate your taking the time to have a look at the videos and sharing your feedback with the Blender team.

Before I submit the add-on as a patch, I would like to do a few things:

  • refactor the code into separate reusable modules (like Snapper etc.). Currently the add-on is just a big monolithic py file, which would be really cumbersome to maintain for others and also it is not very reusable. The refactoring might take some time since the code has grown to ~ 8000 lines by now
  • add some important functionality (like boolean if possible) and make the tools a bit more complete, because after submitting it, the add-on will have to follow Blender release cycles
  • do some more testing and allow tool users to test it out for some more time so that at least the obvious defects are detected and fixed before the code lands in Blender repository

BTW there is an implementation of polygon tool (both as Grease Pencil strokes and Bezier curves) in the toolkit.
You might want to see these videos: [https:*youtu.be/q-rokc3oOv0 ]] and for circle / ellipse: [ https:*youtu.be/t7eVWP8gxeE | https:*youtu.be/t7eVWP8gxeE

Do keep sharing your valuable feedback.

I am a bit tied up today for the chat. But I have a chat account on blender.chat (id: --------------).
So we can meet there whenever it's convenient for you. Just leave me a message if I am not online.

Thanks and best regards
Shrinivas Kulkarni

> In #70927#845026, @WilliamReynish wrote: > @AdamEarle Looks good. Does he want to submit his work as patches here? Introducing the addon as a patch. It is a python Addon and is about 8000 lines. I am wondering if there is a way that we can help this guy out. Bellow is the email: Hello Mr Earle I appreciate your taking the time to have a look at the videos and sharing your feedback with the Blender team. Before I submit the add-on as a patch, I would like to do a few things: - refactor the code into separate reusable modules (like Snapper etc.). Currently the add-on is just a big monolithic py file, which would be really cumbersome to maintain for others and also it is not very reusable. The refactoring might take some time since the code has grown to ~ 8000 lines by now - add some important functionality (like boolean if possible) and make the tools a bit more complete, because after submitting it, the add-on will have to follow Blender release cycles - do some more testing and allow tool users to test it out for some more time so that at least the obvious defects are detected and fixed before the code lands in Blender repository BTW there is an implementation of polygon tool (both as Grease Pencil strokes and Bezier curves) in the toolkit. You might want to see these videos: [https:*youtu.be/q-rokc3oOv0 ]] and for circle / ellipse: [[ https:*youtu.be/t7eVWP8gxeE | https:*youtu.be/t7eVWP8gxeE ](https:*youtu.be/q-rokc3oOv0) Do keep sharing your valuable feedback. I am a bit tied up today for the chat. But I have a chat account on blender.chat (id: --------------). So we can meet there whenever it's convenient for you. Just leave me a message if I am not online. Thanks and best regards Shrinivas Kulkarni

I don't think this task is the place to discuss about the addon or new features.

In case you want discuss about this in phabricator, please create a design task with the right Header description.

I don't think this task is the place to discuss about the addon or new features. In case you want discuss about this in phabricator, please create a design task with the right Header description.

In #70927#845912, @antoniov wrote:
I don't think this task is the place to discuss about the addon or new features.

In case you want discuss about this in phabricator, please create a design task with the right Header description.

Sorry about that matey can you point me in the right direction of "phabricator". We use a Kanban system in the studio is that what you are talking about?

> In #70927#845912, @antoniov wrote: > I don't think this task is the place to discuss about the addon or new features. > > In case you want discuss about this in phabricator, please create a design task with the right Header description. Sorry about that matey can you point me in the right direction of "phabricator". We use a Kanban system in the studio is that what you are talking about?
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#70927
No description provided.