X3D Import does not handle Materials #71232

New Issue

Jose Xavier · 2019-10-30T23:18:15+01:00

Jose Xavier commented

2019-10-30 23:18:15 +01:00

System Information
Operating system: Windows 10
Graphics card: GT 1070

Blender Version
Broken: 2.90, 0330d1af29c0

Short description of error
When an X3D file is imported and that file has a Material tag no corresponding material is added in blender. Materials are supported for other formats like OBJ.

Example:

   <Material DEF="MA_Material"  
        diffuseColor="1.000 0.0 0.0"
        specularColor="0.401 0.401 0.401"
        emissiveColor="0.000 0.000 0.000"
        ambientIntensity="0.000"
        shininess="0.500"
        transparency="0.0"/>

Exact steps for others to reproduce the error

File -> New -> General
remove the existing cube
File -> Import -> X3D ...
Select the imported cube (note the color is still the default gray)
Select the cube, look at its material, there is no material.

red-cube.x3d

red-cube.blend

Material import was more or less disabled in e8da70ab73

**System Information** Operating system: Windows 10 Graphics card: GT 1070 **Blender Version** Broken: 2.90, 0330d1af29c0 **Short description of error** When an X3D file is imported and that file has a Material tag no corresponding material is added in blender. Materials are supported for other formats like OBJ. Example: ``` <Material DEF="MA_Material" diffuseColor="1.000 0.0 0.0" specularColor="0.401 0.401 0.401" emissiveColor="0.000 0.000 0.000" ambientIntensity="0.000" shininess="0.500" transparency="0.0"/> ``` **Exact steps for others to reproduce the error** * File -> New -> General * remove the existing cube * File -> Import -> X3D ... * Select the imported cube (note the color is still the default gray) * Select the cube, look at its material, there is no material. [red-cube.x3d](https://archive.blender.org/developer/F8954834/red-cube.x3d) [red-cube.blend](https://archive.blender.org/developer/F8954831/red-cube.blend) Material import was more or less disabled in e8da70ab73

Jose Xavier commented

2019-10-30 23:18:15 +01:00

Added subscriber: @jose.xavier

blender-admin commented

2019-10-30 23:18:15 +01:00

#81519 was marked as duplicate of this issue

blender-admin commented

2019-10-30 23:18:15 +01:00

blender/blender#81437 was marked as duplicate of this issue

Philipp Oeser commented

2020-01-15 18:04:24 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2020-01-15 18:04:24 +01:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Philipp Oeser commented

2020-01-15 18:04:24 +01:00

Hi there and thx for the report (sorry this has been lying around).

Possibly normals are inverted, but to really investigate, could you share one of those .wrl files so we can check?

Hi there and thx for the report (sorry this has been lying around). Possibly normals are inverted, but to really investigate, could you share one of those .wrl files so we can check?

Maurice commented

2020-01-23 21:15:08 +01:00

Added subscriber: @easyw

Maurice commented

2020-01-23 21:15:08 +01:00

@lichtwerk
you can test any of the KiCAD 3D model wrl files...
I used to import those files in Blender and it worked fine till 2.7.9
With Blender 2.8 the wrl just loses colors.
(tested with blender-2.81a-linux-glibc217-x86_64)
i.e. you can try this file
https://github.com/KiCad/kicad-packages3D/raw/master/Capacitor_SMD.3dshapes/CP_Elec_10x10.5.wrl
or
https://raw.githubusercontent.com/KiCad/kicad-packages3D/master/Capacitor_Tantalum_SMD.3dshapes/CP_EIA-7343-30_AVX-N.wrl

@lichtwerk you can test any of the KiCAD 3D model wrl files... I used to import those files in Blender and it worked fine till 2.7.9 With Blender 2.8 the wrl just loses colors. (tested with blender-2.81a-linux-glibc217-x86_64) i.e. you can try this file https://github.com/KiCad/kicad-packages3D/raw/master/Capacitor_SMD.3dshapes/CP_Elec_10x10.5.wrl or https://raw.githubusercontent.com/KiCad/kicad-packages3D/master/Capacitor_Tantalum_SMD.3dshapes/CP_EIA-7343-30_AVX-N.wrl

Aaron Carlisle commented

2020-02-10 18:05:48 +01:00

Changed status from 'Needs User Info' to: 'Needs Developer To Reproduce'

Adam commented

2020-05-11 22:09:58 +02:00

Added subscriber: @adammak

Adam commented

2020-05-11 22:09:58 +02:00

The cause of that is return in 2699th line of code in import_x3d.py which returns the method. Moreover, the color vectors need alpha value to be added.
I submitted bug, there is temporary fix you can use:

def appearance_CreateMaterial(vrmlname, mat, ancestry, is_vcol):
    bpymat = bpy.data.materials.new(vrmlname)
    diff_color = mat.getFieldAsFloatTuple('diffuseColor', [0.5, 0.5, 0.5, 1], ancestry)
    
    if(len(diff_color) == 3):
        # .wrl does not have alpha, we need to add 4th element
        diff_color = diff_color+[1]
    bpymat.diffuse_color = diff_color

    spec_color = mat.getFieldAsFloatTuple('specularColor', [0.0, 0.0, 0.0, 1], ancestry)

    if(len(spec_color) == 3):
        # .wrl does not have alpha, we need to add 4th element
        spec_color = spec_color + [1]
    bpymat.specular_color = diff_color

    if False and is_vcol:
        bpymat.use_vertex_color_paint = True
    return bpymat

The cause of that is return in 2699th line of code in import_x3d.py which returns the method. Moreover, the color vectors need alpha value to be added. I submitted bug, there is temporary fix you can use: ``` def appearance_CreateMaterial(vrmlname, mat, ancestry, is_vcol): bpymat = bpy.data.materials.new(vrmlname) diff_color = mat.getFieldAsFloatTuple('diffuseColor', [0.5, 0.5, 0.5, 1], ancestry) if(len(diff_color) == 3): # .wrl does not have alpha, we need to add 4th element diff_color = diff_color+[1] bpymat.diffuse_color = diff_color spec_color = mat.getFieldAsFloatTuple('specularColor', [0.0, 0.0, 0.0, 1], ancestry) if(len(spec_color) == 3): # .wrl does not have alpha, we need to add 4th element spec_color = spec_color + [1] bpymat.specular_color = diff_color if False and is_vcol: bpymat.use_vertex_color_paint = True return bpymat ```

Ankit Meel commented

2020-05-12 11:55:22 +02:00

Added subscriber: @ankitm

Bastien Montagne commented

2020-05-27 18:19:37 +02:00

Added subscriber: @mont29

Bastien Montagne commented

2020-05-27 18:19:37 +02:00

Note that proper solution would be to add support for shader nodes, but that is a fairly big project...

K. S. commented

2020-10-02 20:42:03 +02:00

Added subscriber: @khavin

K. S. commented

2020-10-02 20:42:03 +02:00

Any update on this? It may be something else, but I'm still experiencing the lack of colors on 2.90.1 running on Windows 10 2004. The .wrl was generated by KiCAD 5.1.6.

Philipp Oeser commented

2020-10-05 09:59:59 +02:00

Changed status from 'Needs Developer To Reproduce' to: 'Confirmed'

Philipp Oeser changed title from ~~Import WRL shows no color~~ to X3D Import does not handle Materials

2020-10-05 10:19:41 +02:00

Philipp Oeser commented

2020-10-05 10:20:55 +02:00

Added subscriber: @the_magnet_girl

Philipp Oeser commented

2020-10-08 10:45:49 +02:00

Added subscriber: @Justin.kedl

Mario Ambrogetti commented

2020-10-21 11:15:35 +02:00

Added subscriber: @marioamb

Bernhard R commented

2020-11-10 16:39:20 +01:00

Added subscriber: @jr-br

Bernhard R commented

2020-11-10 16:39:20 +01:00

Thanks a lot for this workaround, @adammak!
I fixed two little issues for myself when I applied it, one is that your code assigened diff_color to bymat.specular_color instead of spec_color, and the second is that that field does not seem to like the alpha value:

    bpymat.specular_color = diff_color
ValueError: bpy_struct: item.attr = val: sequences of dimension 0 should contain 3 items, not 4

... which makes it:

def appearance_CreateMaterial(vrmlname, mat, ancestry, is_vcol):
    bpymat = bpy.data.materials.new(vrmlname)
    diff_color = mat.getFieldAsFloatTuple('diffuseColor', [0.5, 0.5, 0.5, 1], ancestry)

    if(len(diff_color) == 3):
        # .wrl does not have alpha, we need to add 4th element
        diff_color = diff_color+[1]
    bpymat.diffuse_color = diff_color

    spec_color = mat.getFieldAsFloatTuple('specularColor', [0.0, 0.0, 0.0], ancestry)

    bpymat.specular_color = spec_color

    return bpymat

I am currently using Blender 2.90.1.

In #71232#929226, @adammak wrote:
The cause of that is return in 2699th line of code in import_x3d.py which returns the method. Moreover, the color vectors need alpha value to be added.
I submitted bug, there is temporary fix you can use:

def appearance_CreateMaterial(vrmlname, mat, ancestry, is_vcol):
    bpymat = bpy.data.materials.new(vrmlname)
    diff_color = mat.getFieldAsFloatTuple('diffuseColor', [0.5, 0.5, 0.5, 1], ancestry)
    
    if(len(diff_color) == 3):
        # .wrl does not have alpha, we need to add 4th element
        diff_color = diff_color+[1]
    bpymat.diffuse_color = diff_color

    spec_color = mat.getFieldAsFloatTuple('specularColor', [0.0, 0.0, 0.0, 1], ancestry)

    if(len(spec_color) == 3):
        # .wrl does not have alpha, we need to add 4th element
        spec_color = spec_color + [1]
    bpymat.specular_color = diff_color

    if False and is_vcol:
        bpymat.use_vertex_color_paint = True
    return bpymat

Thanks a lot for this workaround, @adammak! I fixed two little issues for myself when I applied it, one is that your code assigened diff_color to bymat.specular_color instead of spec_color, and the second is that that field does not seem to like the alpha value: ``` bpymat.specular_color = diff_color ValueError: bpy_struct: item.attr = val: sequences of dimension 0 should contain 3 items, not 4 ``` ... which makes it: ``` def appearance_CreateMaterial(vrmlname, mat, ancestry, is_vcol): bpymat = bpy.data.materials.new(vrmlname) diff_color = mat.getFieldAsFloatTuple('diffuseColor', [0.5, 0.5, 0.5, 1], ancestry) if(len(diff_color) == 3): # .wrl does not have alpha, we need to add 4th element diff_color = diff_color+[1] bpymat.diffuse_color = diff_color spec_color = mat.getFieldAsFloatTuple('specularColor', [0.0, 0.0, 0.0], ancestry) bpymat.specular_color = spec_color return bpymat ``` I am currently using Blender 2.90.1. > In #71232#929226, @adammak wrote: > The cause of that is return in 2699th line of code in import_x3d.py which returns the method. Moreover, the color vectors need alpha value to be added. > I submitted bug, there is temporary fix you can use: > > > ``` > def appearance_CreateMaterial(vrmlname, mat, ancestry, is_vcol): > bpymat = bpy.data.materials.new(vrmlname) > diff_color = mat.getFieldAsFloatTuple('diffuseColor', [0.5, 0.5, 0.5, 1], ancestry) > > if(len(diff_color) == 3): > # .wrl does not have alpha, we need to add 4th element > diff_color = diff_color+[1] > bpymat.diffuse_color = diff_color > > spec_color = mat.getFieldAsFloatTuple('specularColor', [0.0, 0.0, 0.0, 1], ancestry) > > if(len(spec_color) == 3): > # .wrl does not have alpha, we need to add 4th element > spec_color = spec_color + [1] > bpymat.specular_color = diff_color > > if False and is_vcol: > bpymat.use_vertex_color_paint = True > return bpymat > ```

Harrison Weed commented

2021-03-08 11:08:18 +01:00

Added subscriber: @RigoLigo

Harrison Weed commented

2021-03-08 11:08:18 +01:00

I tried to port appearance_CreateMaterial and appearance_CreateDefaultMaterial to shader nodes and seem to work fine. I'll see if I can submit the patch after taking some time refining it...

Basically tuple size can be solved by expanding it with (*diff_color, 1.0);

By setting bpymat.use_nodes to True enables node tree, then you can modify the nodes with something like bpymat.node_tree.nodes['Principled BSDF'].inputs['Base Color'].default_value = (*diff_color, 1.0).

Haven't tried to port image textures yet, but should be pretty trivial to add, as linking node tree is also simple.

I tried to port `appearance_CreateMaterial` and `appearance_CreateDefaultMaterial` to shader nodes and seem to work fine. I'll see if I can submit the patch after taking some time refining it... Basically tuple size can be solved by expanding it with `(*diff_color, 1.0)`; By setting `bpymat.use_nodes` to `True` enables node tree, then you can modify the nodes with something like `bpymat.node_tree.nodes['Principled BSDF'].inputs['Base Color'].default_value = (*diff_color, 1.0)`. Haven't tried to port image textures yet, but should be pretty trivial to add, as linking node tree is also simple.

blender-admin commented

2021-10-27 12:23:39 +02:00

This issue was referenced by 0573bc7dae

This issue was referenced by 0573bc7daeb1e5fc1e0d0e6a37c5efc043aebb13

Bastien Montagne commented

2021-10-27 12:27:51 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Bastien Montagne closed this issue

2021-10-27 12:27:51 +02:00

Bastien Montagne self-assigned this 2021-10-27 12:27:51 +02:00

Sign in to join this conversation.