Rigify: Generate error with basic.copy_chain #71447

New Issue

Ovionis · 2019-11-09T14:11:44+01:00

Ovionis commented

2019-11-09 14:11:44 +01:00

System Information
Operating system: Windows-7-6.1.7601-SP1 64 Bits
Graphics card: GeForce GTX 770/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 436.48

Blender Version
Broken: version: 2.82 (sub 1), branch: master, commit date: 2019-11-09 02:09, hash: blender/blender@6f1237b2eb

Short description of error
Generation has thrown an exception: 'Rig' object has no attribute 'rename_deform'

basic.copy_chain.blend
Just a bone chain set to basic.copy_chain. When you click generate, you get an error and this in the console:

Traceback (most recent call last):
  File "C:\Program Files\Blender Foundation\Blender\2.82\scripts\addons\rigify\ui.py", line 758, in execute
    generate.generate_rig(context, context.object)
  File "C:\Program Files\Blender Foundation\Blender\2.82\scripts\addons\rigify\generate.py", line 521, in generate_rig
    raise e
  File "C:\Program Files\Blender Foundation\Blender\2.82\scripts\addons\rigify\generate.py", line 509, in generate_rig
    Generator(context, metarig).generate()
  File "C:\Program Files\Blender Foundation\Blender\2.82\scripts\addons\rigify\generate.py", line 466, in generate
    self.invoke_finalize()
  File "C:\Program Files\Blender Foundation\Blender\2.82\scripts\addons\rigify\base_generate.py", line 329, in invoke_finalize
    self.__run_object_stage('finalize')
  File "C:\Program Files\Blender Foundation\Blender\2.82\scripts\addons\rigify\base_generate.py", line 242, in __run_object_stage
    rig.rigify_invoke_stage(method_name)
  File "C:\Program Files\Blender Foundation\Blender\2.82\scripts\addons\rigify\utils\metaclass.py", line 145, in rigify_invoke_stage
    getattr(self, stage)()
  File "C:\Program Files\Blender Foundation\Blender\2.82\scripts\addons\rigify\rigs\basic\copy_chain.py", line 105, in finalize
    if self.rename_deform:
AttributeError: 'Rig' object has no attribute 'rename_deform'
Error: Generation has thrown an exception: 'Rig' object has no attribute 'rename_deform'

The issue is that line #50 is self.rename_deforms and line #105 is self.rename_deform

Changing either works but I assume it's preferable to change #105, since while it uses the same name as basic.super_copy, make_deforms var is plural because it affects multiple bones.

**System Information** Operating system: Windows-7-6.1.7601-SP1 64 Bits Graphics card: GeForce GTX 770/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 436.48 **Blender Version** Broken: version: 2.82 (sub 1), branch: master, commit date: 2019-11-09 02:09, hash: `blender/blender@6f1237b2eb` **Short description of error** Generation has thrown an exception: 'Rig' object has no attribute 'rename_deform' [basic.copy_chain.blend](https://archive.blender.org/developer/F8002889/basic.copy_chain.blend) Just a bone chain set to basic.copy_chain. When you click generate, you get an error and this in the console: ``` Traceback (most recent call last): File "C:\Program Files\Blender Foundation\Blender\2.82\scripts\addons\rigify\ui.py", line 758, in execute generate.generate_rig(context, context.object) File "C:\Program Files\Blender Foundation\Blender\2.82\scripts\addons\rigify\generate.py", line 521, in generate_rig raise e File "C:\Program Files\Blender Foundation\Blender\2.82\scripts\addons\rigify\generate.py", line 509, in generate_rig Generator(context, metarig).generate() File "C:\Program Files\Blender Foundation\Blender\2.82\scripts\addons\rigify\generate.py", line 466, in generate self.invoke_finalize() File "C:\Program Files\Blender Foundation\Blender\2.82\scripts\addons\rigify\base_generate.py", line 329, in invoke_finalize self.__run_object_stage('finalize') File "C:\Program Files\Blender Foundation\Blender\2.82\scripts\addons\rigify\base_generate.py", line 242, in __run_object_stage rig.rigify_invoke_stage(method_name) File "C:\Program Files\Blender Foundation\Blender\2.82\scripts\addons\rigify\utils\metaclass.py", line 145, in rigify_invoke_stage getattr(self, stage)() File "C:\Program Files\Blender Foundation\Blender\2.82\scripts\addons\rigify\rigs\basic\copy_chain.py", line 105, in finalize if self.rename_deform: AttributeError: 'Rig' object has no attribute 'rename_deform' Error: Generation has thrown an exception: 'Rig' object has no attribute 'rename_deform' ``` The issue is that line #50 is `self.rename_deforms` and line #105 is `self.rename_deform` Changing either works but I assume it's preferable to change #105, since while it uses the same name as `basic.super_copy`, `make_deforms` var is plural because it affects multiple bones.

Ovionis commented

2019-11-09 14:11:44 +01:00

Added subscriber: @Phigon

Ivan Cappiello commented

2019-12-19 11:17:21 +01:00

Added subscriber: @icappiello

Alexander Gavrilov was assigned by Ivan Cappiello

2019-12-19 11:17:21 +01:00

Ivan Cappiello commented

2019-12-19 11:17:21 +01:00

I think 'Rename to Deform" option should not be available in copy_chain rig.
basic.copy_chain is intended to just include users custom rig setup in final rigify generated rig.
If the intent here is rename the bone to "DEF-" instead of "ORG-" i'd manage it as for "MCH-":
whenever a bone is on MCH layer (layer 31) its name will be prepended with an MCH- prefix.

I think 'Rename to Deform" option should not be available in copy_chain rig. basic.copy_chain is intended to just include users custom rig setup in final rigify generated rig. If the intent here is rename the bone to "DEF-" instead of "ORG-" i'd manage it as for "MCH-": whenever a bone is on MCH layer (layer 31) its name will be prepended with an MCH- prefix.

Alexander Gavrilov commented

2019-12-22 16:54:13 +01:00

Changed status from 'Open' to: 'Resolved'

Alexander Gavrilov closed this issue

2019-12-22 16:54:13 +01:00

Alexander Gavrilov commented

2019-12-22 16:54:13 +01:00

Removed this option, introducing a new basic.raw_copy rig type to cover its purpose.

Removed this option, introducing a new `basic.raw_copy` rig type to cover its purpose.

Ovionis commented

2019-12-23 00:27:58 +01:00

a50e874849